From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753368AbeAQNdP (ORCPT + 1 other); Wed, 17 Jan 2018 08:33:15 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:37871 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752612AbeAQNdN (ORCPT ); Wed, 17 Jan 2018 08:33:13 -0500 X-ME-Sender: Date: Wed, 17 Jan 2018 14:33:00 +0100 From: Greg KH To: ShuFanLee Cc: heikki.krogerus@linux.intel.com, cy_huang@richtek.com, shufan_lee@richtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver Message-ID: <20180117133300.GC3188@kroah.com> References: <1515567552-7692-1-git-send-email-leechu729@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515567552-7692-1-git-send-email-leechu729@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 10, 2018 at 02:59:12PM +0800, ShuFanLee wrote: > +static inline void rt1711h_poll_ctrl(struct rt1711h_chip *chip) > +{ > + cancel_delayed_work_sync(&chip->poll_work); > + > + if (atomic_read(&chip->poll_count) == 0) { > + atomic_inc(&chip->poll_count); > + cpu_idle_poll_ctrl(true); > + } > + > + schedule_delayed_work(&chip->poll_work, msecs_to_jiffies(40)); > +} This is very odd, and not good. What are you trying to do here? And why are you thinking that poll_count should be an atomic variable? This feels really strange, and not something you should be doing in an irq handler, right? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB TYPEC: RT1711H Type-C Chip Driver From: Greg KH Message-Id: <20180117133300.GC3188@kroah.com> Date: Wed, 17 Jan 2018 14:33:00 +0100 To: ShuFanLee Cc: heikki.krogerus@linux.intel.com, cy_huang@richtek.com, shufan_lee@richtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gV2VkLCBKYW4gMTAsIDIwMTggYXQgMDI6NTk6MTJQTSArMDgwMCwgU2h1RmFuTGVlIHdyb3Rl Ogo+ICtzdGF0aWMgaW5saW5lIHZvaWQgcnQxNzExaF9wb2xsX2N0cmwoc3RydWN0IHJ0MTcxMWhf Y2hpcCAqY2hpcCkKPiArewo+ICsJY2FuY2VsX2RlbGF5ZWRfd29ya19zeW5jKCZjaGlwLT5wb2xs X3dvcmspOwo+ICsKPiArCWlmIChhdG9taWNfcmVhZCgmY2hpcC0+cG9sbF9jb3VudCkgPT0gMCkg ewo+ICsJCWF0b21pY19pbmMoJmNoaXAtPnBvbGxfY291bnQpOwo+ICsJCWNwdV9pZGxlX3BvbGxf Y3RybCh0cnVlKTsKPiArCX0KPiArCj4gKwlzY2hlZHVsZV9kZWxheWVkX3dvcmsoJmNoaXAtPnBv bGxfd29yaywgbXNlY3NfdG9famlmZmllcyg0MCkpOwo+ICt9CgpUaGlzIGlzIHZlcnkgb2RkLCBh bmQgbm90IGdvb2QuICBXaGF0IGFyZSB5b3UgdHJ5aW5nIHRvIGRvIGhlcmU/ICBBbmQKd2h5IGFy ZSB5b3UgdGhpbmtpbmcgdGhhdCBwb2xsX2NvdW50IHNob3VsZCBiZSBhbiBhdG9taWMgdmFyaWFi bGU/CgpUaGlzIGZlZWxzIHJlYWxseSBzdHJhbmdlLCBhbmQgbm90IHNvbWV0aGluZyB5b3Ugc2hv dWxkIGJlIGRvaW5nIGluIGFuCmlycSBoYW5kbGVyLCByaWdodD8KCnRoYW5rcywKCmdyZWcgay1o Ci0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJz Y3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZn ZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwu b3JnL21ham9yZG9tby1pbmZvLmh0bWwK