From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [RFC PATCH net-next 02/12] selftests: forwarding: Add a test for FDB learning Date: Thu, 18 Jan 2018 08:51:36 +0100 Message-ID: <20180118075136.GA2290@nanopsycho> References: <20180115191853.26129-1-idosch@mellanox.com> <20180115191853.26129-3-idosch@mellanox.com> <33d3f4a4-8b92-60da-3e1f-327effb7eda0@gmail.com> <20180117210137.GJ2114@nanopsycho> <20180117233124.GA26967@nanopsycho> <9e1bfed9-34a3-5810-230e-0bef75a43fb9@gmail.com> <20180118071654.GA5379@splinter> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Ahern , Roopa Prabhu , Ido Schimmel , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, David Miller , shuah@kernel.org, Nikolay Aleksandrov , Andy Gospodarek , Jiri Pirko , mlxsw , Saeed Mahameed , tariqt@mellanox.com, Jamal Hadi Salim , Lucas Bates , Florian Fainelli , Vivien Didelot , Andrew Lunn , jakub.kicinski@netronome.com, Simon Horman To: Ido Schimmel Return-path: Received: from mail-wm0-f45.google.com ([74.125.82.45]:38871 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753390AbeARHvj (ORCPT ); Thu, 18 Jan 2018 02:51:39 -0500 Received: by mail-wm0-f45.google.com with SMTP id 141so20640549wme.3 for ; Wed, 17 Jan 2018 23:51:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180118071654.GA5379@splinter> Sender: netdev-owner@vger.kernel.org List-ID: Thu, Jan 18, 2018 at 08:16:54AM CET, idosch@idosch.org wrote: >On Wed, Jan 17, 2018 at 04:15:04PM -0800, David Ahern wrote: >> How about the attached - make ping, ping6 and mz variables? Default to >> ping and mausezahn but let users update that name if necessary. Comments >> in the sample config to the effect need to be added to help users. > >Yes, looks good to me. Will include the change in the next version. Ido, please keep in mind that the script should run without the config file. So the defaults should be in lib.sh. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: jiri at resnulli.us (Jiri Pirko) Date: Thu, 18 Jan 2018 08:51:36 +0100 Subject: [Linux-kselftest-mirror] [RFC PATCH net-next 02/12] selftests: forwarding: Add a test for FDB learning In-Reply-To: <20180118071654.GA5379@splinter> References: <20180115191853.26129-1-idosch@mellanox.com> <20180115191853.26129-3-idosch@mellanox.com> <33d3f4a4-8b92-60da-3e1f-327effb7eda0@gmail.com> <20180117210137.GJ2114@nanopsycho> <20180117233124.GA26967@nanopsycho> <9e1bfed9-34a3-5810-230e-0bef75a43fb9@gmail.com> <20180118071654.GA5379@splinter> Message-ID: <20180118075136.GA2290@nanopsycho> Thu, Jan 18, 2018 at 08:16:54AM CET, idosch at idosch.org wrote: >On Wed, Jan 17, 2018 at 04:15:04PM -0800, David Ahern wrote: >> How about the attached - make ping, ping6 and mz variables? Default to >> ping and mausezahn but let users update that name if necessary. Comments >> in the sample config to the effect need to be added to help users. > >Yes, looks good to me. Will include the change in the next version. Ido, please keep in mind that the script should run without the config file. So the defaults should be in lib.sh. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: jiri@resnulli.us (Jiri Pirko) Date: Thu, 18 Jan 2018 08:51:36 +0100 Subject: [Linux-kselftest-mirror] [RFC PATCH net-next 02/12] selftests: forwarding: Add a test for FDB learning In-Reply-To: <20180118071654.GA5379@splinter> References: <20180115191853.26129-1-idosch@mellanox.com> <20180115191853.26129-3-idosch@mellanox.com> <33d3f4a4-8b92-60da-3e1f-327effb7eda0@gmail.com> <20180117210137.GJ2114@nanopsycho> <20180117233124.GA26967@nanopsycho> <9e1bfed9-34a3-5810-230e-0bef75a43fb9@gmail.com> <20180118071654.GA5379@splinter> Message-ID: <20180118075136.GA2290@nanopsycho> Content-Type: text/plain; charset="UTF-8" Message-ID: <20180118075136.UaFSokD-kpBiN21RzPpUdtBVaXZXwdMKgrQcUBev3Ec@z> Thu, Jan 18, 2018@08:16:54AM CET, idosch@idosch.org wrote: >On Wed, Jan 17, 2018@04:15:04PM -0800, David Ahern wrote: >> How about the attached - make ping, ping6 and mz variables? Default to >> ping and mausezahn but let users update that name if necessary. Comments >> in the sample config to the effect need to be added to help users. > >Yes, looks good to me. Will include the change in the next version. Ido, please keep in mind that the script should run without the config file. So the defaults should be in lib.sh. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html