From: Omar Sandoval <osandov@osandov.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, Jan Kara <jack@suse.cz>,
Eryu Guan <eguan@redhat.com>
Subject: Re: ext4 quota tests fail with CONFIG_QFMT_V2=n
Date: Thu, 18 Jan 2018 00:17:13 -0800 [thread overview]
Message-ID: <20180118081713.GB10877@vader> (raw)
In-Reply-To: <20180118040819.GI6948@thunk.org>
On Wed, Jan 17, 2018 at 11:08:19PM -0500, Theodore Ts'o wrote:
> On Wed, Jan 17, 2018 at 06:16:10PM -0800, Omar Sandoval wrote:
> > > I'd like to ask a different question, which is there a reason to
> > > support CONFIG_QFMT_V1 && !CONFIG_QFMT_V2? Maybe we should just
> > > always enable CONFIG_QFMT_V2, and simplify the test matrix?
> >
> > FWIW,
> >
> > # CONFIG_QFMT_V1 is not set
> > # CONFIG_QFMT_V2 is not set
> >
> > on this kernel.
>
> Huh.... I don't think that's a valid kernel configuration at all. Or
> rather, it's allowed by Kconfig, but it shouldn't be, since without
> any quota formats enabled, the quota code is completely useless, and
> you might as well not compile it in, as near as I can tell.
>
> Was this configuration one that you were deliberately using; and if
> so, what for? Or was it one that was created accidentally?
It's not intentional. I'm assuming what happened here is we disabled any
modules we weren't using, but CONFIG_QUOTA happened to stay on. Is it
also the case for XFS that quotas are useless without qfmt-v2?
> In any case, ext4's quota feature has to have the V2 quota format
> enabled, or it's not going to work properly. We should remove
> EXT4_FEATURE_RO_COMPAT_QUOTA from the list of supported features if
> CONFIG_QUOTA or CONFIG_QFMT_V2 are not set.
>
> - Ted
next prev parent reply other threads:[~2018-01-18 8:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 1:09 ext4 quota tests fail with CONFIG_QFMT_V2=n Omar Sandoval
2018-01-18 1:28 ` Theodore Ts'o
2018-01-18 2:16 ` Omar Sandoval
2018-01-18 4:08 ` Theodore Ts'o
2018-01-18 8:17 ` Omar Sandoval [this message]
2018-01-18 12:08 ` Jan Kara
2018-01-18 23:26 ` Dave Chinner
2018-01-18 12:21 ` Jan Kara
2018-01-18 16:03 ` Theodore Ts'o
2018-01-19 8:46 ` Jan Kara
2018-01-19 17:14 ` Theodore Ts'o
2018-01-24 10:44 ` Jan Kara
2018-01-18 18:07 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118081713.GB10877@vader \
--to=osandov@osandov.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.