From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754814AbeARIcx (ORCPT ); Thu, 18 Jan 2018 03:32:53 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:37237 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753541AbeARIcv (ORCPT ); Thu, 18 Jan 2018 03:32:51 -0500 X-Google-Smtp-Source: ACJfBovca+HvtAGMSHFvfsd/vgJterYfXH6OazFK+9bebpHz/kkJVOrcf8OR8YEjqn7gbvFcN45YGw== Date: Thu, 18 Jan 2018 08:32:47 +0000 From: Lee Jones To: Daniel Thompson Cc: Daniel Vetter , DRI Development , LKML , Jingoo Han , Meghana Madhyastha , Daniel Vetter Subject: Re: [PATCH 1/6] backlight: Nuke unused backlight.props.state states Message-ID: <20180118083247.2nwwguejmww5cb2x@dell> References: <20180117140159.27611-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Jan 2018, Daniel Thompson wrote: > On 17/01/18 14:01, Daniel Vetter wrote: > > The backlight power state handling is supremely confusing. We have: > > - props.power, using FB_BLANK_* defines > > - props.fb_blank, using the same, but deprecated int favour of > > props.state > > - props.state, using the BL_CORE_* defines > > - and finally a bunch of backlight drivers treat brightness == 0 as > > off. But of course not all of them. > > > > This is way too much confusion to fix in a simple patch, but at least > > prevent more hilarity from spreading by removing the unused BL_CORE_* > > defines. I have no idea why exactly anyone would need that. > > > > Wrt the ideal state, we really just want a boolean state. The 4 power > > saving states that the fbdev subsystem uses are overkill in todays hw > > (this was only relevant for VGA and similar analog circuits like > > TV-out), the new drm atomic modeset api simplified even the uapi to a > > simple bool. And there was never a valid technical reason to have the > > intermediate fbdev power states for backlights (those really only can > > be either off or on). > > > > Cleanup motivated by Meghana's questions about all this. > > > > Cc: Lee Jones > > Cc: Daniel Thompson > > Cc: Jingoo Han > > Cc: Meghana Madhyastha > > Signed-off-by: Daniel Vetter > > Acked-by: Daniel Thompson > > Daniel: Ack is info for Lee J, not to imply you should take it through > one of your trees. Right. I'd rather take the set as a complete unit once all Acks are acquired though. Hence my silence thus far. -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog