From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932511AbeARNln (ORCPT ); Thu, 18 Jan 2018 08:41:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:54024 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932487AbeARNll (ORCPT ); Thu, 18 Jan 2018 08:41:41 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B65020837 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Thu, 18 Jan 2018 10:41:39 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , namhyung@kernel.org, Adrian Hunter , Mike Leach , suzuki.poulosi@arm.com, Kim Phillips , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/10] perf tools: Integrating the CoreSight decoding library Message-ID: <20180118134139.GC18383@kernel.org> References: <1516039994-314-1-git-send-email-mathieu.poirier@linaro.org> <1516039994-314-2-git-send-email-mathieu.poirier@linaro.org> <20180116121500.GB26643@krava> <20180117080640.GD6183@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180117080640.GD6183@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jan 17, 2018 at 09:06:40AM +0100, Jiri Olsa escreveu: > On Tue, Jan 16, 2018 at 01:30:33PM -0700, Mathieu Poirier wrote: > > On 16 January 2018 at 05:15, Jiri Olsa wrote: > > > On Mon, Jan 15, 2018 at 11:13:05AM -0700, Mathieu Poirier wrote: > > >> +++ b/tools/build/Makefile.feature > > >> @@ -66,7 +66,8 @@ FEATURE_TESTS_BASIC := \ > > >> bpf \ > > >> sched_getcpu \ > > >> sdt \ > > >> - setns > > >> + setns \ > > >> + libopencsd > > >> > > >> # FEATURE_TESTS_BASIC + FEATURE_TESTS_EXTRA is the complete list > > >> # of all feature tests > > >> @@ -108,7 +109,8 @@ FEATURE_DISPLAY ?= \ > > >> zlib \ > > >> lzma \ > > >> get_cpuid \ > > >> - bpf > > >> + bpf \ > > >> + libopencsd > > > we put in this list only generic libraries, this one seems arch > > > specific please put it into FEATURE_TESTS_EXTRA list > > I was thinking that libopencsd should fall in the same category as > > libunwind-arm and libunwind-aarch64. Both are not architecture > > specific and used to process traces acquired on ARM platforms. As > > such I suggest to keep libopencsd as part of FEATURE_TESTS_BASIC and > > remove it from under FEATURE_DISPLAY - how does that sound to you? > ok, that sounds good Hi Jiri, Shouldn't libopencsd be treated like libbabeltrace was before the required version was widely available in distros? I.e. these csets should have the rationale for that: Enabling it once it became widely available: 24787afbcd01 ("perf tools: Enable LIBBABELTRACE by default") Disabling it because we would need to get things from tarballs/git repos, build it in our machines, as requested by Ingo: 6ab2b762befd ("perf build: Disable libbabeltrace check by default") - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 From: acme@kernel.org (Arnaldo Carvalho de Melo) Date: Thu, 18 Jan 2018 10:41:39 -0300 Subject: [PATCH v2 01/10] perf tools: Integrating the CoreSight decoding library In-Reply-To: <20180117080640.GD6183@krava> References: <1516039994-314-1-git-send-email-mathieu.poirier@linaro.org> <1516039994-314-2-git-send-email-mathieu.poirier@linaro.org> <20180116121500.GB26643@krava> <20180117080640.GD6183@krava> Message-ID: <20180118134139.GC18383@kernel.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Em Wed, Jan 17, 2018 at 09:06:40AM +0100, Jiri Olsa escreveu: > On Tue, Jan 16, 2018 at 01:30:33PM -0700, Mathieu Poirier wrote: > > On 16 January 2018 at 05:15, Jiri Olsa wrote: > > > On Mon, Jan 15, 2018 at 11:13:05AM -0700, Mathieu Poirier wrote: > > >> +++ b/tools/build/Makefile.feature > > >> @@ -66,7 +66,8 @@ FEATURE_TESTS_BASIC := \ > > >> bpf \ > > >> sched_getcpu \ > > >> sdt \ > > >> - setns > > >> + setns \ > > >> + libopencsd > > >> > > >> # FEATURE_TESTS_BASIC + FEATURE_TESTS_EXTRA is the complete list > > >> # of all feature tests > > >> @@ -108,7 +109,8 @@ FEATURE_DISPLAY ?= \ > > >> zlib \ > > >> lzma \ > > >> get_cpuid \ > > >> - bpf > > >> + bpf \ > > >> + libopencsd > > > we put in this list only generic libraries, this one seems arch > > > specific please put it into FEATURE_TESTS_EXTRA list > > I was thinking that libopencsd should fall in the same category as > > libunwind-arm and libunwind-aarch64. Both are not architecture > > specific and used to process traces acquired on ARM platforms. As > > such I suggest to keep libopencsd as part of FEATURE_TESTS_BASIC and > > remove it from under FEATURE_DISPLAY - how does that sound to you? > ok, that sounds good Hi Jiri, Shouldn't libopencsd be treated like libbabeltrace was before the required version was widely available in distros? I.e. these csets should have the rationale for that: Enabling it once it became widely available: 24787afbcd01 ("perf tools: Enable LIBBABELTRACE by default") Disabling it because we would need to get things from tarballs/git repos, build it in our machines, as requested by Ingo: 6ab2b762befd ("perf build: Disable libbabeltrace check by default") - Arnaldo