From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932448AbeAROO1 (ORCPT ); Thu, 18 Jan 2018 09:14:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:57392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932092AbeAROO0 (ORCPT ); Thu, 18 Jan 2018 09:14:26 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAED021742 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Thu, 18 Jan 2018 11:14:23 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , namhyung@kernel.org, Adrian Hunter , Mike Leach , suzuki.poulosi@arm.com, Kim Phillips , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/10] perf tools: Integrating the CoreSight decoding library Message-ID: <20180118141423.GE18383@kernel.org> References: <1516039994-314-1-git-send-email-mathieu.poirier@linaro.org> <1516039994-314-2-git-send-email-mathieu.poirier@linaro.org> <20180116121500.GB26643@krava> <20180117080640.GD6183@krava> <20180118134139.GC18383@kernel.org> <20180118135948.GA2940@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180118135948.GA2940@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Jan 18, 2018 at 02:59:48PM +0100, Jiri Olsa escreveu: > On Thu, Jan 18, 2018 at 10:41:39AM -0300, Arnaldo Carvalho de Melo wrote: > > Shouldn't libopencsd be treated like libbabeltrace was before > > the required version was widely available in distros? > > I.e. these csets should have the rationale for that: > > Enabling it once it became widely available: > > 24787afbcd01 ("perf tools: Enable LIBBABELTRACE by default") > > Disabling it because we would need to get things from tarballs/git > > repos, build it in our machines, as requested by Ingo: > > 6ab2b762befd ("perf build: Disable libbabeltrace check by default") > > I think at that time we did not have a way to hide the check, > now we have FEATURE_DISPLAY seprated so we can still check > for it, but users won't be bothered with [ FAIL ] output Ok, users won't be bothered with the fail output, but we tried hard to get the build fast by having it only test for things that are widely available, right? I.e. if we know something is not widely available then we better not try to build with it and get faster builds, wasn't that part of the rationale in the babeltrace case? If one has to build from sources some library, then its not a problem to have in the make command line a LIBOPENCSD=1 switch? - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 From: acme@kernel.org (Arnaldo Carvalho de Melo) Date: Thu, 18 Jan 2018 11:14:23 -0300 Subject: [PATCH v2 01/10] perf tools: Integrating the CoreSight decoding library In-Reply-To: <20180118135948.GA2940@krava> References: <1516039994-314-1-git-send-email-mathieu.poirier@linaro.org> <1516039994-314-2-git-send-email-mathieu.poirier@linaro.org> <20180116121500.GB26643@krava> <20180117080640.GD6183@krava> <20180118134139.GC18383@kernel.org> <20180118135948.GA2940@krava> Message-ID: <20180118141423.GE18383@kernel.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Em Thu, Jan 18, 2018 at 02:59:48PM +0100, Jiri Olsa escreveu: > On Thu, Jan 18, 2018 at 10:41:39AM -0300, Arnaldo Carvalho de Melo wrote: > > Shouldn't libopencsd be treated like libbabeltrace was before > > the required version was widely available in distros? > > I.e. these csets should have the rationale for that: > > Enabling it once it became widely available: > > 24787afbcd01 ("perf tools: Enable LIBBABELTRACE by default") > > Disabling it because we would need to get things from tarballs/git > > repos, build it in our machines, as requested by Ingo: > > 6ab2b762befd ("perf build: Disable libbabeltrace check by default") > > I think at that time we did not have a way to hide the check, > now we have FEATURE_DISPLAY seprated so we can still check > for it, but users won't be bothered with [ FAIL ] output Ok, users won't be bothered with the fail output, but we tried hard to get the build fast by having it only test for things that are widely available, right? I.e. if we know something is not widely available then we better not try to build with it and get faster builds, wasn't that part of the rationale in the babeltrace case? If one has to build from sources some library, then its not a problem to have in the make command line a LIBOPENCSD=1 switch? - Arnaldo