From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Thu, 18 Jan 2018 16:12:50 +0100 Subject: [U-Boot] [PATCH v2 06/15] env: fat: Make the debug messages play a little nicer In-Reply-To: References: <16d0c2060725654bb87a45e766b9752ef1d3b988.1516094113.git-series.maxime.ripard@free-electrons.com> Message-ID: <20180118151250.h3whxfhce3pfrgyf@flea.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jan 17, 2018 at 03:03:47PM -0700, Simon Glass wrote: > Hi Maxime, > > On 16 January 2018 at 01:16, Maxime Ripard > wrote: > > Since we have global messages to indicate what's going on, the custom > > messages in the environment drivers only make the output less readable. > > > > Make FAT play a little nicer by removing all the extra \n and formatting > > that is redundant with the global output. > > > > Reviewed-by: Andre Przywara > > Signed-off-by: Maxime Ripard > > --- > > env/fat.c | 25 ++++++++++++++++++++----- > > 1 file changed, 20 insertions(+), 5 deletions(-) > > Do you have a change log for this patch? Sorry, it was buried in my cover letter. You have the diff here: http://code.bulix.org/g3emu3-259575 tl; dr: I added some comments around the printf's to make it obvious that the missing \n were intentional. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: