From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932643AbeARQ2j (ORCPT ); Thu, 18 Jan 2018 11:28:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:55136 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754762AbeARQ2h (ORCPT ); Thu, 18 Jan 2018 11:28:37 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53D5321742 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Thu, 18 Jan 2018 13:28:35 -0300 From: Arnaldo Carvalho de Melo To: Mathieu Poirier Cc: jolsa@redhat.com, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] perf report: Fix regression when decoding intelPT traces Message-ID: <20180118162835.GG18383@kernel.org> References: <1515616312-27645-1-git-send-email-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515616312-27645-1-git-send-email-mathieu.poirier@linaro.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jan 10, 2018 at 01:31:52PM -0700, Mathieu Poirier escreveu: > Commit (93d10af26bb7 perf tools: Optimize sample parsing for ordered > events) breaks intelPT trace decoding by invariably returning an error if > the event type isn't a PERF_SAMPLE_TIME. Thanks, applied. > With this patch the timestamp is initialised and processing is allowed to > continue if the error returned by function > perf_evlist__parse_sample_timestamp() is not a fault. > > Signed-off-by: Mathieu Poirier > Acked-by: Jiri Olsa > --- > Changes for v4: > - Rebased to latest perf/core branch > - Added Jiri's ACK > --- > tools/perf/util/session.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c > index 54e30f1bcbd7..07221884f725 100644 > --- a/tools/perf/util/session.c > +++ b/tools/perf/util/session.c > @@ -1508,10 +1508,10 @@ static s64 perf_session__process_event(struct perf_session *session, > return perf_session__process_user_event(session, event, file_offset); > > if (tool->ordered_events) { > - u64 timestamp; > + u64 timestamp = -1ULL; > > ret = perf_evlist__parse_sample_timestamp(evlist, event, ×tamp); > - if (ret) > + if (ret && ret != -1) > return ret; > > ret = perf_session__queue_event(session, event, timestamp, file_offset); > -- > 2.7.4