From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
jolsa@redhat.com, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] perf report: Fix regression when decoding intelPT traces
Date: Thu, 18 Jan 2018 13:29:50 -0300 [thread overview]
Message-ID: <20180118162950.GH18383@kernel.org> (raw)
In-Reply-To: <1515616312-27645-1-git-send-email-mathieu.poirier@linaro.org>
Em Wed, Jan 10, 2018 at 01:31:52PM -0700, Mathieu Poirier escreveu:
> Commit (93d10af26bb7 perf tools: Optimize sample parsing for ordered
> events) breaks intelPT trace decoding by invariably returning an error if
> the event type isn't a PERF_SAMPLE_TIME.
Adrian, have you had the chance of looking at this?
I'm tentatively applying with Jiri's ack.
- Arnaldo
> With this patch the timestamp is initialised and processing is allowed to
> continue if the error returned by function
> perf_evlist__parse_sample_timestamp() is not a fault.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
> ---
> Changes for v4:
> - Rebased to latest perf/core branch
> - Added Jiri's ACK
> ---
> tools/perf/util/session.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 54e30f1bcbd7..07221884f725 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1508,10 +1508,10 @@ static s64 perf_session__process_event(struct perf_session *session,
> return perf_session__process_user_event(session, event, file_offset);
>
> if (tool->ordered_events) {
> - u64 timestamp;
> + u64 timestamp = -1ULL;
>
> ret = perf_evlist__parse_sample_timestamp(evlist, event, ×tamp);
> - if (ret)
> + if (ret && ret != -1)
> return ret;
>
> ret = perf_session__queue_event(session, event, timestamp, file_offset);
> --
> 2.7.4
next prev parent reply other threads:[~2018-01-18 16:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 20:31 [PATCH v4] perf report: Fix regression when decoding intelPT traces Mathieu Poirier
2018-01-18 16:28 ` Arnaldo Carvalho de Melo
2018-01-18 16:29 ` Arnaldo Carvalho de Melo [this message]
2018-01-19 7:12 ` Adrian Hunter
2018-01-24 11:22 ` [tip:perf/core] perf report: Fix regression when decoding intel_pt traces tip-bot for Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118162950.GH18383@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.