All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: tip-bot for Andi Kleen <tipbot@zytor.com>
Cc: linux-tip-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org, ak@linux.intel.com,
	dwmw@amazon.co.uk, mingo@kernel.org, hpa@zytor.com,
	tglx@linutronix.de
Subject: Re: [tip:x86/pti] module: Add retpoline tag to VERMAGIC
Date: Thu, 18 Jan 2018 11:02:55 -0600	[thread overview]
Message-ID: <20180118170255.wgcqrqiflikd3tmz@treble> (raw)
In-Reply-To: <tip-6cfb521ac0d5b97470883ff9b7facae264b7ab12@git.kernel.org>

On Wed, Jan 17, 2018 at 02:40:43AM -0800, tip-bot for Andi Kleen wrote:
> Commit-ID:  6cfb521ac0d5b97470883ff9b7facae264b7ab12
> Gitweb:     https://git.kernel.org/tip/6cfb521ac0d5b97470883ff9b7facae264b7ab12
> Author:     Andi Kleen <ak@linux.intel.com>
> AuthorDate: Tue, 16 Jan 2018 12:52:28 -0800
> Committer:  Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Wed, 17 Jan 2018 11:35:14 +0100
> 
> module: Add retpoline tag to VERMAGIC
> 
> Add a marker for retpoline to the module VERMAGIC. This catches the case
> when a non RETPOLINE compiled module gets loaded into a retpoline kernel,
> making it insecure.
> 
> It doesn't handle the case when retpoline has been runtime disabled.  Even
> in this case the match of the retcompile status will be enforced.  This
> implies that even with retpoline run time disabled all modules loaded need
> to be recompiled.

If the user overrides the vermagic and loads the module, shouldn't we
update the spectre_v2 sysfs vulnerability status and print a warning
like in v2?

-- 
Josh

  reply	other threads:[~2018-01-18 17:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16 20:52 [PATCH v3] retpoline: Add retpoline tag to VERMAGIC Andi Kleen
2018-01-16 21:24 ` Thomas Gleixner
2018-01-16 22:34   ` Andi Kleen
2018-01-17  7:38     ` Thomas Gleixner
2018-01-17  5:11 ` Greg KH
2018-01-17 10:40 ` [tip:x86/pti] module: " tip-bot for Andi Kleen
2018-01-18 17:02   ` Josh Poimboeuf [this message]
2018-01-18 17:39     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180118170255.wgcqrqiflikd3tmz@treble \
    --to=jpoimboe@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=dwmw@amazon.co.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tipbot@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.