From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755368AbeARSTG (ORCPT ); Thu, 18 Jan 2018 13:19:06 -0500 Received: from mail-bl2nam02on0076.outbound.protection.outlook.com ([104.47.38.76]:48441 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752368AbeARSTD (ORCPT ); Thu, 18 Jan 2018 13:19:03 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Vadim.Lomovtsev@cavium.com; Date: Thu, 18 Jan 2018 10:18:57 -0800 From: Vadim Lomovtsev To: sgoutham@cavium.com, rric@kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Vadim Lomovtsev , Dean Nelson Subject: Re: [PATCH v2] net: ethernet: cavium: Correct Cavium Thunderx nicvf/nicpf modules names Message-ID: <20180118181857.GA4207@localhost.localdomain> References: <1516290160-3396-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com> <1516290789-3585-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516290789-3585-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: CO2PR07CA0055.namprd07.prod.outlook.com (10.174.192.23) To CY4PR07MB2998.namprd07.prod.outlook.com (10.172.116.12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 493cf1b3-2733-4eeb-bab9-08d55e9ff35c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:CY4PR07MB2998; X-Microsoft-Exchange-Diagnostics: 1;CY4PR07MB2998;3:i66eaCxQowgDrHkGAS5mFvpPdpfUwcBg1yYTQ6ojBglSzQrIV5wMhnaxuz/Er9m/WdbeMGNiu8ebF0lWkxncCSsQtCqyG9zqZhC/tArVrYv6S9HItCbRj6JhD6CzxAM9xJwgNX18SdMwlWnBwMoD9pdFvLE16CylBSpDCzN7NOO8Fs8fI+HRxIco7J2UU5FfRMJnbY7llgXrrDU8gcpdJvcQsXv2Wk+y/9iQTgONGpX4a4bsYM4OAGAMq//HuWnK;25:XQ4uK/w2Wt2UXW2+AqPZtLgX4/K26xibwKvDKpE2QdvN0OHCx9L/DFGuZQGIrptmKpPPUPPWbbylDISOvfa07NXw/f8JV5oe3RvmOuT/Z6PWX8iFHfXLB7uwiIeGleoFl7PGIzMCQpVvNYoM6EUIr/vQvQgXwV9KNwoyaPK2/xyZ5ZlRrvHaonJ+fY5ZAH7eY6UM0tXrYl7K66WXE2H4QZ8NN37nSgtqGRs8EKp7bHFtCqVdgIQwsGxFyN66UxdX3XpXpnJWfZ2WgpQqMRGVma05SkppLCN4v4zEIpHWjHx7FV8mZYXKSJw0yy5d/WLvf9zq9js8HyKcqy/i52u5cA==;31:o6tRoRSUM15C6OhMYauN7MzIgcI65RhOwrIPnl7zyDJ8k/Ibw0gsvcLhlFceGo7vvzHPqQMNGqmzGr8XFBzo1d8n0Rk3SxLmdF82uNFE44fnk5MOCbPfALIW+atUjnZIiPtv2iAiDkqxj9ui1XzhsOvp9DfV32sY4xh0NpH//UlYGqvZfhA5gdNY38dDV8LOUDy/BC/ZFPVLxdyaIzlVCXs4eqgvhmTdDoVWYF7kM2o= X-MS-TrafficTypeDiagnostic: CY4PR07MB2998: X-Microsoft-Exchange-Diagnostics: 1;CY4PR07MB2998;20:zVtvQL6pnvl9xNSHS2+zXJ93qQP+Jfl48DJBxOtVBTDrXLQx5kBOWDjKRfwcROsWDguZCca+BsCKlMOGAByJMd5oe3XwIY8HQmf1qNp22viCtKcT/1CYNUmHkcbRhfQ3EDq6d5Dtk5V2cel77PBwUHXfonD7ztVJgrs3TvAfmocC6QyJGXxymsz2AIV3AFBy0oaEXipFxAj0KQC4pvro00xAnUG9ky6i3ySRj3u60kpoYF7giThlXsuyO6Nq+lyIjWoxrJ8M/QFKeN0dv4QNXDRjlX7OH4npybRKAvUvhiiQ9GZIaAplEtgTp9Ija4cu2fiWbUjc8Bi/RsOUR+gkCQe45tRluD4cNhAFPxY+MruMFO1BSzo6SQH31nq3O0bKakqmJgcqebRGOzguLsKH4m7RKo2JiY07GeTBaCh77Gv1KtlyX7JPoksghlNav8Xt7PfGFgKwGWNagSOipipfTMEXCKTmXFsldVl+qsFK2DwdIz2dBhGj3K3hqMfzyLhz9TxFdgKzkSAZLbJnIjmx5v/8RAG8uvFXjaI9NLcnm64Q3mLbxizWoMyMC5/o56cgiD+bDniG0sd2mzbaoNdbGEcNxx6Wi7GT7x/lWDSpa34=;4:fKrWeoXzWC1HSSoRAwFqwUrAa7TpGwL4hkR5Y6Qs8mS6V4pBpdf/2jx3KFP7SEYTtEJ5jwxKh94FEBqZHES26FOp6qjgvTt83s/T+kgblSKcOGBH1i7lLO7BgKeW+CU+Y0Fdmqumkc+Cc5wnpMVMZunumoFyZ2lJ6LDxJ1W5rQPrfW6f1ILtEBDuLDD84kK4/XSwORhxfj9CyyS0SAJZud7vbWNZBV/59ogkJ0nJRZv77pdj0CdkBHfI6FnM6wH53kj12DJh+PpNrBKns8XvgQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(10201501046)(93006095)(3231023)(2400065)(944501161)(3002001)(6041268)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:CY4PR07MB2998;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY4PR07MB2998; X-Forefront-PRVS: 05568D1FF7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6069001)(396003)(376002)(39860400002)(39380400002)(366004)(346002)(199004)(189003)(4326008)(59450400001)(8936002)(8676002)(7696005)(52116002)(25786009)(6246003)(72206003)(76176011)(33896004)(6506007)(386003)(42882006)(2950100002)(6666003)(97736004)(7736002)(478600001)(81166006)(68736007)(305945005)(5660300001)(81156014)(50466002)(105586002)(229853002)(106356001)(6116002)(3846002)(58126008)(54906003)(83506002)(33656002)(55016002)(9686003)(47776003)(61506002)(66066001)(53936002)(575784001)(26005)(16586007)(316002)(23726003)(16526018)(2906002)(1076002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR07MB2998;H:localhost.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY4PR07MB2998;23:fYxbXGJ+V6B4qqvzxJYI+Lu/dpYy3jyeZccqgu4Wl?= =?us-ascii?Q?Jr88hG3vdSuIEWszydolvIasxPHO8B2+BEWTwta8oIF9uqBFzIuFtTZ1kOW0?= =?us-ascii?Q?Pj66dSJQlfP6RXBEk5eBbuh7GNvUTJRUqyGPlRiq2D5VtwBgrAD1sHDALAge?= =?us-ascii?Q?VDztK/oUGvvcGw0kEUzAbg5XRTFzKlCS04//R9LB/vwyemwhEL0r8moP7NXC?= =?us-ascii?Q?4YCyprUFfU3s+LJmRXbRxGKItj4GU/JGxB9RpAPfYiK5V88bggGJAKCSwWqj?= =?us-ascii?Q?MPoI0bmqo/DDdGwFnvBrKo0+tUgbBWI239FA6BhjMbF+QXShidTRorjAfk3C?= =?us-ascii?Q?1gZAbWUajvJ8ZmTXznl4HbH3uGUrQzp+M/8URUj8RV4MPF4t3CDRMSnpaqh1?= =?us-ascii?Q?5PQXBcAOlJTIzqvoiBu8N1CkMFTscJGnezWmK42G305ajPtV6kbWQZZuNrS2?= =?us-ascii?Q?3evBDbKwwUmyq50tvNBA0NqDlK/WgG5aI+urZLZRgJm9KbsSZ0QrexEmlGnz?= =?us-ascii?Q?eHpX4k0gvT6WYshUM++oNaQk0J58JUZS1iJWxRjfIiwpB7VNwAlXHJU0r0ri?= =?us-ascii?Q?BnIai4AiITpEYZc4P6WnBd9+PrUw/NUrg2o1TQ6g0bjKlrUpVgvwMRFmF0nb?= =?us-ascii?Q?9ZLspRgEqSzjs9/8IbClvfsGbJpLGGxJrdDPJjuJaIcVKTZzIYeg4oRY/BCP?= =?us-ascii?Q?Ny7A/fRsv2az6PYZhZ14P4z6fplBhV1694KmQjy6JyHNzGIKxR/1jZHxVszy?= =?us-ascii?Q?Ss0CbwBKflvdd/Z8teDXsBZADrlRIYyRqwUybz+GgtgUab+7JBaPHtvWhJdO?= =?us-ascii?Q?Rx9D6cRzkHUSnKKjeVWQLa5XtZDyHGHk7fkED8JkmsS5tAfAbe0kb15TP7aP?= =?us-ascii?Q?MnaNglqfhMVTmCrExPWGWqucPT1Mo85x50tH5OGfXbC7dQN0F2BJLrEXWiVY?= =?us-ascii?Q?ebmW6p8w7Eb1ffURh7gxO9vZxon2wduVu/2TPdoNqfTcq+ctvuFPZDCKDe6j?= =?us-ascii?Q?K7zpxzN+GVtLw05R7jfWWFKeA7MwomLoRBuYP7LZFDsxRy+yC7EnE+r901aE?= =?us-ascii?Q?6qaJRwGzPxOhyv+3xcUEKMer7nSHA55GGnMBAedQSeu1WqdJs0bmtL+fX3PF?= =?us-ascii?Q?4vJvZTPmItX1QDBz2EqHPfYXlhoNcT4RBjLD/e1T6OucDEN5BkvMiV+RJ+M5?= =?us-ascii?Q?UrkdIwDTdu1ZQMx8LloOUbLTbHCSOzwiGK32rt2KywUvpL6XO4xhWQhsAFDt?= =?us-ascii?Q?h8wUN1E8ZpHEA1N8FoCBVin6OGQJX+FwDTt3//KUVhk2fEvUrw9tBJwFRBrk?= =?us-ascii?Q?dfBQQDev/VyB0KyGTcAkySfNA0BBL3iQmAAvD1eohXj?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR07MB2998;6:iq24ksb+GDmy5VPULt/T0obgZrrBnD0fgdQg7OUwgBuoZ4dA/X8Lp+dXvbvKbyTMS4kDHoosrW1ceB1fy7qXhbIbLpJzBIwO8oBs269k3g/QFKGxd2Nz+nzYNKVIKF9q8Pis8DuaKjEP4SZwECjCCUC7usELxiHqMIwoJ8/+5JWiefCoIkZwHZVOgyrIO4NhDEKmgBAGDpRXR+uqkNz81o/hFvn6TGtyMmMTWItiX3rlcn3jtKp45TdBCtBFfn9aQa0Ut+qsiyjp/EqYpU7OXVs0fcajGJoRYvVDXitnuQAjNAdVeKcNevdziTgjIuN+yFvO2vrLUrWy68xCRINz0vkdZB+B9hId6nWkkhAuv2g=;5:q3BSo3BmY4BGtdOs1ZpaZIuy/R3U6hQYCfOLb9OUvxN53/hA6xQtkimSCZiLawb3Cxv2/Dy91NXEe31PZmgTbG56nr9pJudJXcRvsxXfkqb1QBDSyXMIwA+3TUG3l/Ym9oKUhVVskPrny/D5FSl5ByyfVDwHmcRgyr6egP3SANE=;24:wLuxQtcR/3nzg2fDTkU+QC0V9Kn6ul5q/Pc/nH5vddP0vG1uCpCD4HzhaWgklPMtW9EjqfhhARbA3GrZOUovoAUIaAq+SwtUu8ue0zePtXk=;7:2IUrPeXxsW19W5tkP5b6rr9wGRxDE7g/kcDj0BbB9XdxonZdh+dYnun+oDN8pYr2E+3i8mCgHFV2pP6p0XwyaqwgQ3bEFXWNqsNY8rFifs11hsLaLeIBKNC9gaQ9A/bGXPbrJVBFySoydJRNKe92szFO9k8jPu3PohNqzc3XVQLUclxdfHIMj1K0Aq4fzd6ZE7CY/edlhBvG8FWWIKea+/SJuiYID6qtCqHQHH2/3WwHuxT28CFOZYRz1igCzPSI SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2018 18:19:01.4013 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 493cf1b3-2733-4eeb-bab9-08d55e9ff35c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB2998 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Self NACK here: modules names has to contain dashes instead of underscores, as it defined at sources (or update modules DRV_NAME definitions whithin the source files with underscores). Shame on me. Vadim On Thu, Jan 18, 2018 at 07:53:09AM -0800, Vadim Lomovtsev wrote: > From: Vadim Lomovtsev > > It was found that ethtool provides unexisting module name while > it queries the specified network device for associated driver > information. > > This patch is to correct Cavium CN88xx Thunder nicvf/nicpf modules > names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf'. > > Signed-off-by: Dean Nelson > Signed-off-by: Vadim Lomovtsev > --- > drivers/net/ethernet/cavium/thunder/Makefile | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/ethernet/cavium/thunder/Makefile b/drivers/net/ethernet/cavium/thunder/Makefile > index 6b4d4add7353..f5642337d0fe 100644 > --- a/drivers/net/ethernet/cavium/thunder/Makefile > +++ b/drivers/net/ethernet/cavium/thunder/Makefile > @@ -4,9 +4,9 @@ > > obj-$(CONFIG_THUNDER_NIC_RGX) += thunder_xcv.o > obj-$(CONFIG_THUNDER_NIC_BGX) += thunder_bgx.o > -obj-$(CONFIG_THUNDER_NIC_PF) += nicpf.o > -obj-$(CONFIG_THUNDER_NIC_VF) += nicvf.o > +obj-$(CONFIG_THUNDER_NIC_PF) += thunder_nicpf.o > +obj-$(CONFIG_THUNDER_NIC_VF) += thunder_nicvf.o > > -nicpf-y := nic_main.o > -nicvf-y := nicvf_main.o nicvf_queues.o > -nicvf-y += nicvf_ethtool.o > +thunder_nicpf-y := nic_main.o > +thunder_nicvf-y := nicvf_main.o nicvf_queues.o > +thunder_nicvf-y += nicvf_ethtool.o > -- > 2.14.3 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vadim.Lomovtsev@caviumnetworks.com (Vadim Lomovtsev) Date: Thu, 18 Jan 2018 10:18:57 -0800 Subject: [PATCH v2] net: ethernet: cavium: Correct Cavium Thunderx nicvf/nicpf modules names In-Reply-To: <1516290789-3585-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com> References: <1516290160-3396-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com> <1516290789-3585-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com> Message-ID: <20180118181857.GA4207@localhost.localdomain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Self NACK here: modules names has to contain dashes instead of underscores, as it defined at sources (or update modules DRV_NAME definitions whithin the source files with underscores). Shame on me. Vadim On Thu, Jan 18, 2018 at 07:53:09AM -0800, Vadim Lomovtsev wrote: > From: Vadim Lomovtsev > > It was found that ethtool provides unexisting module name while > it queries the specified network device for associated driver > information. > > This patch is to correct Cavium CN88xx Thunder nicvf/nicpf modules > names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf'. > > Signed-off-by: Dean Nelson > Signed-off-by: Vadim Lomovtsev > --- > drivers/net/ethernet/cavium/thunder/Makefile | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/ethernet/cavium/thunder/Makefile b/drivers/net/ethernet/cavium/thunder/Makefile > index 6b4d4add7353..f5642337d0fe 100644 > --- a/drivers/net/ethernet/cavium/thunder/Makefile > +++ b/drivers/net/ethernet/cavium/thunder/Makefile > @@ -4,9 +4,9 @@ > > obj-$(CONFIG_THUNDER_NIC_RGX) += thunder_xcv.o > obj-$(CONFIG_THUNDER_NIC_BGX) += thunder_bgx.o > -obj-$(CONFIG_THUNDER_NIC_PF) += nicpf.o > -obj-$(CONFIG_THUNDER_NIC_VF) += nicvf.o > +obj-$(CONFIG_THUNDER_NIC_PF) += thunder_nicpf.o > +obj-$(CONFIG_THUNDER_NIC_VF) += thunder_nicvf.o > > -nicpf-y := nic_main.o > -nicvf-y := nicvf_main.o nicvf_queues.o > -nicvf-y += nicvf_ethtool.o > +thunder_nicpf-y := nic_main.o > +thunder_nicvf-y := nicvf_main.o nicvf_queues.o > +thunder_nicvf-y += nicvf_ethtool.o > -- > 2.14.3 >