All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Al Viro <viro@ZenIV.linux.org.uk>
Subject: [PATCH 05/10] kill bond_ioctl()
Date: Thu, 18 Jan 2018 19:37:50 +0000	[thread overview]
Message-ID: <20180118193755.19997-5-viro@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180118193755.19997-1-viro@ZenIV.linux.org.uk>

From: Al Viro <viro@zeniv.linux.org.uk>

another sock_do_ioctl() equivalent

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 net/socket.c | 36 ++++--------------------------------
 1 file changed, 4 insertions(+), 32 deletions(-)

diff --git a/net/socket.c b/net/socket.c
index f280258bd6a4..b267d051b50d 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -2861,33 +2861,6 @@ static int compat_siocwandev(struct net *net, struct compat_ifreq __user *uifr32
 	return dev_ioctl(net, SIOCWANDEV, uifr);
 }
 
-static int bond_ioctl(struct net *net, unsigned int cmd,
-			 struct compat_ifreq __user *ifr32)
-{
-	struct ifreq kifr;
-	mm_segment_t old_fs;
-	int err;
-
-	switch (cmd) {
-	case SIOCBONDENSLAVE:
-	case SIOCBONDRELEASE:
-	case SIOCBONDSETHWADDR:
-	case SIOCBONDCHANGEACTIVE:
-		if (copy_from_user(&kifr, ifr32, sizeof(struct compat_ifreq)))
-			return -EFAULT;
-
-		old_fs = get_fs();
-		set_fs(KERNEL_DS);
-		err = dev_ioctl(net, cmd,
-				(struct ifreq __user __force *) &kifr);
-		set_fs(old_fs);
-
-		return err;
-	default:
-		return -ENOIOCTLCMD;
-	}
-}
-
 /* Handle ioctls that use ifreq::ifr_data and just need struct ifreq converted */
 static int compat_ifr_data_ioctl(struct net *net, unsigned int cmd,
 				 struct compat_ifreq __user *u_ifreq32)
@@ -3081,11 +3054,6 @@ static int compat_sock_ioctl_trans(struct file *file, struct socket *sock,
 	case SIOCGIFMAP:
 	case SIOCSIFMAP:
 		return compat_sioc_ifmap(net, cmd, argp);
-	case SIOCBONDENSLAVE:
-	case SIOCBONDRELEASE:
-	case SIOCBONDSETHWADDR:
-	case SIOCBONDCHANGEACTIVE:
-		return bond_ioctl(net, cmd, argp);
 	case SIOCADDRT:
 	case SIOCDELRT:
 		return routing_ioctl(net, sock, cmd, argp);
@@ -3149,6 +3117,10 @@ static int compat_sock_ioctl_trans(struct file *file, struct socket *sock,
 	case SIOCGARP:
 	case SIOCDARP:
 	case SIOCATMARK:
+	case SIOCBONDENSLAVE:
+	case SIOCBONDRELEASE:
+	case SIOCBONDSETHWADDR:
+	case SIOCBONDCHANGEACTIVE:
 		return sock_do_ioctl(net, sock, cmd, arg);
 	}
 
-- 
2.11.0

  parent reply	other threads:[~2018-01-18 19:40 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-13 18:17 [PATCH v3 0/9] core, x86: prevent bounds-check bypass via speculative execution Dan Williams
2018-01-13 18:17 ` [kernel-hardening] " Dan Williams
2018-01-13 18:17 ` [PATCH v3 1/9] Documentation: document array_ptr Dan Williams
2018-01-13 18:17   ` [kernel-hardening] " Dan Williams
2018-01-13 18:17 ` [PATCH v3 2/9] arm64: implement ifence_array_ptr() Dan Williams
2018-01-13 18:17   ` [kernel-hardening] " Dan Williams
2018-01-13 18:17 ` [PATCH v3 3/9] arm: " Dan Williams
2018-01-13 18:17   ` [kernel-hardening] " Dan Williams
2018-01-13 18:17 ` [PATCH v3 4/9] x86: implement ifence() Dan Williams
2018-01-13 18:17   ` [kernel-hardening] " Dan Williams
2018-01-13 18:17 ` [PATCH v3 5/9] x86: implement ifence_array_ptr() and array_ptr_mask() Dan Williams
2018-01-13 18:17   ` [kernel-hardening] " Dan Williams
2018-01-13 18:17 ` [PATCH v3 6/9] asm/nospec: mask speculative execution flows Dan Williams
2018-01-13 18:17   ` [kernel-hardening] " Dan Williams
2018-01-13 18:18 ` [PATCH v3 7/9] x86: introduce __uaccess_begin_nospec and ASM_IFENCE Dan Williams
2018-01-13 18:18   ` [kernel-hardening] " Dan Williams
2018-01-13 18:18 ` [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths Dan Williams
2018-01-13 18:18   ` [kernel-hardening] " Dan Williams
2018-01-13 19:05   ` Linus Torvalds
2018-01-13 19:05     ` [kernel-hardening] " Linus Torvalds
2018-01-13 19:33     ` Linus Torvalds
2018-01-13 19:33       ` [kernel-hardening] " Linus Torvalds
2018-01-13 20:22       ` Eric W. Biederman
2018-01-13 20:22         ` [kernel-hardening] " Eric W. Biederman
2018-01-13 20:22         ` Eric W. Biederman
2018-01-13 20:22         ` Eric W. Biederman
2018-01-16 22:23       ` Dan Williams
2018-01-16 22:23         ` [kernel-hardening] " Dan Williams
2018-01-16 22:23         ` Dan Williams
2018-01-16 22:23         ` Dan Williams
     [not found]         ` <CA+55aFxAFG5czVmCyhYMyHmXLNJ7pcXxWzusjZvLRh_qTGHj6Q@mail.gmail.com>
2018-01-16 22:41           ` Linus Torvalds
2018-01-16 22:41             ` [kernel-hardening] " Linus Torvalds
2018-01-17 14:17             ` Alan Cox
2018-01-17 14:17               ` [kernel-hardening] " Alan Cox
2018-01-17 18:52               ` Al Viro
2018-01-17 18:52                 ` [kernel-hardening] " Al Viro
2018-01-17 19:54                 ` Dan Williams
2018-01-17 19:54                   ` [kernel-hardening] " Dan Williams
2018-01-17 20:05                   ` Al Viro
2018-01-17 20:05                     ` [kernel-hardening] " Al Viro
2018-01-17 20:14                     ` Dan Williams
2018-01-17 20:14                       ` [kernel-hardening] " Dan Williams
2018-01-18  3:06                 ` [RFC][PATCH] get rid of the use of set_fs() (by way of kernel_recvmsg()) in sunrpc Al Viro
2018-01-18  3:06                   ` [kernel-hardening] " Al Viro
2018-01-18  3:16                   ` Linus Torvalds
2018-01-18  3:16                     ` [kernel-hardening] " Linus Torvalds
2018-01-18  4:43                     ` Al Viro
2018-01-18  4:43                       ` [kernel-hardening] " Al Viro
2018-01-18 16:29                       ` Christoph Hellwig
2018-01-18 16:29                         ` [kernel-hardening] " Christoph Hellwig
2018-01-18 17:10                         ` Al Viro
2018-01-18 17:10                           ` [kernel-hardening] " Al Viro
2018-01-18 19:31                       ` Al Viro
2018-01-18 19:31                         ` [kernel-hardening] " Al Viro
2018-01-18 19:37                         ` [PATCH 01/10] net: separate SIOCGIFCONF handling from dev_ioctl() Al Viro
2018-01-18 19:37                           ` [PATCH 02/10] devinet_ioctl(): take copyin/copyout to caller Al Viro
2018-01-22 16:40                             ` Christoph Hellwig
2018-01-18 19:37                           ` [PATCH 03/10] ip_rt_ioctl(): take copyin " Al Viro
2018-01-22 16:43                             ` Christoph Hellwig
2018-01-18 19:37                           ` [PATCH 04/10] kill dev_ifsioc() Al Viro
2018-01-22 16:47                             ` Christoph Hellwig
2018-01-18 19:37                           ` Al Viro [this message]
2018-01-22 16:48                             ` [PATCH 05/10] kill bond_ioctl() Christoph Hellwig
2018-01-18 19:37                           ` [PATCH 06/10] kill dev_ifname32() Al Viro
2018-01-18 19:37                           ` [PATCH 07/10] lift handling of SIOCIW... out of dev_ioctl() Al Viro
2018-01-18 19:37                           ` [PATCH 08/10] ipconfig: use dev_set_mtu() Al Viro
2018-01-18 19:37                           ` [PATCH 09/10] dev_ioctl(): move copyin/copyout to callers Al Viro
2018-01-18 19:37                           ` [PATCH 10/10] kill kernel_sock_ioctl() Al Viro
2018-01-22 16:49                             ` Christoph Hellwig
2018-01-24 20:52                             ` David Miller
2018-01-25  0:01                               ` Al Viro
2018-01-25  0:21                                 ` Al Viro
2018-01-25  4:11                                 ` David Miller
2018-01-22 16:40                           ` [PATCH 01/10] net: separate SIOCGIFCONF handling from dev_ioctl() Christoph Hellwig
2018-01-18 20:33                         ` [RFC][PATCH] get rid of the use of set_fs() (by way of kernel_recvmsg()) in sunrpc Al Viro
2018-01-18 20:33                           ` [kernel-hardening] " Al Viro
2018-01-19  3:27                         ` Al Viro
2018-01-19  3:27                           ` [kernel-hardening] " Al Viro
2018-01-17 19:26               ` [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths Linus Torvalds
2018-01-17 19:26                 ` [kernel-hardening] " Linus Torvalds
2018-01-17 20:01                 ` Eric Dumazet
2018-01-17 20:01                   ` [kernel-hardening] " Eric Dumazet
2018-01-18 16:38                 ` Christoph Hellwig
2018-01-18 16:38                   ` [kernel-hardening] " Christoph Hellwig
2018-01-18 16:49                   ` Linus Torvalds
2018-01-18 16:49                     ` [kernel-hardening] " Linus Torvalds
2018-01-18 18:12                     ` Al Viro
2018-01-18 18:12                       ` [kernel-hardening] " Al Viro
2018-01-17  4:30         ` Dan Williams
2018-01-17  4:30           ` [kernel-hardening] " Dan Williams
2018-01-17  6:28           ` Al Viro
2018-01-17  6:28             ` [kernel-hardening] " Al Viro
2018-01-17  6:50             ` Dan Williams
2018-01-17  6:50               ` [kernel-hardening] " Dan Williams
2018-01-17 10:07               ` David Laight
2018-01-17 10:07                 ` [kernel-hardening] " David Laight
2018-01-17 10:07                 ` David Laight
2018-01-17 18:12               ` Dan Williams
2018-01-17 18:12                 ` [kernel-hardening] " Dan Williams
2018-01-17 19:16           ` Linus Torvalds
2018-01-17 19:16             ` [kernel-hardening] " Linus Torvalds
2018-01-13 18:18 ` [PATCH v3 9/9] vfs, fdtable: prevent bounds-check bypass via speculative execution Dan Williams
2018-01-13 18:18   ` [kernel-hardening] " Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180118193755.19997-5-viro@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=davem@davemloft.net \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.