All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: David Hildenbrand <david@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	Cornelia Huck <cohuck@redhat.com>, KVM <kvm@vger.kernel.org>,
	linux-s390 <linux-s390@vger.kernel.org>,
	Janosch Frank <frankja@linux.vnet.ibm.com>,
	Michael Mueller <mimu@linux.vnet.ibm.com>
Subject: Re: [PATCH 02/12] KVM: s390: define GISA format-0 data structure
Date: Fri, 19 Jan 2018 11:20:39 +0100	[thread overview]
Message-ID: <20180119102038.GC4519@osiris> (raw)
In-Reply-To: <9f7484d1-6880-4000-ebad-b22611276810@redhat.com>

On Fri, Jan 19, 2018 at 11:17:10AM +0100, David Hildenbrand wrote:
> On 19.01.2018 11:12, Heiko Carstens wrote:
> > On Thu, Jan 18, 2018 at 09:47:01PM +0100, David Hildenbrand wrote:
> >> Two minor things
> >>
> >>>  
> >>> +struct kvm_s390_gisa {
> >>> +	u32 next_alert;
> >>> +	u8 ipm;
> >>> +	u8 reserved01;
> >>> +	u8:6;
> >>
> >> Mind giving this also a reserved name
> > 
> > And then all reserved fields have to be renamed as soon as one bit gets
> > used? Please don't...
> 
> Only if one keeps the order of the reserved field numbers ...

And that's what people usually do. Therefore having unnamed bitfields is
nice, since you don't have to care.

  reply	other threads:[~2018-01-19 10:20 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16 20:02 [PATCH 00/12] KVM: s390: exitless interrupt support for KVM Christian Borntraeger
2018-01-16 20:02 ` [PATCH 01/12] KVM: s390: reverse bit ordering of irqs in pending mask Christian Borntraeger
2018-01-16 20:18   ` David Hildenbrand
2018-01-17 10:12     ` Christian Borntraeger
2018-01-18 16:50   ` Cornelia Huck
2018-01-16 20:02 ` [PATCH 02/12] KVM: s390: define GISA format-0 data structure Christian Borntraeger
2018-01-16 20:25   ` David Hildenbrand
2018-01-17  7:57     ` Heiko Carstens
2018-01-18 15:49       ` Michael Mueller
2018-01-18 15:49         ` Michael Mueller
2018-01-18 20:47   ` David Hildenbrand
2018-01-19 10:12     ` Heiko Carstens
2018-01-19 10:17       ` David Hildenbrand
2018-01-19 10:20         ` Heiko Carstens [this message]
2018-01-19 10:29           ` Cornelia Huck
2018-01-19 11:28             ` David Hildenbrand
2018-01-16 20:02 ` [PATCH 03/12] s390/bitops: add test_and_clear_bit_inv() Christian Borntraeger
2018-01-16 20:13   ` David Hildenbrand
2018-01-18 16:54   ` Cornelia Huck
2018-01-16 20:02 ` [PATCH 04/12] KVM: s390: implement GISA IPM related primitives Christian Borntraeger
2018-01-17 14:35   ` David Hildenbrand
2018-01-18 14:29     ` Michael Mueller
2018-01-18 14:33       ` David Hildenbrand
2018-01-18 15:58         ` Michael Mueller
2018-01-18 20:45           ` David Hildenbrand
2018-01-19 10:11             ` Heiko Carstens
2018-01-19 10:16               ` David Hildenbrand
2018-01-19 10:17                 ` Christian Borntraeger
2018-01-16 20:02 ` [PATCH 05/12] s390/css: expose the AIV facility Christian Borntraeger
2018-01-17 15:19   ` David Hildenbrand
2018-01-18 12:02     ` Michael Mueller
2018-01-18 17:54       ` Cornelia Huck
2018-01-25 11:42         ` Christian Borntraeger
2018-01-25 12:00           ` Cornelia Huck
2018-01-25 12:04             ` Christian Borntraeger
2018-01-25 15:13               ` Heiko Carstens
2018-01-16 20:02 ` [PATCH 06/12] KVM: s390: exploit GISA and AIV for emulated interrupts Christian Borntraeger
2018-01-17  8:14   ` Heiko Carstens
2018-01-18 18:10   ` Cornelia Huck
2018-01-16 20:02 ` [PATCH 07/12] KVM: s390: abstract adapter interruption word generation from ISC Christian Borntraeger
2018-01-18 18:11   ` Cornelia Huck
2018-01-16 20:02 ` [PATCH 08/12] KVM: s390: add GISA interrupts to FLIC ioctl interface Christian Borntraeger
2018-01-16 20:02 ` [PATCH 09/12] KVM: s390: make kvm_s390_get_io_int() aware of GISA Christian Borntraeger
2018-01-16 20:02 ` [PATCH 10/12] KVM: s390: activate GISA for emulated interrupts Christian Borntraeger
2018-01-16 20:02 ` [PATCH 11/12] s390/sclp: expose the GISA format facility Christian Borntraeger
2018-01-16 20:13   ` David Hildenbrand
2018-01-16 20:02 ` [PATCH 12/12] KVM: s390: introduce the format-1 GISA Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180119102038.GC4519@osiris \
    --to=heiko.carstens@de.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mimu@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.