From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755936AbeASQE4 (ORCPT ); Fri, 19 Jan 2018 11:04:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:60070 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755744AbeASQEt (ORCPT ); Fri, 19 Jan 2018 11:04:49 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68FDE21719 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Fri, 19 Jan 2018 11:04:46 -0500 From: Steven Rostedt To: Ravi Bangoria Cc: mingo@redhat.com, oleg@redhat.com, srikar@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, namhyung@kernel.org Subject: Re: [PATCH] trace_uprobe: Display correct offset in uprobe_events Message-ID: <20180119110446.3d040c5f@gandalf.local.home> In-Reply-To: <20180106054246.15375-1-ravi.bangoria@linux.vnet.ibm.com> References: <20180106054246.15375-1-ravi.bangoria@linux.vnet.ibm.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 6 Jan 2018 11:12:46 +0530 Ravi Bangoria wrote: > Recently, how the pointers being printed with %p has been changed > by commit ad67b74d2469 ("printk: hash addresses printed with %p"). > This is causing a regression while showing offset in the > uprobe_events file. Instead of %p, use %px to display offset. > > Before patch: > > # perf probe -vv -x /tmp/a.out main > Opening /sys/kernel/debug/tracing//uprobe_events write=1 > Writing event: p:probe_a/main /tmp/a.out:0x58c > > # cat /sys/kernel/debug/tracing/uprobe_events > p:probe_a/main /tmp/a.out:0x0000000049a0f352 > > After patch: > > # cat /sys/kernel/debug/tracing/uprobe_events > p:probe_a/main /tmp/a.out:0x000000000000058c > Thanks, I'll pull this into my tree. -- Steve