From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756282AbeASTvX (ORCPT <rfc822;w@1wt.eu>);
        Fri, 19 Jan 2018 14:51:23 -0500
Received: from mail.kernel.org ([198.145.29.99]:57670 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755940AbeASTvS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 19 Jan 2018 14:51:18 -0500
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2A3A20C0F
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org
Date: Fri, 19 Jan 2018 14:51:15 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Pavan Kondeti <pkondeti@codeaurora.org>
Cc: williams@redhat.com, Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>, bristot@redhat.com,
        jkacur@redhat.com, efault@gmx.de, hpa@zytor.com,
        torvalds@linux-foundation.org, swood@redhat.com,
        linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] sched/rt: Simplify the IPI based RT balancing
 logic
Message-ID: <20180119145115.139e0784@gandalf.local.home>
In-Reply-To: <20180119185756.GC6563@codeaurora.org>
References: <20170424114732.1aac6dc4@gandalf.local.home>
        <tip-4bdced5c9a2922521e325896a7bbbf0132c94e56@git.kernel.org>
        <CAEU1=PkiHO35Dzna8EQqNSKW1fr1y1zRQ5y66X117MG06sQtNA@mail.gmail.com>
        <20180119100353.7f9f5154@gandalf.local.home>
        <20180119174617.GA6563@codeaurora.org>
        <20180119131121.22dac3d3@gandalf.local.home>
        <20180119131254.69a9d848@gandalf.local.home>
        <20180119185756.GC6563@codeaurora.org>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 20 Jan 2018 00:27:56 +0530
Pavan Kondeti <pkondeti@codeaurora.org> wrote:

> Hi Steve,
> 
> Thanks for the patch.
> 
> On Fri, Jan 19, 2018 at 01:12:54PM -0500, Steven Rostedt wrote:
> > On Fri, 19 Jan 2018 13:11:21 -0500
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >   
> > >  void rto_push_irq_work_func(struct irq_work *work)
> > >  {
> > > +	struct root_domain *rd =
> > > +		container_of(work, struct root_domain, rto_push_work);
> > >  	struct rq *rq;  
> > 
> > Notice that I also remove the dependency on rq from getting the rd.
> >   
> 
> Nice. This snippet it self solves the original problem, I reported.
> I will test your patch and let you know the results.
> 
>

I'll break the patch up into two then. One with this snippet, and the
other with the rd ref counting.

-- Steve