From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-7722-1516377776-2-10263836457452372182 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='net', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516377776; b=jPgigEB4hrjCvw/j1lYRLpUiXz0pOD5HqcOrBQXfeHNSsRJ YXTD0GhDmp8shmWBYc1JKJT5TSpPpwotP02tCrW2EsRdtoKi6EDCMke4sReXDOrw L9YnkHzleUBr9AhHoBrHl/FEl1aUq0IbwEIkWrIQnIEOVXljmPUJ66MUHso3vm7Z 1Ex+XDvn8Q7Ztru6EZLxPScPegNfiWgNltsqc6IVhU7kkrWPXsj4k1zlzINiQOpa DnClkPu8QENtCt9IgwALs7ErOF3duwxBtDYbLSgZgQIK+tpCeaxcOpkMOklJ6IHY Th65SqrElFchLAKhpZ21QP9+ofbmQxZv5RhtIkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1516377776; bh=4m/2H2naSC/mVKIwnH++A1ZLiL hX6FJIv+d/1J/yZfE=; b=cntyV4rkWg1te8fcyJgUssV+FFXJzt6+PpREU/FeMn Dr6WnFHh0tFJM30gDf2h4KD//ins6UeOUuxPc1Kdc0VN4vcTO2gW8nzBdPL1UsG/ XfFCwZXycX4DUpK2gDuORTDNmoFwd6hCugji1+W1u/Fmh7mPGGO0lvewOLASKvHu 3LXMO29xHksFXnRKV9JCUGNrWfBdoAUbr5CT3cEmyDcvNsdW6+vM84iSR5gOrOH+ mRJFBd/lVRqHjFobIZEzqexHjg8QecRgKoSH+kJ4BWKCTnnUoQBA/p9PL6HA9Ocz MsLULWNALs1xAZeq58vWAy94hTs6rdIcJ++Vd/Lj1hxg== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=qeZxthNp x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=roeck-us.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=p6rut6VZ; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=roeck-us.net header.result=pass header_is_org_domain=yes Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=qeZxthNp x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=roeck-us.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=p6rut6VZ; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=roeck-us.net header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756068AbeASQCl (ORCPT ); Fri, 19 Jan 2018 11:02:41 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:37727 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755940AbeASQCj (ORCPT ); Fri, 19 Jan 2018 11:02:39 -0500 X-Google-Smtp-Source: ACJfBoujnP30PRhMEendCFTR5IUIkIU47zH5dlrkpQyibR+SK7jiJJISe0QX4kgFF+qKlqgf4SaSwg== Date: Fri, 19 Jan 2018 08:02:35 -0800 From: Guenter Roeck To: Heikki Krogerus Cc: "shufan_lee(?????|)" , 'Jun Li' , ShuFanLee , "cy_huang(??????)" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver Message-ID: <20180119160235.GA21066@roeck-us.net> References: <1515567552-7692-1-git-send-email-leechu729@gmail.com> <20180119082218.GA22976@kuha.fi.intel.com> <25ced79e8ea84908bf6110a613ed81a2@ex1.rt.l> <20180119092413.GB22976@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180119092413.GB22976@kuha.fi.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, Jan 19, 2018 at 11:24:13AM +0200, Heikki Krogerus wrote: > Hi, > > On Fri, Jan 19, 2018 at 09:01:24AM +0000, shufan_lee(?????|) wrote: > > Hi Heikki, > > > > For example, the flow of tcpci_init is a little bit different. > > In tcpci_init, there are more parameters need to be set for RT1711H. > > Different init parameters is really not a reason for a fork of the > driver. The configuration of the TCPC will depend on the platform and > TCPC vendor most cases. > Agreed. dwc3 usb support is an excellent example on how to handle this kind of variation. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB TYPEC: RT1711H Type-C Chip Driver From: Guenter Roeck Message-Id: <20180119160235.GA21066@roeck-us.net> Date: Fri, 19 Jan 2018 08:02:35 -0800 To: Heikki Krogerus Cc: "shufan_lee\(?????|\)" , 'Jun Li' , ShuFanLee , "cy_huang\(??????\)" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" List-ID: T24gRnJpLCBKYW4gMTksIDIwMTggYXQgMTE6MjQ6MTNBTSArMDIwMCwgSGVpa2tpIEtyb2dlcnVz IHdyb3RlOgo+IEhpLAo+IAo+IE9uIEZyaSwgSmFuIDE5LCAyMDE4IGF0IDA5OjAxOjI0QU0gKzAw MDAsIHNodWZhbl9sZWUoPz8/Pz98KSB3cm90ZToKPiA+IEhpIEhlaWtraSwKPiA+IAo+ID4gICBG b3IgZXhhbXBsZSwgdGhlIGZsb3cgb2YgdGNwY2lfaW5pdCBpcyBhIGxpdHRsZSBiaXQgZGlmZmVy ZW50Lgo+ID4gICBJbiB0Y3BjaV9pbml0LCB0aGVyZSBhcmUgbW9yZSBwYXJhbWV0ZXJzIG5lZWQg dG8gYmUgc2V0IGZvciBSVDE3MTFILgo+IAo+IERpZmZlcmVudCBpbml0IHBhcmFtZXRlcnMgaXMg cmVhbGx5IG5vdCBhIHJlYXNvbiBmb3IgYSBmb3JrIG9mIHRoZQo+IGRyaXZlci4gVGhlIGNvbmZp Z3VyYXRpb24gb2YgdGhlIFRDUEMgd2lsbCBkZXBlbmQgb24gdGhlIHBsYXRmb3JtIGFuZAo+IFRD UEMgdmVuZG9yIG1vc3QgY2FzZXMuCj4gCkFncmVlZC4gZHdjMyB1c2Igc3VwcG9ydCBpcyBhbiBl eGNlbGxlbnQgZXhhbXBsZSBvbiBob3cgdG8gaGFuZGxlIHRoaXMKa2luZCBvZiB2YXJpYXRpb24u CgpHdWVudGVyCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGlu ZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFq b3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdl ci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK