From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH v3 2/4] drivers/net: add drivers for Cavium
 NICs to meson build
Date: Fri, 19 Jan 2018 22:59:28 +0530
Message-ID: <20180119172927.zkzi4d6nejsjrvro@Pavan-LT>
References: <20171231000203.4510-1-pbhagavatula@caviumnetworks.com>
 <20180119131204.7391-1-pbhagavatula@caviumnetworks.com>
 <20180119131204.7391-2-pbhagavatula@caviumnetworks.com>
 <20180119171630.GE16980@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>,
 jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0084.outbound.protection.outlook.com [104.47.32.84])
 by dpdk.org (Postfix) with ESMTP id 0E7A61B309
 for <dev@dpdk.org>; Fri, 19 Jan 2018 18:29:49 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20180119171630.GE16980@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jan 19, 2018 at 05:16:30PM +0000, Bruce Richardson wrote:
> On Fri, Jan 19, 2018 at 06:42:02PM +0530, Pavan Nikhilesh wrote:
> > Add Cavium octeontx and thunder nicvf to meson build infrastructure.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> >  drivers/net/meson.build                             |  3 ++-
> >  drivers/net/octeontx/base/meson.build               | 21 +++++++++++++++++++++
> >  drivers/net/octeontx/meson.build                    | 13 +++++++++++++
> >  drivers/net/thunderx/Makefile                       |  2 +-
> >  drivers/net/thunderx/base/meson.build               | 14 ++++++++++++++
> >  drivers/net/thunderx/meson.build                    | 14 ++++++++++++++
> >  ...cvf_version.map => rte_pmd_thunderx_version.map} |  0
> >  7 files changed, 65 insertions(+), 2 deletions(-)
> >  create mode 100644 drivers/net/octeontx/base/meson.build
> >  create mode 100644 drivers/net/octeontx/meson.build
> >  create mode 100644 drivers/net/thunderx/base/meson.build
> >  create mode 100644 drivers/net/thunderx/meson.build
> >  rename drivers/net/thunderx/{rte_pmd_thunderx_nicvf_version.map => rte_pmd_thunderx_version.map} (100%)
> >
> <snip>
> > diff --git a/drivers/net/thunderx/meson.build b/drivers/net/thunderx/meson.build
> > new file mode 100644
> > index 000000000..7333738de
> > --- /dev/null
> > +++ b/drivers/net/thunderx/meson.build
> > @@ -0,0 +1,14 @@
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright(c) 2017 Cavium, Inc
> > +
> > +subdir('base')
> > +objs = [base_objs]
> > +
> > +sources = files('nicvf_rxtx.c',
> > +		'nicvf_ethdev.c',
> > +		'nicvf_svf.c'
> > +	       )
> > +
> > +cflags += '-fno-prefetch-loop-arrays'
> > +
>
> This flag doesn't work with clang (at least with 5.0.0), so needs to
> be:
>
> 	if cc.has_argument('-fno-prefetch-loop-arrays')
> 	       cflags += '-fno-prefetch-loop-arrays'
> 	endif
>
> I'm also getting errors with gcc builds due to maybe-uninitialized
> variables, so I also had to add:
>
> 	if cc.has_argument('-Wno-maybe-uninitialized')
> 	       cflags += '-Wno-maybe-uninitialized'
> 	endif

Will send out v4 adressing these.

>
> Regards,
> /Bruce

Thanks,
Pavan