From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Eric Leblond <eric@regit.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next 0/4] libbpf: add XDP binding support
Date: Fri, 19 Jan 2018 18:27:55 -0800 [thread overview]
Message-ID: <20180120022753.psuzgzmxqaubh5t3@ast-mbp> (raw)
In-Reply-To: <2a008274-a09d-71ed-4c1e-5d7aa2bb8797@iogearbox.net>
On Sat, Jan 20, 2018 at 03:00:37AM +0100, Daniel Borkmann wrote:
> On 01/19/2018 12:43 AM, Eric Leblond wrote:
> > Hello,
> >
> > This patchset rebases the libbpf code on latest bpf-next code and addresses
> > remarks by Daniel.
>
> Ok, I think it's a good start. We should later on clean up the
> netlink handling code a bit, but that's all internal and can be
> done in a second step. Applied to bpf-next, thanks Eric.
Sorry, Eric, Daniel.
I had to revert this patch set. It breaks build on systems
where headers are not the most recent.
Since libbpf is used by perf it has to be built cleanly on centos7 at least.
The errors I got:
bpf.c: In function ‘bpf_set_link_xdp_fd’:
bpf.c:456:23: error: ‘SOL_NETLINK’ undeclared (first use in this function)
if (setsockopt(sock, SOL_NETLINK, NETLINK_EXT_ACK,
^~~~~~~~~~~
bpf.c:456:23: note: each undeclared identifier is reported only once for each function it appears in
bpf.c:456:36: error: ‘NETLINK_EXT_ACK’ undeclared (first use in this function)
if (setsockopt(sock, SOL_NETLINK, NETLINK_EXT_ACK,
^~~~~~~~~~~~~~~
nlattr.c: In function ‘nla_dump_errormsg’:
nlattr.c:152:34: error: ‘NLMSGERR_ATTR_MAX’ undeclared (first use in this function)
struct nla_policy extack_policy[NLMSGERR_ATTR_MAX + 1] = {
next prev parent reply other threads:[~2018-01-20 2:28 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 22:13 [PATCH bpf-next 0/3] add XDP loading support to libbpf Eric Leblond
2017-12-25 22:13 ` [PATCH bpf-next 1/3] libbpf: add function to setup XDP Eric Leblond
2017-12-25 22:13 ` [PATCH bpf-next 2/3] libbpf: add error reporting in XDP Eric Leblond
2017-12-27 2:27 ` Alexei Starovoitov
2017-12-27 18:02 ` [PATCH bpf-next v2 0/4] libbpf: add function to setup XDP Eric Leblond
2017-12-27 18:02 ` [PATCH 1/4] " Eric Leblond
2017-12-27 18:57 ` Alexei Starovoitov
2017-12-28 0:59 ` Toshiaki Makita
2017-12-27 18:02 ` [PATCH 2/4] libbpf: add error reporting in XDP Eric Leblond
2017-12-27 18:57 ` Alexei Starovoitov
2017-12-27 18:02 ` [PATCH 3/4] libbpf: break loop earlier Eric Leblond
2017-12-27 19:00 ` Alexei Starovoitov
2017-12-27 20:30 ` Eric Leblond
2017-12-27 23:05 ` Daniel Borkmann
2017-12-28 8:04 ` [PATCH bpf-next v3 0/3] libbpf: add XDP setup support Eric Leblond
2017-12-28 8:04 ` [PATCH bpf-next v3 1/3] libbpf: add function to setup XDP Eric Leblond
2017-12-28 8:18 ` Toshiaki Makita
2017-12-30 20:41 ` [PATCH bpf-next v4 0/3] " Eric Leblond
2017-12-30 20:41 ` [PATCH bpf-next v4 1/3] " Eric Leblond
2018-01-03 23:59 ` Eric Leblond
2018-01-04 8:21 ` [PATCH bpf-next v5 1/4] " Eric Leblond
2018-01-04 8:21 ` [PATCH bpf-next v5 2/4] libbpf: add error reporting in XDP Eric Leblond
2018-01-06 21:16 ` Daniel Borkmann
2018-01-18 23:35 ` Eric Leblond
2018-01-18 23:43 ` [PATCH bpf-next 0/4] libbpf: add XDP binding support Eric Leblond
2018-01-18 23:43 ` [PATCH bpf-next v6 1/4] libbpf: add function to setup XDP Eric Leblond
2018-01-18 23:43 ` [PATCH bpf-next v6 2/4] libbpf: add error reporting in XDP Eric Leblond
2018-01-18 23:43 ` [PATCH bpf-next v6 3/4] libbpf: add missing SPDX-License-Identifier Eric Leblond
2018-01-18 23:43 ` [PATCH bpf-next v6 4/4] samples/bpf: use bpf_set_link_xdp_fd Eric Leblond
2018-01-20 2:00 ` [PATCH bpf-next 0/4] libbpf: add XDP binding support Daniel Borkmann
2018-01-20 2:27 ` Alexei Starovoitov [this message]
2018-01-20 8:21 ` Daniel Borkmann
2018-01-25 0:05 ` [PATCH bpf-next v7 0/5] libbpf: add XDP setup support Eric Leblond
2018-01-25 0:05 ` [PATCH bpf-next v7 1/5] tools: import netlink header in tools uapi Eric Leblond
2018-01-25 0:05 ` [PATCH bpf-next v7 2/5] libbpf: add function to setup XDP Eric Leblond
2018-01-27 1:23 ` Daniel Borkmann
2018-01-27 10:22 ` Eric Leblond
2018-01-25 0:05 ` [PATCH bpf-next v7 3/5] libbpf: add error reporting in XDP Eric Leblond
2018-01-27 1:28 ` Daniel Borkmann
2018-01-27 10:32 ` Eric Leblond
2018-01-30 10:58 ` Daniel Borkmann
2018-01-30 20:50 ` [PATCH bpf-next v8 0/5] libbpf: add XDP binding support Eric Leblond
2018-01-31 16:53 ` Daniel Borkmann
2018-02-03 2:01 ` Alexei Starovoitov
2018-01-30 20:55 ` [PATCH bpf-next v8 1/5] tools: add netlink.h and if_link.h in tools uapi Eric Leblond
2018-01-30 20:55 ` [PATCH bpf-next v8 2/5] libbpf: add function to setup XDP Eric Leblond
2018-01-30 20:55 ` [PATCH bpf-next v8 3/5] libbpf: add error reporting in XDP Eric Leblond
2018-01-30 20:55 ` [PATCH bpf-next v8 4/5] libbpf: add missing SPDX-License-Identifier Eric Leblond
2018-01-30 20:55 ` [PATCH bpf-next v8 5/5] samples/bpf: use bpf_set_link_xdp_fd Eric Leblond
2018-01-25 0:05 ` [PATCH bpf-next v7 4/5] libbpf: add missing SPDX-License-Identifier Eric Leblond
2018-01-25 0:05 ` [PATCH bpf-next v7 5/5] samples/bpf: use bpf_set_link_xdp_fd Eric Leblond
2018-01-04 8:21 ` [PATCH bpf-next v5 3/4] libbpf: add missing SPDX-License-Identifier Eric Leblond
2018-01-04 9:49 ` Philippe Ombredanne
2018-01-04 8:21 ` [PATCH bpf-next v5 4/4] samples/bpf: use bpf_set_link_xdp_fd Eric Leblond
2017-12-30 20:41 ` [PATCH bpf-next v4 2/3] libbpf: add error reporting in XDP Eric Leblond
2017-12-31 11:20 ` Philippe Ombredanne
2017-12-30 20:41 ` [PATCH bpf-next v4 3/3] libbpf: add missing SPDX-License-Identifier Eric Leblond
2017-12-28 8:04 ` [PATCH bpf-next v3 2/3] libbpf: add error reporting in XDP Eric Leblond
2017-12-28 8:04 ` [PATCH bpf-next v3 3/3] libbpf: add missing SPDX-License-Identifier Eric Leblond
2017-12-29 12:35 ` Philippe Ombredanne
2017-12-27 18:02 ` [PATCH 4/4] " Eric Leblond
2017-12-27 19:01 ` Alexei Starovoitov
2017-12-25 22:13 ` [PATCH bpf-next 3/3] libbpf: break loop earlier Eric Leblond
[not found] <57ad1a20-4e41-474c-8829-d6a48c6b1883@email.android.com>
2018-01-22 14:00 ` [PATCH bpf-next 0/4] libbpf: add XDP binding support Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180120022753.psuzgzmxqaubh5t3@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=eric@regit.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.