From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v8 2/3] ring: introduce new header file to
 include common functions
Date: Mon, 22 Jan 2018 08:54:03 -0800
Message-ID: <20180122085403.4de6d399@xeon-e3>
References: <1516161831-28719-1-git-send-email-hejianet@gmail.com>
 <1516161831-28719-3-git-send-email-hejianet@gmail.com>
 <a779a7be-50ee-7d58-52d6-865b802bfff6@nxp.com>
 <20180119163820.lk6mi6mjxaomb5nq@platinum>
 <AM2PR04MB0753DC7A507FE7A967EE515689EF0@AM2PR04MB0753.eurprd04.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Olivier Matz <olivier.matz@6wind.com>, Jia He <hejianet@gmail.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Thomas Monjalon" <thomas@monjalon.net>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>, Jianbo Liu
 <jianbo.liu@arm.com>, Jan Viktorin <viktorin@rehivetech.com>,
 "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>, Jia He
 <jia.he@hxt-semitech.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66])
 by dpdk.org (Postfix) with ESMTP id 673A558C6
 for <dev@dpdk.org>; Mon, 22 Jan 2018 17:54:06 +0100 (CET)
Received: by mail-pg0-f66.google.com with SMTP id n17so7511049pgf.10
 for <dev@dpdk.org>; Mon, 22 Jan 2018 08:54:06 -0800 (PST)
In-Reply-To: <AM2PR04MB0753DC7A507FE7A967EE515689EF0@AM2PR04MB0753.eurprd04.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 19 Jan 2018 16:47:36 +0000
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:

> Hi Olivier,
> 
> > On Fri, Jan 19, 2018 at 07:45:30PM +0530, Hemant Agrawal wrote:  
> > > Hi Jia,
> > >
> > > On 1/17/2018 9:33 AM, Jia He wrote:  
> > > > Move the common part of rte_ring.h into rte_ring_generic.h.
> > > > Move the memory barrier part into update_tail().
> > > >
> > > > No functional changes here.
> > > >
> > > > Signed-off-by: Jia He <jia.he@hxt-semitech.com>
> > > > Suggested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > > Suggested-by: Ananyev Konstantin <konstantin.ananyev@intel.com>
> > > > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> > > > ---
> > > > diff --git a/lib/librte_ring/rte_ring_generic.h
> > > > b/lib/librte_ring/rte_ring_generic.h
> > > > new file mode 100644
> > > > index 0000000..01f2cae
> > > > --- /dev/null
> > > > +++ b/lib/librte_ring/rte_ring_generic.h
> > > > @@ -0,0 +1,202 @@
> > > > +/*-
> > > > + *   Copyright(c) 2017 Intel Corporation. All rights reserved.
> > > > + *   All rights reserved.
> > > > + *
> > > > + *   SPDX-License-Identifier: BSD-3-Clause  
> > >
> > > The SPDX should be first line. See other files for Intel or NXP.  
> 
> [Hemant] Don't add SPDX to this file. 
>  This file is not BSD-3 licensed.  Please keep the full text as in the original file.


If it can't be BSD-3 licensed, then it needs to be removed. Mixing licenses is a real problem