From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2 0/4] ip/tunnel: Minor cleanups and improvements Date: Tue, 23 Jan 2018 14:52:53 -0800 Message-ID: <20180123145253.56b3fe11@xeon-e3> References: <1516380243-32568-1-git-send-email-serhe.popovych@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Serhey Popovych Return-path: Received: from mail-pg0-f44.google.com ([74.125.83.44]:37367 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932323AbeAWWxE (ORCPT ); Tue, 23 Jan 2018 17:53:04 -0500 Received: by mail-pg0-f44.google.com with SMTP id z17so1318078pgc.4 for ; Tue, 23 Jan 2018 14:53:04 -0800 (PST) In-Reply-To: <1516380243-32568-1-git-send-email-serhe.popovych@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 19 Jan 2018 18:43:59 +0200 Serhey Popovych wrote: > It is small series of fixes and code cleanups: > > 1) Add space after encap-[ds]port parameter value > in tunnel encapsulation options output. > > 2) Unify ttl/hoplimit parsing routines by using > get_u8(), handling "inherit" and "hlim" as > alias to "hoplimit" and "ttl" parameter name. > > 3) Report when unable to resolve vti tunnel link > instead of silently quitting and use __u32 > for fwmark istead of unsigned int to match > with rest of tunneling code. > > 4) Use ll_name_to_index() instead of if_nametoindex() > to make ip(8) output and input parameter acceptance > coherent. > > See individual patch description message for details. > > Thanks, > Serhii > > Serhey Popovych (4): > tunnel: Add space between encap-dport and encap-sport in non-JSON > output > iptnl/ip6tnl: Unify ttl/hoplimit parsing routines > vti/vti6: Minor improvements > iplink: Use ll_name_to_index() instead of if_nametoindex() > > bridge/fdb.c | 4 ++-- > bridge/mdb.c | 2 +- > bridge/vlan.c | 2 +- > ip/iplink_bond.c | 4 ++-- > ip/iplink_bridge.c | 2 +- > ip/iplink_vxlan.c | 2 +- > ip/iproute_lwtunnel.c | 4 ++-- > ip/link_gre.c | 12 ++++-------- > ip/link_gre6.c | 15 ++++++++------- > ip/link_ip6tnl.c | 16 ++++++++-------- > ip/link_iptnl.c | 5 +++-- > ip/link_vti.c | 4 ++-- > ip/link_vti6.c | 8 +++++--- > ip/tunnel.c | 4 ++-- > 14 files changed, 42 insertions(+), 42 deletions(-) Looks good, applied.