From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:56893 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbeAWPm6 (ORCPT ); Tue, 23 Jan 2018 10:42:58 -0500 Date: Tue, 23 Jan 2018 16:40:45 +0100 From: David Sterba To: Nikolay Borisov Cc: linux-btrfs@vger.kernel.org, quwenruo.btrfs@gmx.com Subject: Re: [PATCH 0/7] Misc btrfs-progs cleanups/fixes Message-ID: <20180123154045.GM15713@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <1512463189-24724-1-git-send-email-nborisov@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Mon, Jan 15, 2018 at 11:17:33AM +0200, Nikolay Borisov wrote: > On 5.12.2017 10:39, Nikolay Borisov wrote: > > Here is a series doing some minor code cleanups, hopefully making the code > > more idiomatic and easier to follow. They should be pretty low-risk and > > introduce no functional changes (patches 1-5). > > > > The the last 2 patches deal with a regression of btrfs rescue super-recovery. > > Turns out this was broken for sometime. Patch 6 introduces a regression test > > which hopefully will prevent further occurences and patch 7 fixes the actual > > bug. > > > > Nikolay Borisov (7): > > btrfs-progs: Explictly state test.sh must be executable > > btrfs-progs: Factor out common print_device_info > > btrfs-progs: Remove recover_get_good_super > > btrfs-progs: Use list_for_each_entry in write_dev_all_supers > > btrfs-progs: Document logic of btrfs_read_dev_super > > btrfs-progs: Add test for super block recovery > > btrfs-progs: Fix super-recovery > > > > chunk-recover.c | 18 ------- > > disk-io.c | 21 ++++++-- > > super-recover.c | 28 ++--------- > > tests/README.md | 4 +- > > tests/fsck-tests/029-superblock-recovery/test.sh | 64 ++++++++++++++++++++++++ > > utils.c | 18 +++++++ > > utils.h | 3 ++ > > 7 files changed, 110 insertions(+), 46 deletions(-) > > create mode 100755 tests/fsck-tests/029-superblock-recovery/test.sh > > > Gentle ping since I'd like to get this into next btrfs-progs version, > especially the "fix super-recovery" patch. Series applied, thanks. I've swapped the order of test and fix as Qu pointed out and made some other minor fixups to the patches.