From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225x/HubAAOuR1+SHbq7VDPM9x5mKvLmRhje1T9+1oE7Uis0CFOFoc7Mmw1utRa/H8+P6RoM ARC-Seal: i=1; a=rsa-sha256; t=1516754621; cv=none; d=google.com; s=arc-20160816; b=nddf90BWjuIcnnnu+ENrPhLAXdUPY5RtDv865L4PHQC0sUU//9wDNB1GPzAjbBg75b TB6xvXs+LpXNkwiwlzopmqj0KLNhy15RKvcS0kKOygxZ7srR9mV/9wn3T7Ly7XkbbV6h ZT1HY248I2ZKEDdjJVSNtWvPugXAf4NWrvIt4eGaDxtGQk+6vBdoEkVSeSUCeZZe05VF up7uPNXNbIpl8t/XVTWG6QElEvIRutIiQR2LGbibH+kZfbB9vUWnCWFGaq2h6y3CXWaI KYC6+utKhjq6ahzsrjMExLwr30Y1PNaaIg0noPxI/73/U1TezbqSP6Jq8wNP6Bm15E1h yihg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:arc-authentication-results; bh=HQ86j0+MjvQmFsSfsOyWtfZYyX7EAQxBy2CGAUA/Llk=; b=JiF0sa5ryPu3imm1iomIlJGsCD48t+UxPVXvmePnCjS2VPYvZ2BabSqZACY/FC+N3Q WtE6G4vewVTJzKP+3+Xea2OMXABMRdgd+4mMuDrhZdO6pH8iTET7FDhFnBM5h1Pi4yz5 ibv8r+bdsDb8hC0xJqN7vJlw2MA8fqQyUDVVwqA8IklprZr1CMPImdc8JEG1hAWtCyoY VjNhtKaC5GNBhLSDAlHDFTXI9XF5IWZSJ7g8g5zSIwD1rTHcctFeJ7UdEUzyM5EE4zqd QRiGMhFYafjf2ExeVnYcLc2fAeC4cTs7/v4VaUxvk4IY7z3bGSNqv5xBQAAbj8mP0V0m lSvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gustavo@embeddedor.com designates 192.185.148.119 as permitted sender) smtp.mailfrom=gustavo@embeddedor.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of gustavo@embeddedor.com designates 192.185.148.119 as permitted sender) smtp.mailfrom=gustavo@embeddedor.com Date: Tue, 23 Jan 2018 18:43:40 -0600 From: "Gustavo A. R. Silva" To: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Arnd Bergmann Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR Message-ID: <20180124004340.GA25212@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - linuxfoundation.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.175.13.235 X-Source-L: No X-Exim-ID: 1ee9AC-00194r-RV X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.175.13.235]:37896 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590432494114663836?= X-GMAIL-MSGID: =?utf-8?q?1590432494114663836?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Fix inconsistent IS_ERR and PTR_ERR in vdic_get_ipu_resources. The proper pointer to be passed as argument is ch. This issue was detected with the help of Coccinelle. Fixes: 0b2e9e7947e7 ("media: staging/imx: remove confusing IS_ERR_OR_NULL usage") Signed-off-by: Gustavo A. R. Silva --- drivers/staging/media/imx/imx-media-vdic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/imx/imx-media-vdic.c b/drivers/staging/media/imx/imx-media-vdic.c index 433474d..ed35684 100644 --- a/drivers/staging/media/imx/imx-media-vdic.c +++ b/drivers/staging/media/imx/imx-media-vdic.c @@ -177,7 +177,7 @@ static int vdic_get_ipu_resources(struct vdic_priv *priv) priv->vdi_in_ch = ch; ch = ipu_idmac_get(priv->ipu, IPUV3_CHANNEL_MEM_VDI_NEXT); - if (IS_ERR(priv->vdi_in_ch_n)) { + if (IS_ERR(ch)) { err_chan = IPUV3_CHANNEL_MEM_VDI_NEXT; ret = PTR_ERR(ch); goto out_err_chan; -- 2.7.4