All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: Vinod Koul <vinod.koul@intel.com>,
	alsa-devel@alsa-project.org, lgirdwood@gmail.com,
	dan.carpenter@oracle.com, kuninori.morimoto.gx@renesas.com
Subject: Re: [PATCH 1/2] ASoC: compress: Correct handling of compressed ops
Date: Wed, 24 Jan 2018 17:14:40 +0000	[thread overview]
Message-ID: <20180124171440.fsep6atik37urv5m@localhost.localdomain> (raw)
In-Reply-To: <20180124160551.GH9366@sirena.org.uk>

On Wed, Jan 24, 2018 at 04:05:51PM +0000, Mark Brown wrote:
> On Wed, Jan 24, 2018 at 04:00:29PM +0000, Charles Keepax wrote:
> > On Wed, Jan 24, 2018 at 03:33:30PM +0000, Mark Brown wrote:
> 
> > > This doesn't apply against Linus' tree so that's not going to happen...
> 
> > Shall I split it into a crufty fix and then a tidy up?
> 
> Without seeing how awkward the crufty fix looks it's hard to say, use
> your judgement.

My feeling is still the same really that we should stick with this
patch even though its a bit more to put into stable, since really
the looping stuff is a bug as well.

But that said I will have a go at drafting up a separated patch,
see what it looks like and report back tomorrow.

Thanks,
Charles

  reply	other threads:[~2018-01-24 17:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24 13:55 [PATCH 1/2] ASoC: compress: Correct handling of compressed ops Charles Keepax
2018-01-24 13:55 ` [PATCH 2/2] ASoC: compress: Fixup some minor style issues Charles Keepax
2018-01-24 14:33   ` Ladislav Michl
2018-01-24 14:50     ` Charles Keepax
2018-01-24 14:29 ` [PATCH 1/2] ASoC: compress: Correct handling of compressed ops Vinod Koul
2018-01-24 14:49   ` Charles Keepax
2018-01-24 15:33     ` Mark Brown
2018-01-24 16:00       ` Charles Keepax
2018-01-24 16:05         ` Mark Brown
2018-01-24 17:14           ` Charles Keepax [this message]
2018-01-25 11:03             ` Charles Keepax
2018-01-25  1:18 ` Kuninori Morimoto
2018-01-25  9:47   ` Charles Keepax
2018-01-26  0:33     ` Kuninori Morimoto
2018-01-26 10:03       ` Charles Keepax
2018-01-26 11:48         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180124171440.fsep6atik37urv5m@localhost.localdomain \
    --to=ckeepax@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.