From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC/RFT,usb-next,v1,5/6] usb: chipidea: do not set the "phy" field in struct usb_hcd From: Martin Blumenstingl Message-Id: <20180125001639.14681-6-martin.blumenstingl@googlemail.com> Date: Thu, 25 Jan 2018 01:16:38 +0100 To: linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, chunfeng.yun@mediatek.com, matthias.bgg@gmail.com, linux@prisktech.co.nz, Peter.Chen@nxp.com Cc: mathias.nyman@intel.com, stern@rowland.harvard.edu, gregkh@linuxfoundation.org, Martin Blumenstingl List-ID: Tm93IHRoYXQgdXNiX2FkZF9oY2QgcGFyc2VzIGFsbCBnZW5lcmljIFBIWXMgYW55d2F5cyB0aGUg Y29kZSB3aGljaApza2lwcyBpbml0aWFsaXphdGlvbiBvZiBhIHNpbmdsZSBQSFkgd2lsbCBnbyBh d2F5LgpSZW1vdmUgdGhlIGNvZGUgd2hpY2ggc2V0cyBzdHJ1Y3QgdXNiX2hjZCdzIHBoeSBmaWVs ZCBmcm9tIHRoZSBjaGlwaWRlYQpkcml2ZXIgYXMgdGhpcyBmaWVsZCB3aWxsIGdvIGF3YXkgc29v bi4KClNpZ25lZC1vZmYtYnk6IE1hcnRpbiBCbHVtZW5zdGluZ2wgPG1hcnRpbi5ibHVtZW5zdGlu Z2xAZ29vZ2xlbWFpbC5jb20+Ci0tLQogZHJpdmVycy91c2IvY2hpcGlkZWEvaG9zdC5jIHwgNCAr LS0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvZHJpdmVycy91c2IvY2hpcGlkZWEvaG9zdC5jIGIvZHJpdmVycy91c2IvY2hpcGlk ZWEvaG9zdC5jCmluZGV4IDE5ZDYwZWQ3ZTQxZi4uZmMzMjQ3NjdjYjBmIDEwMDY0NAotLS0gYS9k cml2ZXJzL3VzYi9jaGlwaWRlYS9ob3N0LmMKKysrIGIvZHJpdmVycy91c2IvY2hpcGlkZWEvaG9z dC5jCkBAIC0xMjQsOSArMTI0LDcgQEAgc3RhdGljIGludCBob3N0X3N0YXJ0KHN0cnVjdCBjaV9o ZHJjICpjaSkKIAogCWhjZC0+cG93ZXJfYnVkZ2V0ID0gY2ktPnBsYXRkYXRhLT5wb3dlcl9idWRn ZXQ7CiAJaGNkLT50cGxfc3VwcG9ydCA9IGNpLT5wbGF0ZGF0YS0+dHBsX3N1cHBvcnQ7Ci0JaWYg KGNpLT5waHkpCi0JCWhjZC0+cGh5ID0gY2ktPnBoeTsKLQllbHNlCisJaWYgKCFjaS0+cGh5KQog CQloY2QtPnVzYl9waHkgPSBjaS0+dXNiX3BoeTsKIAogCWVoY2kgPSBoY2RfdG9fZWhjaShoY2Qp Owo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Blumenstingl Subject: [RFC/RFT usb-next v1 5/6] usb: chipidea: do not set the "phy" field in struct usb_hcd Date: Thu, 25 Jan 2018 01:16:38 +0100 Message-ID: <20180125001639.14681-6-martin.blumenstingl@googlemail.com> References: <20180125001639.14681-1-martin.blumenstingl@googlemail.com> Return-path: In-Reply-To: <20180125001639.14681-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org, Peter.Chen-3arQi8VN3Tc@public.gmane.org Cc: mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, Martin Blumenstingl List-Id: linux-mediatek@lists.infradead.org Now that usb_add_hcd parses all generic PHYs anyways the code which skips initialization of a single PHY will go away. Remove the code which sets struct usb_hcd's phy field from the chipidea driver as this field will go away soon. Signed-off-by: Martin Blumenstingl --- drivers/usb/chipidea/host.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c index 19d60ed7e41f..fc324767cb0f 100644 --- a/drivers/usb/chipidea/host.c +++ b/drivers/usb/chipidea/host.c @@ -124,9 +124,7 @@ static int host_start(struct ci_hdrc *ci) hcd->power_budget = ci->platdata->power_budget; hcd->tpl_support = ci->platdata->tpl_support; - if (ci->phy) - hcd->phy = ci->phy; - else + if (!ci->phy) hcd->usb_phy = ci->usb_phy; ehci = hcd_to_ehci(hcd); -- 2.16.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: martin.blumenstingl@googlemail.com (Martin Blumenstingl) Date: Thu, 25 Jan 2018 01:16:38 +0100 Subject: [RFC/RFT usb-next v1 5/6] usb: chipidea: do not set the "phy" field in struct usb_hcd In-Reply-To: <20180125001639.14681-1-martin.blumenstingl@googlemail.com> References: <20180125001639.14681-1-martin.blumenstingl@googlemail.com> Message-ID: <20180125001639.14681-6-martin.blumenstingl@googlemail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Now that usb_add_hcd parses all generic PHYs anyways the code which skips initialization of a single PHY will go away. Remove the code which sets struct usb_hcd's phy field from the chipidea driver as this field will go away soon. Signed-off-by: Martin Blumenstingl --- drivers/usb/chipidea/host.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c index 19d60ed7e41f..fc324767cb0f 100644 --- a/drivers/usb/chipidea/host.c +++ b/drivers/usb/chipidea/host.c @@ -124,9 +124,7 @@ static int host_start(struct ci_hdrc *ci) hcd->power_budget = ci->platdata->power_budget; hcd->tpl_support = ci->platdata->tpl_support; - if (ci->phy) - hcd->phy = ci->phy; - else + if (!ci->phy) hcd->usb_phy = ci->usb_phy; ehci = hcd_to_ehci(hcd); -- 2.16.1