From mboxrd@z Thu Jan  1 00:00:00 1970
From: Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH v2 net] netfilter: x_tables: avoid out-of-bounds reads in
 xt_request_find_{match|target}
Date: Thu, 25 Jan 2018 07:09:38 +0100
Message-ID: <20180125060938.GD14192@breakpoint.cc>
References: <1516834188.3715.35.camel@gmail.com>
 <20180124231952.GC14192@breakpoint.cc>
 <20180124235056.ahubcyqostttvtbx@salvia>
 <20180125001336.ilboagwlcpck54ip@salvia>
 <1516842969.3715.41.camel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
        Florian Westphal <fw@strlen.de>,
        netdev <netdev@vger.kernel.org>, netfilter-devel@vger.kernel.org
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:53768 "EHLO
        Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1750734AbeAYGMW (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 25 Jan 2018 01:12:22 -0500
Content-Disposition: inline
In-Reply-To: <1516842969.3715.41.camel@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> It looks like syzbot found its way into netfilter territory.
> 
> Issue here is that @name comes from user space and might
> not be null terminated.
> 
> Out-of-bound reads happen, KASAN is not happy.
> 
> v2 added similar fix for xt_request_find_target(),
> as Florian advised.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>

Thanks a lot Eric!

Acked-by: Florian Westphal <fw@strlen.de>