All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>
Subject: [Qemu-devel] [PULL 1/8] target/m68k: fix TCG variable double free
Date: Thu, 25 Jan 2018 16:15:28 +0100	[thread overview]
Message-ID: <20180125151535.25256-2-laurent@vivier.eu> (raw)
In-Reply-To: <20180125151535.25256-1-laurent@vivier.eu>

t64 is also unconditionally freed after the switch () { ... }

Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20180119114444.7590-1-laurent@vivier.eu>
---
 target/m68k/translate.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index f0e86a73d4..ea18df940a 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -969,7 +969,6 @@ static void gen_load_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp)
     case OS_DOUBLE:
         tcg_gen_qemu_ld64(t64, addr, index);
         gen_helper_extf64(cpu_env, fp, t64);
-        tcg_temp_free_i64(t64);
         break;
     case OS_EXTENDED:
         if (m68k_feature(s->env, M68K_FEATURE_CF_FPU)) {
-- 
2.14.3

  reply	other threads:[~2018-01-25 15:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25 15:15 [Qemu-devel] [PULL 0/8] M68k for 2.12 patches Laurent Vivier
2018-01-25 15:15 ` Laurent Vivier [this message]
2018-01-25 15:15 ` [Qemu-devel] [PULL 2/8] accel/tcg: add size paremeter in tlb_fill() Laurent Vivier
2018-01-25 15:15 ` [Qemu-devel] [PULL 3/8] target/m68k: add MC68040 MMU Laurent Vivier
2018-01-25 15:15 ` [Qemu-devel] [PULL 4/8] target/m68k: add Transparent Translation Laurent Vivier
2018-01-25 15:15 ` [Qemu-devel] [PULL 5/8] target/m68k: add index parameter to gen_load()/gen_store() and Co Laurent Vivier
2018-01-25 15:15 ` [Qemu-devel] [PULL 6/8] target/m68k: add moves Laurent Vivier
2018-01-25 15:15 ` [Qemu-devel] [PULL 7/8] target/m68k: add pflush/ptest Laurent Vivier
2018-01-25 15:15 ` [Qemu-devel] [PULL 8/8] target/m68k: add HMP command "info tlb" Laurent Vivier
2018-01-26 11:55 ` [Qemu-devel] [PULL 0/8] M68k for 2.12 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180125151535.25256-2-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.