From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bp@alien8.de>
X-Google-Smtp-Source: AH8x224WMaMKltH7oTaYY6ssbDbYmHGepPcsMn8pQ748e+pPmn0x12OzK6SfDokbx/8+Al+hvh+h
ARC-Seal: i=1; a=rsa-sha256; t=1516907455; cv=none;
        d=google.com; s=arc-20160816;
        b=rZXDTwyZO+Xx8OdKTXQVmkhXHFd2zvSGxFafNmJFL6Y1OP0huReV+QuTrl0RUCXcA/
         2y2r08zEVzAHMvqahsYG/6R+vYvgG/5PKOmf7DXebA7ilXDjud0sAlfXlnby6+mJJJL4
         GfTwPccviiI73Ag9czWLL5We0m2zKcDlJ+kf9kevUAm4tzdIE8uxurssfT4K0jNQ9k/0
         2OK3MromYAzkOC6GsxqIAMvAt5o2CFXn2DeNEzILmf28r0s5DF5iNFwMFdsFR0PeLeap
         0XjqtTO1q1eof7N858+QDAMTMUX9vT22i7DguduaGydhmZDtGjk0Pxq4ZF2kefIq3Nm+
         0Pmg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :message-id:subject:cc:to:from:date:arc-authentication-results;
        bh=dftr5PgdHSUK0J0yupwDjVVVg+cFmKoGLi5spFIe/9s=;
        b=G6ktKEgeijRX3ldRdyHW0zJSA7SP+Rd7dHpCG5Me0z4dIs2OH2St6nQ3mSOVmfehfk
         CFMAZQbchroKEEvhWk6jdNmjK4qkdtrDXSSFiamrlQW2yB0CYlaKPHbGOQZAQlZ993EH
         k5IJM/5p+aMpmNa95yWn2g4oSWn52Xe6+vISWjz8O3BRFK5ROpWid/WO1B9k4l/C4HGM
         /9SNiAyWdh4buFKuExPn4cEXtJf7dkuIaOxVns64VS/IndW1EbZD7FtV6ApLmb0DLFkf
         CXZ7n9tcgascEs0juAzKpbJSczYfeQT3FRnVSc0onMTk3z8BMLZ3LFqNrrMgp/sCQYc+
         SYtw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de
Date: Thu, 25 Jan 2018 20:10:46 +0100
From: Borislav Petkov <bp@alien8.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>, tim.c.chen@linux.intel.com,
	pjt@google.com, jikos@kernel.org, gregkh@linux-foundation.org,
	dave.hansen@intel.com, mingo@kernel.org, riel@redhat.com,
	luto@amacapital.net, torvalds@linux-foundation.org,
	ak@linux.intel.com, keescook@google.com, peterz@infradead.org,
	tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/pti] x86/retpoline: Fill return stack buffer on vmexit
Message-ID: <20180125191046.627z3fhbmm3myciu@pd.tnic>
References: <1516882849.30244.94.camel@infradead.org>
 <20180125124554.vdx7rrnfrxrzl2ng@pd.tnic>
 <20180125151024.bidjr26r667vs7h5@treble>
 <20180125155110.mw655b7fwgm7qqc7@pd.tnic>
 <1516896198.30244.133.camel@infradead.org>
 <20180125165646.ytc4upthpaqtwi45@treble>
 <1516899639.30244.145.camel@infradead.org>
 <20180125175334.7wlin4ftnqkq2fil@pd.tnic>
 <1516903463.30244.148.camel@infradead.org>
 <20180125190729.jxey2k44sptuk42t@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180125190729.jxey2k44sptuk42t@pd.tnic>
User-Agent: NeoMutt/20170609 (1.8.3)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1589334225298273984?=
X-GMAIL-MSGID: =?utf-8?q?1590592751618854725?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Thu, Jan 25, 2018 at 08:07:29PM +0100, Borislav Petkov wrote:
> static inline void vmexit_fill_RSB(void)
> {
> #ifdef CONFIG_RETPOLINE
>         alternative_input("", "call __fill_rsb_clobber_ax", X86_FEATURE_RETPOLINE, ASM_NO_INPUT_CLOBBER("memory"));

Whoops, forgot the clobbers:

        alternative_input("", "call __fill_rsb_clobber_ax", X86_FEATURE_RETPOLINE, ASM_NO_INPUT_CLOBBER(_ASM_AX, "memory"));

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.