From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bp@alien8.de>
X-Google-Smtp-Source: AH8x227itDPMDMvOyi1EGhfI2QSdcpsa4vyBSDe0MtsmWjBSnSbEsv2PgGWQmCref2F6+FJ3Jq3l
ARC-Seal: i=1; a=rsa-sha256; t=1516908720; cv=none;
        d=google.com; s=arc-20160816;
        b=liilXtLu8DtdroENV3aK6QY9egnma1NjXbToTych6obYaas07oKaoVjKNNNjySZkkb
         K+1etkJl50Tew4VZGprZRm74kGNsAv6vAyDB367DkVrcYq+6nHKXDUoJmtHjKN2eOdiL
         S2SLPerecbKuoL8dca0OwR1jjOV1DqOmktY5pHlcd/syccSNorVkOnsVeaPBMnImjEGc
         sH50el8Xa0dCHpMJuMrKkAYzuiH5y6k4Sn6ZmOhFjcahy9JIDz68fMvq+UZFaUExAz0q
         N4yDYBUH33QD6Kw/Auz1mMERtuEdQRaxMq3nVWAoutOiTjAvXvZACqz0PPwxmzGwifoI
         cSEg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :message-id:subject:cc:to:from:date:arc-authentication-results;
        bh=4YOU72gMyJL6Dz3r6h5/nOFbQYmRW8nfibbhyRJ3DxQ=;
        b=OZCviCMBCpJmRZQVJEClfey98DZoY4uXDKwGES4i2fO7fd1eBOU7eB/OOzRDALlE5Y
         teeVkdeck8L4D7rfwTQf/5DYQRF/tIdBNPT0mJzEeuwI6rkNrG9bvmF7yMwN3Pf4qUiA
         2R5b8LyRCrLwOq4ASFyAFPdQTLYkusx0SdP7xsS4ZJhisFq7WZCHswhbh8Dd2BLVvBUI
         QYvXqBe5hkZFTn0IJsYrdkY+n8fYF5hi8SaSsxBAtlSAub0CBlOMGWmsyq7PyiQmuofW
         zAKlRVFkdTkRJ8r5lMgIFCXTnSlKb4Pf+W+CeG90IWhW8JfTHc++XkqSj/Etw1GFY0KZ
         JOkQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of bp@alien8.de designates 2a01:4f8:190:11c2::b:1457 as permitted sender) smtp.mailfrom=bp@alien8.de
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of bp@alien8.de designates 2a01:4f8:190:11c2::b:1457 as permitted sender) smtp.mailfrom=bp@alien8.de
Date: Thu, 25 Jan 2018 20:31:49 +0100
From: Borislav Petkov <bp@alien8.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Josh Poimboeuf <jpoimboe@redhat.com>, linux-kernel@vger.kernel.org,
	Dave Hansen <dave.hansen@intel.com>,
	Ashok Raj <ashok.raj@intel.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Andi Kleen <ak@linux.intel.com>,
	Arjan Van De Ven <arjan.van.de.ven@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Asit Mallick <asit.k.mallick@intel.com>,
	Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH 12/24] x86: Update _static_cpu_has to use all named
 variables
Message-ID: <20180125193149.vkjyqmcfq5ooto2z@pd.tnic>
References: <20180123152539.374360046@infradead.org>
 <20180123152638.700221673@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180123152638.700221673@infradead.org>
User-Agent: NeoMutt/20170609 (1.8.3)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1590397857451078097?=
X-GMAIL-MSGID: =?utf-8?q?1590594078642050128?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Tue, Jan 23, 2018 at 04:25:51PM +0100, Peter Zijlstra wrote:
> 
> Requested-by: Josh Poimboeuf <jpoimboe@redhat.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
>  arch/x86/include/asm/cpufeature.h |    9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> --- a/arch/x86/include/asm/cpufeature.h
> +++ b/arch/x86/include/asm/cpufeature.h
> @@ -153,7 +153,7 @@ static __always_inline __pure bool _stat
>  		 ".section .altinstructions,\"a\"\n"
>  		 " .long 1b - .\n"		/* src offset */
>  		 " .long 4f - .\n"		/* repl offset */
> -		 " .word %P1\n"			/* always replace */
> +		 " .word %P[always]\n"		/* always replace */
>  		 " .byte 3b - 1b\n"		/* src len */
>  		 " .byte 5f - 4f\n"		/* repl len */
>  		 " .byte 3b - 2b\n"		/* pad len */
> @@ -165,7 +165,7 @@ static __always_inline __pure bool _stat
>  		 ".section .altinstructions,\"a\"\n"
>  		 " .long 1b - .\n"		/* src offset */
>  		 " .long 0\n"			/* no replacement */
> -		 " .word %P0\n"			/* feature bit */
> +		 " .word %P[feature]\n"		/* feature bit */
>  		 " .byte 3b - 1b\n"		/* src len */
>  		 " .byte 0\n"			/* repl len */
>  		 " .byte 0\n"			/* pad len */
> @@ -176,8 +176,9 @@ static __always_inline __pure bool _stat
>  		 " jnz %l[t_yes]\n"
>  		 " jmp %l[t_no]\n"
>  		 ".previous\n"
> -		 : : "i" (bit), "i" (X86_FEATURE_ALWAYS),
> -		     [bitnum] "i" (1 << (bit & 7)),
> +		 : : [feature]  "i" (bit),
> +		     [always]   "i" (X86_FEATURE_ALWAYS),
> +		     [bitnum]   "i" (1 << (bit & 7)),
>  		     [cap_byte] "m" (((const char *)boot_cpu_data.x86_capability)[bit >> 3])
>  		 : : t_yes, t_no);
>  t_yes:

Reviewed-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.