From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751736AbeA2KdZ (ORCPT ); Mon, 29 Jan 2018 05:33:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:59186 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbeA2KdX (ORCPT ); Mon, 29 Jan 2018 05:33:23 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E308E20C48 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 29 Jan 2018 11:33:20 +0100 From: Arnaldo Carvalho de Melo To: Ravi Bangoria Cc: alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, linux-kernel@vger.kernel.org, brueckner@linux.vnet.ibm.com, tmricht@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au Subject: Re: [PATCH 3/3] perf trace powerpc: Use generated syscall table Message-ID: <20180129103320.GA9986@kernel.org> References: <20180129083417.31240-1-ravi.bangoria@linux.vnet.ibm.com> <20180129083417.31240-4-ravi.bangoria@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180129083417.31240-4-ravi.bangoria@linux.vnet.ibm.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jan 29, 2018 at 02:04:17PM +0530, Ravi Bangoria escreveu: > +++ b/tools/perf/util/syscalltbl.c > @@ -30,6 +30,10 @@ > #include > const int syscalltbl_native_max_id = SYSCALLTBL_S390_64_MAX_ID; > static const char **syscalltbl_native = syscalltbl_s390_64; > +#elif defined(__powerpc64__) > +#include > +const int syscalltbl_native_max_id = SYSCALLTBL_POWERPC_64_MAX_ID; > +static const char **syscalltbl_native = syscalltbl_powerpc_64; > #endif This is so cool! Thanks! At some point we'll remove these #elif, have all of then linked, so that we can do cross-platform interpreting of perf.data files generated with 'perf trace record', i.e. 'perf trace -i perf.data.recorded.on.s390' on a powerpc64 or x86 machine. We're paving the way to that with patches like yours and those for s/390, thanks again! - Arnaldo