From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3114829-1517230765-2-1881407707915722190 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517230764; b=Z7Y1u2WSavzo0L1YycUGGEHPBCMlXvarKhqzL3MJekcyHDS Rfa35id4+9ToMyH8MeTrhu0mXzcgQaT9KxvsmRUAK6g7G7nRltCsXVxtPqBqAFcM wWcnoKMMMyWFP8pZxtwMp+NGFMFry+gmfjxXD+0cyXbvwsFRpDAy5HONwYHgCjbp 5eQTqmZYXkZ30Zgl5jwqbuC0UTODm+x140xL95odsxUxW5AFJilA6DvjXQnYxoYj WIr/uNTD/BBjTOg2k2i4wE+M9RHwKOj7z9GN+63cgN4afzz49VG6yB8ROAN/b2RQ 5Ms+GBNHrq8goF4mHJNZzG6XpDbC+bUWuM+XoIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-type:sender :list-id; s=arctest; t=1517230764; bh=eXVIiT2WEXtoh7zYHXHrHIz/dZ FFDzW1ng5P+5ATPMg=; b=HvaWPeZIBVqQFjNDHwj4G8Jn+yNJeFajpoZksI78vW Km3+enxZwA8MQpovJD8QSn+SG2TJZDMs+qqoLZjaDC8UWq/lSoO6OV4ez3n//lmA ZwPvlt37wl2ViPyOMjXqAQJ8IAtW/+hQra7Rm5oJV/8RSRlGF+tGfUJUU/B4UKRZ 6OagRwlKi+X2F5yAlfxQSiOJOxkNI3hLsJi37AQsp5uMBlu71MteU1jcgeZ+KqEp cbvynxmnzo+d/hf7zJkvD4YRSvO+VAhVVY+gV+0GcCyjaRL1FsrxGtbjVN/8DzfA yFgCSJLEDV7EvPf/+YbMnlleY+7THDCWhaL9XlTMl+cA== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751387AbeA2M7X (ORCPT ); Mon, 29 Jan 2018 07:59:23 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:41986 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbeA2M7W (ORCPT ); Mon, 29 Jan 2018 07:59:22 -0500 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jeff Mahoney , Jan Kara Subject: [PATCH 3.18 33/52] reiserfs: dont preallocate blocks for extended attributes Date: Mon, 29 Jan 2018 13:56:51 +0100 Message-Id: <20180129123629.642103647@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123628.168904217@linuxfoundation.org> References: <20180129123628.168904217@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jeff Mahoney commit 54930dfeb46e978b447af0fb8ab4e181c1bf9d7a upstream. Most extended attributes will fit in a single block. More importantly, we drop the reference to the inode while holding the transaction open so the preallocated blocks aren't released. As a result, the inode may be evicted before it's removed from the transaction's prealloc list which can cause memory corruption. Signed-off-by: Jeff Mahoney Signed-off-by: Jan Kara Signed-off-by: Greg Kroah-Hartman --- fs/reiserfs/bitmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/reiserfs/bitmap.c +++ b/fs/reiserfs/bitmap.c @@ -1136,7 +1136,7 @@ static int determine_prealloc_size(reise hint->prealloc_size = 0; if (!hint->formatted_node && hint->preallocate) { - if (S_ISREG(hint->inode->i_mode) + if (S_ISREG(hint->inode->i_mode) && !IS_PRIVATE(hint->inode) && hint->inode->i_size >= REISERFS_SB(hint->th->t_super)->s_alloc_options. preallocmin * hint->inode->i_sb->s_blocksize)