From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227yQltnBbVtVerMtKZ4FQ/fJBxTs7tWfsUqHbrLopLl/23FxaopPWylQVZuAE2wvpLwRYp3 ARC-Seal: i=1; a=rsa-sha256; t=1517256307; cv=none; d=google.com; s=arc-20160816; b=M4L9RSgJI5xcj8+qQm4rWNBGYleq1GElIyDhHssveia8l1FCpBEWt+RwVB9IXoaSYP Hd4Qgp0D9guiHZ8YZg8GDSPHviuiQOiKnW/zrAoxOrqrFPe/Eq5TDByAlgX2Z7oZ+lgi iJ2EGycefR1/KpL7VdcXrv/UFI+LsHSROjFvmeCF2KsC6NZfzM+bFfJFOCg7T21SsBWt cT16tuZFnjGm0H680x+mkmIfLISx+iqGD9JezU2uYxU/qzTfeRRU0ni43p8rHU63s4dM +El4J/3DYdSl9fI2hLehSDVa4mhbaKUWCRtYMhxN18hclQzWla4WflQt+wDK0lfhfyv4 32uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=ixo8LmnYYf1ys0VfSpsn8aYqqkj/UDIYFx5SuSYHqvA=; b=uhUzDxeOLDZMnBYHZ5Y/R8CUSnKwW3CPB4NkOveAfWVqq+yxsH2K2pOFnIUrww5IbR D1zGlf9roP6Dy4GB8KPMDYPiMKuu4QQ8e3kyz8vYJMspDVftOqELEBBfrVDfrXH7C6Dz Up12/lxXAw5CQ77AwZhL9SLrw8+O9yqPiXDb7xianVFueEP1BBqpOtzWIU7C9YOy2TV7 1ONsJ6eURDNjIl4NQiQO1MJcEtg33JTbwZgkol8hErr+77SlDiwGhfaOKdl4Ra1Cf26T A70q35ZEWzgOAkwhegtZ6ELIhMoAARShcQJ7B5t4J1yxkDHrKhoJ+YC4l5Gv2V+z+Rp6 wPTg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , syzbot , "David S. Miller" Subject: [PATCH 4.14 28/71] ipv6: ip6_make_skb() needs to clear cork.base.dst Date: Mon, 29 Jan 2018 13:56:56 +0100 Message-Id: <20180129123829.151411559@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123827.271171825@linuxfoundation.org> References: <20180129123827.271171825@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590958581264208744?= X-GMAIL-MSGID: =?utf-8?q?1590958549126588917?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit 95ef498d977bf44ac094778fd448b98af158a3e6 ] In my last patch, I missed fact that cork.base.dst was not initialized in ip6_make_skb() : If ip6_setup_cork() returns an error, we might attempt a dst_release() on some random pointer. Fixes: 862c03ee1deb ("ipv6: fix possible mem leaks in ipv6_make_skb()") Signed-off-by: Eric Dumazet Reported-by: syzbot Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv6/ip6_output.c | 1 + 1 file changed, 1 insertion(+) --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -1735,6 +1735,7 @@ struct sk_buff *ip6_make_skb(struct sock cork.base.flags = 0; cork.base.addr = 0; cork.base.opt = NULL; + cork.base.dst = NULL; v6_cork.opt = NULL; err = ip6_setup_cork(sk, &cork, &v6_cork, ipc6, rt, fl6); if (err) {