From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227AbJIKc5cseklHpgP0PBG3SsJUsFz2nJb6VV4HTEJ3kVscx6ISwP+bXZEIkKNS+BzNfhVo ARC-Seal: i=1; a=rsa-sha256; t=1517256553; cv=none; d=google.com; s=arc-20160816; b=OcWIBOZg2g29ltmXGJ486nSZAGgPHLIbg1dWdG5hy28htRo4Amgws2GdHVhd/pK0qY Z/EWVdR3oWySziRYvzNLXxJIuhOJUzY7JRZ5YQ06fvceRHOPT22/tyI9Np1xqDnemfO0 lGw235oC9uSjyYA/DHO0y9b40xAM4LeeTsJkfu2+VxLY4sn/vHHHoD8HPfU7EvzSJxzU v1oGJk32Wx/lOUPZ80aDUStIZHw0WsEL1LOYN7EPAfUtiLouKMMFF6S/Okc52HmMWILB B/isZekYm+s1jUa5O3VMFKnNPYSB/8/8wKlgUsoRWqIFd4+m9i0nSAucHj4UU5JvxKQf 6VQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=WAg/PozVIvJ2ijbfUjE9FiRLIXNo3OlSrrhuUGdifQ4=; b=sS+aaM+Dy5ZTL4Y5bzCzyJUrlu8MvWcDW3ZKGh3WWxN3WFOUnnzlaX/gGmz1KKAW4w JkaFJYdWqSGxo8sgtHgscw9ke1bErptT9CDrKsUwFr600izxVHqS/gXmHwX+9A4Ky2O/ DWBQlJQpHXPncd4ubitYJVCd6KR8tTmKIATFY6x3jg+r6hPfZBDR70SM1bpkMKWh0l7k lBe+WS/DpopeVF1QjKMY0sbUzjOLPToiwMEuYtsGEKEK4Nh8x8ticoC1sBpmvwsSfqMF vyAQfFnqnw9BHhJi3Jyrt24fUt1bI/uI/B5koyLIqpEUwy7QOYrQJkbFTtXjCp6n4OzL umVw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+7b7b518b1228d2743963@syzkaller.appspotmail.com, Neil Horman , Xin Long , Marcelo Ricardo Leitner , "David S. Miller" Subject: [PATCH 4.14 37/71] sctp: do not allow the v4 socket to bind a v4mapped v6 address Date: Mon, 29 Jan 2018 13:57:05 +0100 Message-Id: <20180129123829.750648452@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123827.271171825@linuxfoundation.org> References: <20180129123827.271171825@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590958773280293896?= X-GMAIL-MSGID: =?utf-8?q?1590958807478013381?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xin Long [ Upstream commit c5006b8aa74599ce19104b31d322d2ea9ff887cc ] The check in sctp_sockaddr_af is not robust enough to forbid binding a v4mapped v6 addr on a v4 socket. The worse thing is that v4 socket's bind_verify would not convert this v4mapped v6 addr to a v4 addr. syzbot even reported a crash as the v4 socket bound a v6 addr. This patch is to fix it by doing the common sa.sa_family check first, then AF_INET check for v4mapped v6 addrs. Fixes: 7dab83de50c7 ("sctp: Support ipv6only AF_INET6 sockets.") Reported-by: syzbot+7b7b518b1228d2743963@syzkaller.appspotmail.com Acked-by: Neil Horman Signed-off-by: Xin Long Acked-by: Marcelo Ricardo Leitner Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/sctp/socket.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -334,16 +334,14 @@ static struct sctp_af *sctp_sockaddr_af( if (len < sizeof (struct sockaddr)) return NULL; + if (!opt->pf->af_supported(addr->sa.sa_family, opt)) + return NULL; + /* V4 mapped address are really of AF_INET family */ if (addr->sa.sa_family == AF_INET6 && - ipv6_addr_v4mapped(&addr->v6.sin6_addr)) { - if (!opt->pf->af_supported(AF_INET, opt)) - return NULL; - } else { - /* Does this PF support this AF? */ - if (!opt->pf->af_supported(addr->sa.sa_family, opt)) - return NULL; - } + ipv6_addr_v4mapped(&addr->v6.sin6_addr) && + !opt->pf->af_supported(AF_INET, opt)) + return NULL; /* If we get this far, af is valid. */ af = sctp_get_af_specific(addr->sa.sa_family);