From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227ILySvejMT9moa/bHK8eB434snG1WJ06o5A/FITqiNHmIqP/plkr8fXJXz3q2lpklBjrSp ARC-Seal: i=1; a=rsa-sha256; t=1517256477; cv=none; d=google.com; s=arc-20160816; b=djBEr0i/Q0E4lE9LDdyxzCIN/4jkBHuKoujySBCFKKymEdeuGKOdQPijpPkO9LRiGW uospXR9/w5PkyFwHAc0/SAqy+yYNwZtv1vXAdvJHgxI+2EUVyNDwF4ektBy8wjvxQgUO 2oDn6RYkX1+oP5hkqfw3sZMif7vs4T0lcVUYuxmj8wW/TNPpsJ6vfLz9mNFy1JNhWkZK LsRp2nB4/COb+nMcvKUwGuZZFihstzq4LwhXOd8xVjq6MdFNmzA0QpO7rZahhBRaVT2L ysfnRSOk1QzMWh7eYXdesTf3Nfvyi0na41Fit89Y59jOtPMHl6SeI3v07C0D+TelVpkE Qx+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=riswQZ3X/LRXVTOAI64R7+euoGCVU0XjHB6f8DgKS68=; b=GrVzfD1AqHixif0bxoLidH5dOfuq/KCdOltqkRLLyoSJDWzEHc/Wp2dz6/7zaoM2fk VYpxIKhzcokzExWppPKIaLFlFimenG7GKYTfmMucDD3xleP0+T3jJFjBiUga6zqQu9AW 5k7uo6/83MjAIxugdtqry4pLmK6MDKFVrcAlXZNMTGfvFv4sNHyQOBu0qQfBajlIvlR8 uEQ0PI7pH54BCwtEkDeBf3Jyfj4yvIxbko4s5+SQaMMsYZiX78aI12JAI1/aYITSRNmH U3MN9eVTAUpjfIQY4wXeNAzaZhTLVm1mzaqk2L1Da1/yHO/0XM3WFKJdKocznz92eHPP YoVw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sathya Perla , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , Ivan Vecera , "David S. Miller" Subject: [PATCH 4.14 43/71] be2net: restore properly promisc mode after queues reconfiguration Date: Mon, 29 Jan 2018 13:57:11 +0100 Message-Id: <20180129123830.118442800@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123827.271171825@linuxfoundation.org> References: <20180129123827.271171825@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590958596701478389?= X-GMAIL-MSGID: =?utf-8?q?1590958728255240930?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ivan Vecera [ Upstream commit 52acf06451930eb4cefabd5ecea56e2d46c32f76 ] The commit 622190669403 ("be2net: Request RSS capability of Rx interface depending on number of Rx rings") modified be_update_queues() so the IFACE (HW representation of the netdevice) is destroyed and then re-created. This causes a regression because potential promiscuous mode is not restored properly during be_open() because the driver thinks that the HW has promiscuous mode already enabled. Note that Lancer is not affected by this bug because RX-filter flags are disabled during be_close() for this chipset. Cc: Sathya Perla Cc: Ajit Khaparde Cc: Sriharsha Basavapatna Cc: Somnath Kotur Fixes: 622190669403 ("be2net: Request RSS capability of Rx interface depending on number of Rx rings") Signed-off-by: Ivan Vecera Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/emulex/benet/be_main.c | 9 +++++++++ 1 file changed, 9 insertions(+) --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -4634,6 +4634,15 @@ int be_update_queues(struct be_adapter * be_schedule_worker(adapter); + /* + * The IF was destroyed and re-created. We need to clear + * all promiscuous flags valid for the destroyed IF. + * Without this promisc mode is not restored during + * be_open() because the driver thinks that it is + * already enabled in HW. + */ + adapter->if_flags &= ~BE_IF_FLAGS_ALL_PROMISCUOUS; + if (netif_running(netdev)) status = be_open(netdev);