From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224fbbueqqDFOzPzbvvLvaaWn0F5UU+i0ZRiyl1NoCL6P4m9AEgJ9J0p0byjrRqRoV3ZdXOh ARC-Seal: i=1; a=rsa-sha256; t=1517256265; cv=none; d=google.com; s=arc-20160816; b=MqRfr7J49O4FuH7qaMS7/MEWWNlPJWIVe3CuiKeFV+JwI+gigDSkIFpSbPNOHlG+Xn Kw6B9flD/ypJNc0OyP2eZpvSZCoL92gHzsHEaJTCMKJHWmoY/TuaazOBh5NTDfi/G8es vXtJe7N2bjC6l2zHC1uFHKm0UbQpJFsWbUwyE0UJGDaz2i5EEEWhew+MK7A2zkgDX8Dw QEiUl/4xUb29NOisk9EXkKV5Z2mV2wb0WCFJJoV5D1BqW6FkTWdFbph5SchuMLqPUJn6 H1y/FAvhVxCAmSogZxBUYJTctJzVzasK/F5EVUGzVSJJe9Ncb8YmL0kjGSEH1/lAxUfS 0rng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=9I+jZXLKVNIdGEuhp3I1A0kOz2oyn5/sEcEoMAFBlvw=; b=zh7Xo90COVZBUC6PhWkKKONzk+S/Z+71kkGIhi5DvvlUCW1zqyirYVLeyPxl/iXIQH +Eyb8iym+ck/KBRu5C8C0pPvAVxxQMRo5sFHPq7yjRE4AZIrpnTfUGKMsrTRud5qzNJQ HEJi3WjL9/Vq/SKYXfisNeI/vKyalR4x/rnzQhjNT/Pn5luVblj99KvJAqSxzrd5TRmX EwLBup5E7vDCMWjKTfXRJ98sc9UahvW7kTI2Zoqzvpt0jweMwXJE+l0noTyhJSkOMqHx om1+00vcIXTCLzHon4QIcEU3zRnhpKH2tU9zD/OjOjDenObBDgIzVMJg0Of4Ux4mqaOr WN9w== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yuval Mintz , Ido Schimmel , Jiri Pirko , "David S. Miller" Subject: [PATCH 4.14 46/71] mlxsw: spectrum_router: Dont log an error on missing neighbor Date: Mon, 29 Jan 2018 13:57:14 +0100 Message-Id: <20180129123830.294162289@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123827.271171825@linuxfoundation.org> References: <20180129123827.271171825@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590958420059907948?= X-GMAIL-MSGID: =?utf-8?q?1590958506533589613?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuval Mintz [ Upstream commit 1ecdaea02ca6bfacf2ecda500dc1af51e9780c42 ] Driver periodically samples all neighbors configured in device in order to update the kernel regarding their state. When finding an entry configured in HW that doesn't show in neigh_lookup() driver logs an error message. This introduces a race when removing multiple neighbors - it's possible that a given entry would still be configured in HW as its removal is still being processed but is already removed from the kernel's neighbor tables. Simply remove the error message and gracefully accept such events. Fixes: c723c735fa6b ("mlxsw: spectrum_router: Periodically update the kernel's neigh table") Fixes: 60f040ca11b9 ("mlxsw: spectrum_router: Periodically dump active IPv6 neighbours") Signed-off-by: Yuval Mintz Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c @@ -1531,11 +1531,8 @@ static void mlxsw_sp_router_neigh_ent_ip dipn = htonl(dip); dev = mlxsw_sp->router->rifs[rif]->dev; n = neigh_lookup(&arp_tbl, &dipn, dev); - if (!n) { - netdev_err(dev, "Failed to find matching neighbour for IP=%pI4h\n", - &dip); + if (!n) return; - } netdev_dbg(dev, "Updating neighbour with IP=%pI4h\n", &dip); neigh_event_send(n, NULL); @@ -1562,11 +1559,8 @@ static void mlxsw_sp_router_neigh_ent_ip dev = mlxsw_sp->router->rifs[rif]->dev; n = neigh_lookup(&nd_tbl, &dip, dev); - if (!n) { - netdev_err(dev, "Failed to find matching neighbour for IP=%pI6c\n", - &dip); + if (!n) return; - } netdev_dbg(dev, "Updating neighbour with IP=%pI6c\n", &dip); neigh_event_send(n, NULL);