From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224b8a8FTXZCMrEjIu2cd0g/5nH50L5dUjhKaVr9IBHYMIj7m6HlfK0cGJJFI0SUcqyzPlmP ARC-Seal: i=1; a=rsa-sha256; t=1517256337; cv=none; d=google.com; s=arc-20160816; b=QS4AD46qnz/AGSeCBOoq7W5EaDS/I77Zb/HOtZO1Wc4xleEQzlKEcje3XrKCT2QeYd w2OwUi030ZHrIZm/+kwhVgqNMhVcCPxT4Ubu9tYeX7+9MgWB4ayU8ioql04+3NaK+enW 1B36iSeNzGFBY9kS0GXpkihrqb6OOwuIeDw6kHHod87NWf/ZmfhgiHO9FrsGX39ybRgJ pQRioTjKNFgU7TszKvzQR/i1K7hOU3tfDYaWmKJzgMptZtdLrz+0+Kx4tAU66nkljYn3 BA8AecT26BFrrooNX6/uFx2KVlO2v8TL/LelXaH1s5kRF+O4RoSqVUZbmJmxVHENwvK3 67Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=v8n5r0FbGK+iE6rWh1tyoHv3RqvEVyEWbWycwNNuy+Y=; b=0NPDdW69y61IjndK0ZJmCqEA6PNpF11UGAmPD/sjDBwvUVhXXGexUoJRwHL2cS216T UCxt+MH1hP+JKiuGtGrdvvNUyqAVKgE2qi+BbrhjwIvG47Dgu5cjDCqs87OhmOYCGWtj 67YfXOwBZCAXX1xbEsCuQ8Xr5IYCZSLvg7cnbfthr0S9lCGC2tnfiHMUXBZ3gf8dRXOQ iEQ8aBT1fm9hqtOq9sRzFCUWMg1iW9YwDzjZhajJ+LLOhNF7ARFDsSmAQ7gkUgst3L+Y PtJWlxPbvA2rqsxIevpdnr+npN2eQaaM8bLQ/BLcIf3tx8ckx/G72mCKKsqgChaoTCzz 7ToA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , syzbot , "David S. Miller" Subject: [PATCH 4.4 61/74] ipv6: ip6_make_skb() needs to clear cork.base.dst Date: Mon, 29 Jan 2018 13:57:06 +0100 Message-Id: <20180129123850.300737739@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123847.507563674@linuxfoundation.org> References: <20180129123847.507563674@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590958581264208744?= X-GMAIL-MSGID: =?utf-8?q?1590958581264208744?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit 95ef498d977bf44ac094778fd448b98af158a3e6 ] In my last patch, I missed fact that cork.base.dst was not initialized in ip6_make_skb() : If ip6_setup_cork() returns an error, we might attempt a dst_release() on some random pointer. Fixes: 862c03ee1deb ("ipv6: fix possible mem leaks in ipv6_make_skb()") Signed-off-by: Eric Dumazet Reported-by: syzbot Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv6/ip6_output.c | 1 + 1 file changed, 1 insertion(+) --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -1785,6 +1785,7 @@ struct sk_buff *ip6_make_skb(struct sock cork.base.flags = 0; cork.base.addr = 0; cork.base.opt = NULL; + cork.base.dst = NULL; v6_cork.opt = NULL; err = ip6_setup_cork(sk, &cork, &v6_cork, hlimit, tclass, opt, rt, fl6); if (err) {