From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <peterz@infradead.org>
X-Google-Smtp-Source: AH8x2269zzZVz20ixf928fa5RQUrOMzV8FexNeHfxKGkmokt3TWthBynqjJhJfC+LuxarYIEZyUA
ARC-Seal: i=1; a=rsa-sha256; t=1517253680; cv=none;
        d=google.com; s=arc-20160816;
        b=YMS0UtglgofXyGqyOi1idIyA+CWeE9QyEz4whWqjJxNd3985Xpu29CnsuXU+m6FO28
         Fwo6W0fBpz0ISJZm2V0xXfv+op6LIBJo6buhAq2uTP3D2xLGYrjzVdFVqJLyPx9QHPQW
         JW/qv7B2lvDaHY4c3hGb0tcBmk9Ze+ghB7G0VfpAGW6Rqk0R+NKRCiX8wigKysurCGKV
         IEk8tB08bmTX0gKxMwkC4AbUpVs8y/ZBhHHBzHHEbHTmZn45ZaJZY4Caf/J+jIlnc9CQ
         TIPdNjcRPiDTt/JLgginCER9xPqAqJ0/+K3gHG3oyOQxur5r2Y1ZEHYLVkW0mAlF0thC
         EuJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :message-id:subject:cc:to:from:date:dkim-signature
         :arc-authentication-results;
        bh=s1AY8heJVw7snacoIoYxAwDk76rgIAqhhlaGZF0gcmE=;
        b=FSlWn+0M8e7HR2wZGTn97+P2q3b/Wu8vWgzT29kNLvP8mNzqHgCFTGr8CpcNzVOWyy
         cfIM1OsmpjP5m04TK31NwnlCws3eiAljmrpRIc5JJD2D4gqd2jMMjAtaMP8gHyYHW2IG
         7TqJCKGy17yimHC8jcZGX6tjzj+hfWZspeg9AI06U4tnsLLOnUqfu7cBX5GVxCMDVVa+
         ruqSSXaRt8ROgm6PkkP38TAqs2LWYiy0m/tB2uCM17a3JW4TS+2j7G/RT8HjkFfeMMSk
         UtwkaCiY0T+FM7k80XjPFLDuVHPnFkMwHXVNKppXjrvbEG9Ae1QGtqQBpVYnkRhDxBhe
         UeWg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=kL4+fapo;
       spf=pass (google.com: best guess record for domain of peterz@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=peterz@infradead.org
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=kL4+fapo;
       spf=pass (google.com: best guess record for domain of peterz@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=peterz@infradead.org
Date: Mon, 29 Jan 2018 20:21:08 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
	Dave Hansen <dave.hansen@intel.com>,
	Ashok Raj <ashok.raj@intel.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Andi Kleen <ak@linux.intel.com>,
	Arjan Van De Ven <arjan.van.de.ven@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Asit Mallick <asit.k.mallick@intel.com>,
	Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls
Message-ID: <20180129192108.GR2249@hirez.programming.kicks-ass.net>
References: <20180123152539.374360046@infradead.org>
 <20180123152638.162540737@infradead.org>
 <20180129183850.b6mjtuz4j5d7wum6@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180129183850.b6mjtuz4j5d7wum6@treble>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1590397845189698377?=
X-GMAIL-MSGID: =?utf-8?q?1590955795122184004?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Mon, Jan 29, 2018 at 12:38:50PM -0600, Josh Poimboeuf wrote:
> On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote:
> > Paravirt emits indirect calls which get flagged by objtool retpoline
> > checks, annotate it away because all these indirect calls will be
> > patched out before we start userspace.
> 
> There's one condition where this isn't true: the 'noreplace-paravirt'
> cmdline option.  I have no idea why that option exists but we should
> consider just removing it.

Smells like a debug remnant from back when all this patching crap was
new. And yes, that sounds like something that should maybe go away. Esp.
for retpoline builds.