From: David Sterba <dsterba@suse.cz>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix unexpected cow in run_delalloc_nocow
Date: Tue, 30 Jan 2018 14:31:10 +0100 [thread overview]
Message-ID: <20180130133110.GD19355@twin.jikos.cz> (raw)
In-Reply-To: <20180125180256.10844-2-bo.li.liu@oracle.com>
On Thu, Jan 25, 2018 at 11:02:49AM -0700, Liu Bo wrote:
> Fstests generic/475 provides a way to fail metadata reads while
> checking if checksum exists for the inode inside run_delalloc_nocow(),
> and csum_exist_in_range() interprets error (-EIO) as inode having
> checksum and makes its caller enters the cow path.
>
> In case of free space inode, this ends up with a warning in
> cow_file_range().
>
> The same problem applies for btrfs_cross_ref_exist() since it may also
> read metadata in between.
>
> With this, run_delalloc_nocow() bails out when errors occur at the two
> places.
>
> cc: <stable@vger.kernel.org> v2.6.28+
> Fixes: 17d217fe970d ("Btrfs: fix nodatasum handling in balancing code")
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
This and the other fixes sent in this batch have been added to next and
I'm going to push them to 4.16 either during the merge window still or
at rc1 time. Thanks.
next prev parent reply other threads:[~2018-01-30 13:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 18:02 [PATCH] Btrfs: fix unexpected cow in run_delalloc_nocow Liu Bo
2018-01-26 14:02 ` Josef Bacik
2018-01-30 13:31 ` David Sterba [this message]
2018-02-01 0:09 ` [PATCH v2] " Liu Bo
2018-03-07 16:10 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130133110.GD19355@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.