All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Yisheng Xie <xieyisheng1@huawei.com>
Cc: devel@driverdev.osuosl.org, sumit.semwal@linaro.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: android: ion: minor cleanup for ion_page_pool
Date: Wed, 31 Jan 2018 12:32:29 +0100	[thread overview]
Message-ID: <20180131113229.GA14082@kroah.com> (raw)
In-Reply-To: <1517392252-20964-1-git-send-email-xieyisheng1@huawei.com>

On Wed, Jan 31, 2018 at 05:50:52PM +0800, Yisheng Xie wrote:
> ion_page_pool.c now is used to apply pool APIs for system heap, which do
> not need do any initial at device_initcall.
> 
> Meanwhile, this patch also remove some useless include files.

Please only do one thing per patch, otherwise if one of the different
things you do has a problem, all of the changes have been reverted.

Yeah, it's a pain at times, but that's the way kernel development is,
sorry.

Please break this up into two patches and resend.  I will be glad to
queue them up after the merge window ends when 4.16-rc1 is released.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2018-01-31 11:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31  9:50 [PATCH] staging: android: ion: minor cleanup for ion_page_pool Yisheng Xie
2018-01-31 11:32 ` Greg KH [this message]
2018-02-01  0:57   ` Yisheng Xie
2018-02-06 22:51 ` Laura Abbott
2018-02-07  0:47   ` Yisheng Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180131113229.GA14082@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=xieyisheng1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.