From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-716496-1517403658-2-3856802491041807314 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517403657; b=u0acSJMAZclmySrYIN3JEDzV81Kj+5Kw3rPxWfR5HIrnCky rOAWdmnzvrBw4wVb9hpKumpOQ916Y8azNcHmsoE/FYeKUo7BeG39ti6uMN6uF0V2 lHEL7No/QGOpK2OO01FU4FQOHTrv4SK5JnkKlxn36YRH4AupTF7DDv9UYNuMz3vR gCCJYBe/OaymgqJU2KtF9n/HyHT/p1gz7sapFHWtNBlRS9UtM81pN7N7OnE54zVT 6RFtaFcpMPOu7YmIzO1bRmYMsQ2VTqtIw3ULNEHdMiulKmxIERPhNjb41OGWZgDl 08RVaO+UO6w6ZGs4zBweOr9G1yg5ZYVcOhNuQGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1517403657; bh=B WQyKQiRZHb7KI4DRBnMmsPt9aPgOsTGG/Bb3oRCYxs=; b=FkvmtzZKTgbxpzS4D 6DNeka08HPueJqnZd4mZ0ynbK5phks0UgiH22D5z5nOa4lRmJRcgFg1tdLFhmXQv cd333kWkc/paTXFheLmIWo6xqle14AJcbEPPiPnLehs6/wjwXbwsG5yk68IxyWtZ OZhEzofAmBaXUXfcTHHKkpZYAo1oYSrTi2MVrZyryzszsmM4eQwT2Bon+DeFgqIy BYLBhnU6GFEfQUM0meq2ATYw2NgtaRLmxdOuUnsajOeCw9rArdtKwtFQGntosZVc zl2Oy3f68OThHV2tti1kcygd4YziYX+DRkGBKZTEQNm6gthIHHVapaOPhVIi9aOP T4Xfw== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Wed, 31 Jan 2018 14:00:47 +0100 From: Greg KH To: Alexey Skidanov Subject: Re: [PATCH v3] staging: android: ion: Add implementation of dma_buf_vmap and dma_buf_vunmap Message-ID: <20180131130047.GA22917@kroah.com> References: <1517400222-2854-1-git-send-email-alexey.skidanov@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1517400222-2854-1-git-send-email-alexey.skidanov@intel.com> User-Agent: Mutt/1.9.3 (2018-01-21) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, tkjos@android.com, rve@android.com, linux-kernel@vger.kernel.org, maco@android.com, sumit.semwal@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Jan 31, 2018 at 02:03:42PM +0200, Alexey Skidanov wrote: > Any driver may access shared buffers, created by ion, using dma_buf_vmap and > dma_buf_vunmap dma-buf API that maps/unmaps previosuly allocated buffers into > the kernel virtual address space. The implementation of these API is missing in > the current ion implementation. > > Signed-off-by: Alexey Skidanov > --- No review from any other Intel developers? :( Anyway, what in-tree driver needs access to these functions? And are you sure that you don't need to do any "real" logic in the vmap/vunmap calls? That feels like there would be some reference counting problems here. > drivers/staging/android/ion/ion.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index f480885..4f1dc7f 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -327,6 +327,17 @@ static void ion_dma_buf_kunmap(struct dma_buf *dmabuf, unsigned long offset, > { > } > > +static void *ion_dma_buf_vmap(struct dma_buf *dmabuf) > +{ > + struct ion_buffer *buffer = dmabuf->priv; > + > + return buffer->vaddr; Just call ion_dma_buf_kmap(dmabuf, 0)? Again, please get this reviewed by someone else in Intel first. Don't ignore the resources you have, to do so would be foolish :) thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel