From: Dave Chinner <david@fromorbit.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: linux-nvdimm@lists.01.org, darrick.wong@oracle.com,
linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX
Date: Fri, 2 Feb 2018 14:20:23 +1100 [thread overview]
Message-ID: <20180202032023.l644wdfecdm3eqdp@destitution> (raw)
In-Reply-To: <76cbab51-9f18-8531-016e-4e1f3c43637b@intel.com>
On Thu, Feb 01, 2018 at 05:13:40PM -0700, Dave Jiang wrote:
>
>
> On 02/01/2018 04:44 PM, Dave Chinner wrote:
> > On Thu, Feb 01, 2018 at 01:33:05PM -0700, Dave Jiang wrote:
> >> When using realtime device (rtdev) with xfs where the data device is not
> >> DAX capable, two issues arise. One is when data device is not DAX but the
> >> realtime device is DAX capable, we currently disable DAX.
> >> After passing this check, we are also not marking the inode as DAX capable.
> >> This change will allow DAX enabled if the data device or the realtime
> >> device is DAX capable. S_DAX will be marked for the inode if the file is
> >> residing on a DAX capable device. This will prevent the case of rtdev is not
> >> DAX and data device is DAX to create realtime files.
> >
> > I'm confused by this description. I'm not sure what is broken, nor
> > what you are trying to fix.
> >
> > I think what you want to do is enable DAX on RT devices separately
> > to the data device and vice versa?
> >
> > i.e. is this what you are trying to acheive?
> >
> > datadev dax rtdev dax DAX enabled on
> > ----------- --------- --------------
> > no no neither
> > yes no datadev
> > no yes rtdev
> > yes yes both
>
> ^ Yes that's pretty much what I was trying to say. I probably should've
> just provided the table above.
Ok, good to know I understood what you want to achieve. Now we've
just got to work out how to do it. :)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>
To: Dave Jiang <dave.jiang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX
Date: Fri, 2 Feb 2018 14:20:23 +1100 [thread overview]
Message-ID: <20180202032023.l644wdfecdm3eqdp@destitution> (raw)
In-Reply-To: <76cbab51-9f18-8531-016e-4e1f3c43637b-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Thu, Feb 01, 2018 at 05:13:40PM -0700, Dave Jiang wrote:
>
>
> On 02/01/2018 04:44 PM, Dave Chinner wrote:
> > On Thu, Feb 01, 2018 at 01:33:05PM -0700, Dave Jiang wrote:
> >> When using realtime device (rtdev) with xfs where the data device is not
> >> DAX capable, two issues arise. One is when data device is not DAX but the
> >> realtime device is DAX capable, we currently disable DAX.
> >> After passing this check, we are also not marking the inode as DAX capable.
> >> This change will allow DAX enabled if the data device or the realtime
> >> device is DAX capable. S_DAX will be marked for the inode if the file is
> >> residing on a DAX capable device. This will prevent the case of rtdev is not
> >> DAX and data device is DAX to create realtime files.
> >
> > I'm confused by this description. I'm not sure what is broken, nor
> > what you are trying to fix.
> >
> > I think what you want to do is enable DAX on RT devices separately
> > to the data device and vice versa?
> >
> > i.e. is this what you are trying to acheive?
> >
> > datadev dax rtdev dax DAX enabled on
> > ----------- --------- --------------
> > no no neither
> > yes no datadev
> > no yes rtdev
> > yes yes both
>
> ^ Yes that's pretty much what I was trying to say. I probably should've
> just provided the table above.
Ok, good to know I understood what you want to achieve. Now we've
just got to work out how to do it. :)
Cheers,
Dave.
--
Dave Chinner
david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: darrick.wong@oracle.com, linux-xfs@vger.kernel.org,
ross.zwisler@linux.intel.com, linux-ext4@vger.kernel.org,
dan.j.williams@intel.com, linux-nvdimm@lists.01.org
Subject: Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX
Date: Fri, 2 Feb 2018 14:20:23 +1100 [thread overview]
Message-ID: <20180202032023.l644wdfecdm3eqdp@destitution> (raw)
In-Reply-To: <76cbab51-9f18-8531-016e-4e1f3c43637b@intel.com>
On Thu, Feb 01, 2018 at 05:13:40PM -0700, Dave Jiang wrote:
>
>
> On 02/01/2018 04:44 PM, Dave Chinner wrote:
> > On Thu, Feb 01, 2018 at 01:33:05PM -0700, Dave Jiang wrote:
> >> When using realtime device (rtdev) with xfs where the data device is not
> >> DAX capable, two issues arise. One is when data device is not DAX but the
> >> realtime device is DAX capable, we currently disable DAX.
> >> After passing this check, we are also not marking the inode as DAX capable.
> >> This change will allow DAX enabled if the data device or the realtime
> >> device is DAX capable. S_DAX will be marked for the inode if the file is
> >> residing on a DAX capable device. This will prevent the case of rtdev is not
> >> DAX and data device is DAX to create realtime files.
> >
> > I'm confused by this description. I'm not sure what is broken, nor
> > what you are trying to fix.
> >
> > I think what you want to do is enable DAX on RT devices separately
> > to the data device and vice versa?
> >
> > i.e. is this what you are trying to acheive?
> >
> > datadev dax rtdev dax DAX enabled on
> > ----------- --------- --------------
> > no no neither
> > yes no datadev
> > no yes rtdev
> > yes yes both
>
> ^ Yes that's pretty much what I was trying to say. I probably should've
> just provided the table above.
Ok, good to know I understood what you want to achieve. Now we've
just got to work out how to do it. :)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-02-02 3:17 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 20:32 [PATCH 2 1/2] dax: change bdev_dax_supported() to take a block_device as input Dave Jiang
2018-02-01 20:32 ` Dave Jiang
2018-02-01 20:32 ` Dave Jiang
2018-02-01 20:33 ` [PATCH 2 2/2] xfs: fix rt_dev usage for DAX Dave Jiang
2018-02-01 20:33 ` Dave Jiang
2018-02-01 23:28 ` Darrick J. Wong
2018-02-01 23:28 ` Darrick J. Wong
2018-02-01 23:28 ` Darrick J. Wong
2018-02-02 0:08 ` Dave Jiang
2018-02-02 0:08 ` Dave Jiang
2018-02-02 0:08 ` Dave Jiang
2018-02-02 0:38 ` Darrick J. Wong
2018-02-02 0:38 ` Darrick J. Wong
2018-02-02 0:38 ` Darrick J. Wong
2018-02-01 23:44 ` Dave Chinner
2018-02-01 23:44 ` Dave Chinner
2018-02-02 0:13 ` Dave Jiang
2018-02-02 0:13 ` Dave Jiang
2018-02-02 0:13 ` Dave Jiang
2018-02-02 3:20 ` Dave Chinner [this message]
2018-02-02 3:20 ` Dave Chinner
2018-02-02 3:20 ` Dave Chinner
2018-02-02 0:43 ` Darrick J. Wong
2018-02-02 0:43 ` Darrick J. Wong
2018-02-02 0:43 ` Darrick J. Wong
2018-02-02 3:36 ` Dave Chinner
2018-02-02 3:36 ` Dave Chinner
2018-02-06 22:32 ` Dave Jiang
2018-02-06 22:32 ` Dave Jiang
2018-02-06 22:32 ` Dave Jiang
2018-02-06 23:19 ` Darrick J. Wong
2018-02-06 23:19 ` Darrick J. Wong
2018-02-07 0:19 ` Dan Williams
2018-02-07 0:19 ` Dan Williams
2018-02-07 0:19 ` Dan Williams
2018-03-06 0:06 ` Ross Zwisler
2018-03-06 0:06 ` Ross Zwisler
2018-03-06 0:06 ` Ross Zwisler
2018-02-01 22:46 ` [PATCH 2 1/2] dax: change bdev_dax_supported() to take a block_device as input Darrick J. Wong
2018-02-01 22:46 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202032023.l644wdfecdm3eqdp@destitution \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=dave.jiang@intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.