From: Maxime Ripard <maxime.ripard@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 09/15] env: Support multiple environments
Date: Wed, 7 Feb 2018 09:19:13 +0100 [thread overview]
Message-ID: <20180207081913.wa33sx6k4iwxdecs@flea> (raw)
In-Reply-To: <64448a79-f856-0cd9-d9b2-a5e29b92d768@de.pepperl-fuchs.com>
On Tue, Feb 06, 2018 at 09:09:07AM +0100, Simon Goldschmidt wrote:
> On 23.01.2018 21:16, Maxime Ripard wrote:
> > Now that we have everything in place to support multiple environment, let's
> > make sure the current code can use it.
>
> I get more build errors testing this feature: there's a global variable
> 'env_ptr' declared in flash, nand, nvram and remote env drivers (declared as
> extern in envrionment.h). From reading the code, it seems like these could
> just be changed to static, since 'env_ptr' is not used outside these
> drivers?
Given Joakim's comment, I guess we should keep them !static, rename
them to $env_env_ptr, and remove the definition in the
include/environment that doesn't seem used anywhere.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180207/e071e98b/attachment.sig>
next prev parent reply other threads:[~2018-02-07 8:19 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 20:16 [U-Boot] [PATCH v3 00/15] env: Multiple env support and env transition for sunxi Maxime Ripard
2018-01-23 20:16 ` [U-Boot] [PATCH v3 01/15] cmd: nvedit: Get rid of the env lookup Maxime Ripard
2018-01-27 19:20 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-01-23 20:16 ` [U-Boot] [PATCH v3 02/15] env: Rename env_driver_lookup_default and env_get_default_location Maxime Ripard
2018-01-27 19:20 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-01-23 20:16 ` [U-Boot] [PATCH v3 03/15] env: Pass additional parameters to the env lookup function Maxime Ripard
2018-01-27 19:20 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-04-05 10:48 ` [U-Boot] [PATCH v3 " Simon Goldschmidt
2018-01-23 20:16 ` [U-Boot] [PATCH v3 04/15] env: Make the env save message a bit more explicit Maxime Ripard
2018-01-27 19:20 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-01-23 20:16 ` [U-Boot] [PATCH v3 05/15] env: Make it explicit where we're loading our environment from Maxime Ripard
2018-01-27 19:20 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-01-23 20:16 ` [U-Boot] [PATCH v3 06/15] env: fat: Make the debug messages play a little nicer Maxime Ripard
2018-01-27 19:20 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-01-23 20:16 ` [U-Boot] [PATCH v3 07/15] env: mmc: " Maxime Ripard
2018-01-24 13:52 ` Jaehoon Chung
2018-01-27 19:21 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-01-23 20:16 ` [U-Boot] [PATCH v3 08/15] env: common: " Maxime Ripard
2018-01-27 19:21 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-01-23 20:16 ` [U-Boot] [PATCH v3 09/15] env: Support multiple environments Maxime Ripard
2018-01-27 19:21 ` [U-Boot] [U-Boot,v3,09/15] " Tom Rini
2018-01-30 8:19 ` [U-Boot] [PATCH v3 09/15] " Simon Goldschmidt
2018-01-30 19:39 ` York Sun
2018-01-30 20:16 ` York Sun
2018-01-30 23:02 ` York Sun
2018-01-31 6:41 ` Simon Goldschmidt
2018-02-07 8:43 ` Maxime Ripard
2018-02-07 20:18 ` York Sun
2018-02-06 8:09 ` Simon Goldschmidt
2018-02-06 8:20 ` Joakim Tjernlund
2018-02-07 8:18 ` Maxime Ripard
2018-02-07 8:34 ` Joakim Tjernlund
2018-02-07 8:32 ` Simon Goldschmidt
2018-02-07 8:45 ` Joakim Tjernlund
2018-02-07 18:23 ` Maxime Ripard
2018-02-07 8:19 ` Maxime Ripard [this message]
2018-02-07 8:25 ` Simon Goldschmidt
2018-02-07 18:48 ` Maxime Ripard
2018-01-23 20:16 ` [U-Boot] [PATCH v3 10/15] env: Initialise all the environments Maxime Ripard
2018-01-27 19:21 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-01-23 20:17 ` [U-Boot] [PATCH v3 11/15] env: mmc: depends on the MMC framework Maxime Ripard
2018-01-24 13:51 ` Jaehoon Chung
2018-01-27 19:21 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-01-23 20:17 ` [U-Boot] [PATCH v3 12/15] env: Allow to build multiple environments in Kconfig Maxime Ripard
2018-01-27 19:21 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-02-01 10:06 ` [U-Boot] [PATCH v3 " Simon Goldschmidt
2018-02-02 19:47 ` Maxime Ripard
2018-01-23 20:17 ` [U-Boot] [PATCH v3 13/15] env: Mark env_get_location as weak Maxime Ripard
2018-01-27 19:21 ` [U-Boot] [U-Boot,v3,13/15] " Tom Rini
2018-01-30 8:12 ` [U-Boot] [PATCH v3 13/15] " Simon Goldschmidt
2018-01-30 8:18 ` Maxime Ripard
2018-01-23 20:17 ` [U-Boot] [PATCH v3 14/15] sunxi: Transition from the MMC to a FAT-based environment Maxime Ripard
2018-01-27 19:21 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-01-23 20:17 ` [U-Boot] [PATCH v3 15/15] env: sunxi: Enable FAT-based environment support by default Maxime Ripard
2018-01-27 19:21 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-02-07 20:45 [U-Boot] [PATCH v3 09/15] env: Support multiple environments Goldschmidt Simon
2018-02-07 21:18 ` York Sun
2018-02-08 5:30 ` Simon Goldschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207081913.wa33sx6k4iwxdecs@flea \
--to=maxime.ripard@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.