From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Wed, 7 Feb 2018 09:31:43 +0100 Subject: [U-Boot] [PATCH] cmd: nvedit: env_get_f must check for env_get_char error codes In-Reply-To: References: <20180131065648.5490-1-sgoldschmidt@de.pepperl-fuchs.com> <86985599-0df7-a690-b027-1ce740235bd8@de.pepperl-fuchs.com> <20180202185149.fmuled5rrxg4uiki@flea.lan> <20180205134358.h4wan73viaa6eynj@flea> Message-ID: <20180207083143.phxuvylfmm3kplzu@flea> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de On Mon, Feb 05, 2018 at 04:30:50PM +0000, York Sun wrote: > On 02/05/2018 05:44 AM, Maxime Ripard wrote: > > Hi York, > >=20 > > On Fri, Feb 02, 2018 at 08:04:12PM +0000, York Sun wrote: > >> On 02/02/2018 10:51 AM, Maxime Ripard wrote: > >>>>> This patch looks correct. But it doesn't fix NOR flash. Do you have= plan > >>>>> to add .get_char function to other drivers? Without that function, = we > >>>>> cannot get env variables before relocation. > >>>> > >>>> Ehrm, sorry=C2=A0 I don't plan to do that, no: my target seems to ru= n fine > >>>> without this. > >>>> > >>>> Given that only the eeprom and nvram env drivers support the get_char > >>>> method, I don't know if this is widely used at all. Maybe a better f= allback > >>>> would be to just remove that get_char code path totally and always l= oad from > >>>> the internal (default) environment until the full environment is ava= ilable > >>>> (after relocation). > >>>> > >>>> After all, the environment variables loaded via get_char are not CRC= checked > >>>> at all. To me, this is another indication that this code is not real= ly > >>>> useful and should probably be removed. > >>> > >>> To be honest, I'm not really sure what get_char was here for in the > >>> first place, so getting rid of it sounds like a good idea :) > >> > >> On almost all my boards, a variable hwconfig is read before relocation > >> to determine DDR configuration. This has been broken. I don't mind you > >> remove some dead code. But this is breaking almost all my boards booti= ng > >> from NOR flash. > >=20 > > Sorry if it fell through the cracks, I don't have a board with NOR > > myself. Do you know what breaks exactly? > >=20 > > Or can you bisect at least? > Yes, I did. It was the #3 patch in the series of "env: Multiple env > support and env transition for sunxi". I reported in the email thread > "Re: [U-Boot] [PATCH v3 09/15] env: Support multiple environments", > along with another problem found regarding variable "env_load_location". > The latter problem breaks saveenv on NOR flash. Ah, right, I overlooked it, sorry. I'll reply there. Thanks! Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: