From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG
Date: Fri, 9 Feb 2018 20:27:27 +0000 [thread overview]
Message-ID: <20180209202727.GA27879@work-vm> (raw)
In-Reply-To: <20180209104546.29401-1-pbonzini@redhat.com>
* Paolo Bonzini (pbonzini@redhat.com) wrote:
> This is a race that can happen when migrating TCG guests under load.
> It was introduced by the change to run vCPUs outside the big QEMU lock.
I can't yet confirming this fixes it; my test on the ARM box I was using
are doing ... odd things - I've got some tests that aren't finishing
under load (as opposed to crashing).
Dave
> Paolo Bonzini (4):
> memory: remove memory_region_test_and_clear_dirty
> memory: hide memory_region_sync_dirty_bitmap behind
> DirtyBitmapSnapshot
> memory: introduce memory_global_after_dirty_log_sync
> memory: unify loops to sync dirty log bitmap
>
> exec.c | 31 ++++++++++++++++++
> hw/display/cg3.c | 1 -
> hw/display/exynos4210_fimd.c | 1 -
> hw/display/framebuffer.c | 1 -
> hw/display/g364fb.c | 1 -
> hw/display/sm501.c | 1 -
> hw/display/tcx.c | 2 --
> hw/display/vga.c | 6 ----
> include/exec/memory.h | 47 +++++++++------------------
> memory.c | 76 +++++++++++++++++---------------------------
> migration/ram.c | 1 +
> 11 files changed, 76 insertions(+), 92 deletions(-)
>
> --
> 2.14.3
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2018-02-09 20:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 10:45 [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG Paolo Bonzini
2018-02-09 10:45 ` [Qemu-devel] [PATCH 1/4] memory: remove memory_region_test_and_clear_dirty Paolo Bonzini
2018-02-09 20:13 ` Richard Henderson
2018-02-09 10:45 ` [Qemu-devel] [PATCH 2/4] memory: hide memory_region_sync_dirty_bitmap behind DirtyBitmapSnapshot Paolo Bonzini
2018-02-09 20:16 ` Richard Henderson
2018-02-09 10:45 ` [Qemu-devel] [PATCH 3/4] memory: introduce memory_global_after_dirty_log_sync Paolo Bonzini
2018-02-09 20:20 ` Richard Henderson
2018-02-09 10:45 ` [Qemu-devel] [PATCH 4/4] memory: unify loops to sync dirty log bitmap Paolo Bonzini
2018-02-09 20:23 ` Richard Henderson
2018-02-09 11:02 ` [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG no-reply
2018-02-09 11:33 ` no-reply
2018-02-09 11:33 ` no-reply
2018-02-09 20:27 ` Dr. David Alan Gilbert [this message]
2018-02-13 11:10 ` Dr. David Alan Gilbert
2018-10-30 12:21 ` Alex Bennée
2018-10-30 13:48 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209202727.GA27879@work-vm \
--to=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.