From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Ausmus Subject: Re: [PATCH 3/5] drm/i915: Call i915_pipe_update_start with uncore.lock held. Date: Fri, 9 Feb 2018 15:08:32 -0800 Message-ID: <20180209230831.GC12467@jausmus-gentoo-dev6.jf.intel.com> References: <20180209095404.76418-1-maarten.lankhorst@linux.intel.com> <20180209095404.76418-4-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 73CA56E25C for ; Fri, 9 Feb 2018 23:05:59 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180209095404.76418-4-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBGZWIgMDksIDIwMTggYXQgMTA6NTQ6MDJBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gVGhpcyByZXF1aXJlcyBiZWluZyBhYmxlIHRvIHJlYWQgdGhlIHZibGFuayBj b3VudGVyIHdpdGggdGhlCj4gdW5jb3JlLmxvY2sgYWxyZWFkeSBoZWxkLiBUaGlzIGlzIGFsc28g YSBwcmVwYXJhdGlvbiBmb3IKPiBiZWluZyBhYmxlIHRvIHJ1biB0aGUgZW50aXJlIHZibGFuayB1 cGRhdGUgc2VxdWVuY2Ugd2l0aAo+IHRoZSB1bmNvcmUgbG9jayBoZWxkLgo+IAo+IFNpZ25lZC1v ZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5j b20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgICAgIHwgNjYgKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X3RyYWNlLmggICB8ICA1ICsrLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cnYuaCAgICB8ICAxICsKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgfCAg MyArLQo+ICA0IGZpbGVzIGNoYW5nZWQsIDYwIGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+IGluZGV4IGVkYTk1NDNhMDE5OS4uNmM0OTFl NjNlMDdjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gQEAgLTczNiwxMyArNzM2LDEy IEBAIHN0YXRpYyB2b2lkIGk5MTVfZW5hYmxlX2FzbGVfcGlwZXN0YXQoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+ICAvKiBDYWxsZWQgZnJvbSBkcm0gZ2VuZXJpYyBjb2RlLCBw YXNzZWQgYSAnY3J0YycsIHdoaWNoCj4gICAqIHdlIHVzZSBhcyBhIHBpcGUgaW5kZXgKPiAgICov Cj4gLXN0YXRpYyB1MzIgaTkxNV9nZXRfdmJsYW5rX2NvdW50ZXIoc3RydWN0IGRybV9kZXZpY2Ug KmRldiwgdW5zaWduZWQgaW50IHBpcGUpCj4gK3N0YXRpYyB1MzIgX19pOTE1X2dldF92Ymxhbmtf Y291bnRlcihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgewo+IC0Jc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ICsJc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4gIAlpOTE1X3JlZ190 IGhpZ2hfZnJhbWUsIGxvd19mcmFtZTsKPiAgCXUzMiBoaWdoMSwgaGlnaDIsIGxvdywgcGl4ZWws IHZibF9zdGFydCwgaHN5bmNfc3RhcnQsIGh0b3RhbDsKPiAtCWNvbnN0IHN0cnVjdCBkcm1fZGlz cGxheV9tb2RlICptb2RlID0gJmRldi0+dmJsYW5rW3BpcGVdLmh3bW9kZTsKPiAtCXVuc2lnbmVk IGxvbmcgaXJxZmxhZ3M7Cj4gKwljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSA9 ICZjcnRjLT5iYXNlLmRldi0+dmJsYW5rW2NydGMtPnBpcGVdLmh3bW9kZTsKPiAgCj4gIAlodG90 YWwgPSBtb2RlLT5jcnRjX2h0b3RhbDsKPiAgCWhzeW5jX3N0YXJ0ID0gbW9kZS0+Y3J0Y19oc3lu Y19zdGFydDsKPiBAQCAtNzU2LDEwICs3NTUsOCBAQCBzdGF0aWMgdTMyIGk5MTVfZ2V0X3ZibGFu a19jb3VudGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBlKQo+ICAJ LyogU3RhcnQgb2YgdmJsYW5rIGV2ZW50IG9jY3VycyBhdCBzdGFydCBvZiBoc3luYyAqLwo+ICAJ dmJsX3N0YXJ0IC09IGh0b3RhbCAtIGhzeW5jX3N0YXJ0Owo+ICAKPiAtCWhpZ2hfZnJhbWUgPSBQ SVBFRlJBTUUocGlwZSk7Cj4gLQlsb3dfZnJhbWUgPSBQSVBFRlJBTUVQSVhFTChwaXBlKTsKPiAt Cj4gLQlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrLCBpcnFmbGFncyk7 Cj4gKwloaWdoX2ZyYW1lID0gUElQRUZSQU1FKGNydGMtPnBpcGUpOwo+ICsJbG93X2ZyYW1lID0g UElQRUZSQU1FUElYRUwoY3J0Yy0+cGlwZSk7Cj4gIAo+ICAJLyoKPiAgCSAqIEhpZ2ggJiBsb3cg cmVnaXN0ZXIgZmllbGRzIGFyZW4ndCBzeW5jaHJvbml6ZWQsIHNvIG1ha2Ugc3VyZQo+IEBAIC03 NzIsOCArNzY5LDYgQEAgc3RhdGljIHUzMiBpOTE1X2dldF92YmxhbmtfY291bnRlcihzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPiAgCQloaWdoMiA9IEk5MTVfUkVB RF9GVyhoaWdoX2ZyYW1lKSAmIFBJUEVfRlJBTUVfSElHSF9NQVNLOwo+ICAJfSB3aGlsZSAoaGln aDEgIT0gaGlnaDIpOwo+ICAKPiAtCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldl9wcml2LT51 bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+IC0KPiAgCWhpZ2gxID4+PSBQSVBFX0ZSQU1FX0hJR0hf U0hJRlQ7Cj4gIAlwaXhlbCA9IGxvdyAmIFBJUEVfUElYRUxfTUFTSzsKPiAgCWxvdyA+Pj0gUElQ RV9GUkFNRV9MT1dfU0hJRlQ7Cj4gQEAgLTc4NiwxMSArNzgxLDYwIEBAIHN0YXRpYyB1MzIgaTkx NV9nZXRfdmJsYW5rX2NvdW50ZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgaW50 IHBpcGUpCj4gIAlyZXR1cm4gKCgoaGlnaDEgPDwgOCkgfCBsb3cpICsgKHBpeGVsID49IHZibF9z dGFydCkpICYgMHhmZmZmZmY7Cj4gIH0KPiAgCj4gK3N0YXRpYyB1MzIgaTkxNV9nZXRfdmJsYW5r X2NvdW50ZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgaW50IHBpcGUpCj4gK3sK PiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiAr CXVuc2lnbmVkIGxvbmcgaXJxZmxhZ3M7Cj4gKwl1MzIgcmV0Owo+ICsKPiArCXNwaW5fbG9ja19p cnFzYXZlKCZkZXZfcHJpdi0+dW5jb3JlLmxvY2ssIGlycWZsYWdzKTsKPiArCXJldCA9IGk5MTVf Z2V0X3ZibGFua19jb3VudGVyKGRldiwgcGlwZSk7CgpTaG91bGRuJ3QgdGhpcyBiZSBfX2k5MTVf Z2V0X3ZibGFua19jb3VudGVyID8KCj4gKwlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZkZXZfcHJp di0+dW5jb3JlLmxvY2ssIGlycWZsYWdzKTsKPiArCj4gKwlyZXR1cm4gcmV0Owo+ICt9Cj4gKwo+ ICtzdGF0aWMgdTMyIF9fZzR4X2dldF92YmxhbmtfY291bnRlcihzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0YykKPiArewo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx NShjcnRjLT5iYXNlLmRldik7Cj4gKwo+ICsJcmV0dXJuIEk5MTVfUkVBRF9GVyhQSVBFX0ZSTUNP VU5UX0c0WChjcnRjLT5waXBlKSk7Cj4gK30KPiArCj4gIHN0YXRpYyB1MzIgZzR4X2dldF92Ymxh bmtfY291bnRlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPiAg ewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ ICsJc3RydWN0IGludGVsX2NydGMgKmNydGMgPSBpbnRlbF9nZXRfY3J0Y19mb3JfcGlwZShkZXZf cHJpdiwgcGlwZSk7Cj4gKwl1bnNpZ25lZCBsb25nIGlycWZsYWdzOwo+ICsJdTMyIHJldDsKPiAr Cj4gKwlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrLCBpcnFmbGFncyk7 Cj4gKwlyZXQgPSBfX2c0eF9nZXRfdmJsYW5rX2NvdW50ZXIoY3J0Yyk7Cj4gKwlzcGluX3VubG9j a19pcnFyZXN0b3JlKCZkZXZfcHJpdi0+dW5jb3JlLmxvY2ssIGlycWZsYWdzKTsKPiArCj4gKwly ZXR1cm4gcmV0Owo+ICt9Cj4gKwo+ICt1MzIgX19pbnRlbF9jcnRjX2dldF92YmxhbmtfY291bnRl cihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiArewo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4gKwo+ICsJaWYgKElTX0c0 WChkZXZfcHJpdikgfHwgSU5URUxfR0VOKGRldl9wcml2KSA+PSA1KQo+ICsJCXJldHVybiBfX2c0 eF9nZXRfdmJsYW5rX2NvdW50ZXIoY3J0Yyk7Cj4gKwllbHNlIGlmIChJU19HRU4yKGRldl9wcml2 KSkKPiArCQlyZXR1cm4gMDsKPiArCWVsc2UKPiArCQlyZXR1cm4gX19pOTE1X2dldF92Ymxhbmtf Y291bnRlcihjcnRjKTsKPiArfQo+ICsKPiArdTMyIGludGVsX2NydGNfZ2V0X3ZibGFua19jb3Vu dGVyKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2ID0gY3J0Yy0+YmFzZS5kZXY7Cj4gKwo+ICsJaWYgKCFkZXYtPm1heF92YmxhbmtfY291bnQp Cj4gKwkJcmV0dXJuIGRybV9jcnRjX2FjY3VyYXRlX3ZibGFua19jb3VudCgmY3J0Yy0+YmFzZSk7 Cj4gIAo+IC0JcmV0dXJuIEk5MTVfUkVBRChQSVBFX0ZSTUNPVU5UX0c0WChwaXBlKSk7Cj4gKwly ZXR1cm4gZGV2LT5kcml2ZXItPmdldF92YmxhbmtfY291bnRlcihkZXYsIGNydGMtPnBpcGUpOwo+ ICB9Cj4gIAo+ICAvKgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Ry YWNlLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3RyYWNlLmgKPiBpbmRleCBlMTE2OWMw MmViMmIuLmQ0YTU3NzYyODJmZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3RyYWNlLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3RyYWNlLmgKPiBA QCAtMjgwLDkgKzI4MCw4IEBAIFRSQUNFX0VWRU5UKGk5MTVfcGlwZV91cGRhdGVfc3RhcnQsCj4g IAo+ICAJICAgIFRQX2Zhc3RfYXNzaWduKAo+ICAJCQkgICBfX2VudHJ5LT5waXBlID0gY3J0Yy0+ cGlwZTsKPiAtCQkJICAgX19lbnRyeS0+ZnJhbWUgPSBjcnRjLT5iYXNlLmRldi0+ZHJpdmVyLT5n ZXRfdmJsYW5rX2NvdW50ZXIoY3J0Yy0+YmFzZS5kZXYsCj4gLQkJCQkJCQkJCQkgICAgICAgY3J0 Yy0+cGlwZSk7Cj4gLQkJCSAgIF9fZW50cnktPnNjYW5saW5lID0gaW50ZWxfZ2V0X2NydGNfc2Nh bmxpbmUoY3J0Yyk7Cj4gKwkJCSAgIF9fZW50cnktPmZyYW1lID0gX19pbnRlbF9jcnRjX2dldF92 YmxhbmtfY291bnRlcihjcnRjKTsKPiArCQkJICAgX19lbnRyeS0+c2NhbmxpbmUgPSBfX2ludGVs X2dldF9jcnRjX3NjYW5saW5lKGNydGMpOwo+ICAJCQkgICBfX2VudHJ5LT5taW4gPSBjcnRjLT5k ZWJ1Zy5taW5fdmJsOwo+ICAJCQkgICBfX2VudHJ5LT5tYXggPSBjcnRjLT5kZWJ1Zy5tYXhfdmJs Owo+ICAJCQkgICApLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gaW5kZXggZmJkYmJlNzQx YjJmLi4wNDhmY2QzYzk2MGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IEBAIC0x NDg5LDYgKzE0ODksNyBAQCBpbnRlbF93YWl0X2Zvcl92YmxhbmtfaWZfYWN0aXZlKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgaW50IHBpcGUpCj4gIH0KPiAgCj4gIHUzMiBpbnRl bF9jcnRjX2dldF92YmxhbmtfY291bnRlcihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0Yyk7Cj4gK3Uz MiBfX2ludGVsX2NydGNfZ2V0X3ZibGFua19jb3VudGVyKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRj KTsKPiAgCj4gIGludCBpcm9ubGFrZV9nZXRfbGFuZXNfcmVxdWlyZWQoaW50IHRhcmdldF9jbG9j aywgaW50IGxpbmtfYncsIGludCBicHApOwo+ICB2b2lkIHZsdl93YWl0X3BvcnRfcmVhZHkoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nw cml0ZS5jCj4gaW5kZXggM2EzNGJlNGZkOTU2Li45NWYwOTk5ZWExOGEgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IEBAIC0xMTcsOSArMTE3LDEwIEBAIHZvaWQgaW50ZWxf cGlwZV91cGRhdGVfc3RhcnQoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm5ld19jcnRj X3N0YXRlKQo+ICAKPiAgCWNydGMtPmRlYnVnLm1pbl92YmwgPSBtaW47Cj4gIAljcnRjLT5kZWJ1 Zy5tYXhfdmJsID0gbWF4Owo+IC0JdHJhY2VfaTkxNV9waXBlX3VwZGF0ZV9zdGFydChjcnRjKTsK PiAgCj4gIAlzcGluX2xvY2soJmRldl9wcml2LT51bmNvcmUubG9jayk7Cj4gKwl0cmFjZV9pOTE1 X3BpcGVfdXBkYXRlX3N0YXJ0KGNydGMpOwo+ICsKPiAgCWZvciAoOzspIHsKPiAgCQkvKgo+ICAJ CSAqIHByZXBhcmVfdG9fd2FpdCgpIGhhcyBhIG1lbW9yeSBiYXJyaWVyLCB3aGljaCBndWFyYW50 ZWVzCj4gLS0gCj4gMi4xNi4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=