All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gaël PORTAY" <gael.portay@savoirfairelinux.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC 2/2] qt5webengine: select libnss
Date: Sun, 11 Feb 2018 11:13:20 -0500	[thread overview]
Message-ID: <20180211161320.8864-3-gael.portay@savoirfairelinux.com> (raw)
In-Reply-To: <20180211161320.8864-1-gael.portay@savoirfairelinux.com>

Since Qt WebEngine 5.10, libnss is a requirement[1] because OpenSSL
certificate validation[3] and NSS bundle[3] was dropped.

Let satisfy this requirement by selecting libnss.

Fixes:

	A suitable version of nss could not be found.
	QtWebEngine will not be built.

[1]: https://github.com/qt/qtwebengine/commit/9b449045fbd5fd3b58bcaff6cf0c5878cd6e64eb
[2]: https://codereview.chromium.org/2862543003
[3]: https://codereview.chromium.org/1882433002

Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
---
 package/qt5/qt5webengine/Config.in       | 1 +
 package/qt5/qt5webengine/qt5webengine.mk | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/qt5/qt5webengine/Config.in b/package/qt5/qt5webengine/Config.in
index 387ce0a76e..c231ad2993 100644
--- a/package/qt5/qt5webengine/Config.in
+++ b/package/qt5/qt5webengine/Config.in
@@ -38,6 +38,7 @@ config BR2_PACKAGE_QT5WEBENGINE
 	select BR2_HOSTARCH_NEEDS_IA32_COMPILER if !BR2_ARCH_IS_64 # v8/chromium
 	select BR2_PACKAGE_FFMPEG
 	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBNSS if !BR2_PACKAGE_QT5_VERSION_5_6
 	select BR2_PACKAGE_LIBVPX
 	select BR2_PACKAGE_OPUS
 	select BR2_PACKAGE_WEBP
diff --git a/package/qt5/qt5webengine/qt5webengine.mk b/package/qt5/qt5webengine/qt5webengine.mk
index 31d625d06c..69b7356a51 100644
--- a/package/qt5/qt5webengine/qt5webengine.mk
+++ b/package/qt5/qt5webengine/qt5webengine.mk
@@ -7,7 +7,7 @@
 QT5WEBENGINE_VERSION = $(QT5_VERSION)
 QT5WEBENGINE_SITE = $(QT5_SITE)
 QT5WEBENGINE_SOURCE = $(call qt5source,qtwebengine,$(QT5WEBENGINE_VERSION))
-QT5WEBENGINE_DEPENDENCIES = ffmpeg libglib2 libvpx opus webp qt5base \
+QT5WEBENGINE_DEPENDENCIES = ffmpeg libglib2 libnss libvpx opus webp qt5base \
 	qt5declarative qt5webchannel host-bison host-flex host-gperf \
 	host-pkgconf host-python
 QT5WEBENGINE_INSTALL_STAGING = YES
-- 
2.15.1

  parent reply	other threads:[~2018-02-11 16:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-11 16:13 [Buildroot] [RFC 0/2] Qt5 bump latest version to 5.10.0 Gaël PORTAY
2018-02-11 16:13 ` [Buildroot] [RFC 1/2] qt5: " Gaël PORTAY
2018-02-12 13:37   ` nimaim
2018-02-25 17:06     ` [Buildroot] Drop support for Qt 5.6? [was: [RFC 1/2] qt5: bump latest version to 5.10.0] Arnout Vandecappelle
2018-02-25 17:17       ` Baruch Siach
2018-02-25 17:26       ` Yann E. MORIN
2018-02-25 17:42         ` Nimai Mahajan
2018-02-25 17:52           ` Yann E. MORIN
2018-02-25 18:10             ` Nimai Mahajan
2018-02-25 18:28               ` Yann E. MORIN
2018-02-25 18:29                 ` Nimai Mahajan
2018-02-26  8:22                 ` Peter Korsgaard
2018-02-26 11:50                   ` Nimai Mahajan
2018-02-26 12:14                     ` Peter Korsgaard
2018-02-26 12:17                       ` Nimai Mahajan
2018-02-26 20:45                         ` Nimai Mahajan
2018-02-26  8:18       ` Peter Korsgaard
2018-02-12 21:07   ` [Buildroot] [RFC 1/2] qt5: bump latest version to 5.10.0 Gaël PORTAY
2018-02-11 16:13 ` Gaël PORTAY [this message]
2018-02-12 21:19   ` [Buildroot] [RFC 2/2] qt5webengine: select libnss Gaël PORTAY
2018-02-11 22:11 ` [Buildroot] [RFC 0/2] Qt5 bump latest version to 5.10.0 Julien CORJON
2018-02-12 18:20   ` Gaël PORTAY
2018-02-12 22:20 ` Gaël PORTAY
2018-02-13 15:23   ` Gaël PORTAY
2018-02-13 16:35     ` Gaël PORTAY
2018-02-19 22:58     ` Gaël PORTAY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180211161320.8864-3-gael.portay@savoirfairelinux.com \
    --to=gael.portay@savoirfairelinux.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.