From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224wu9fjk+c/pD4tH8C/cW1ZpFZx2FqwF+EFHBXYFmaYLdQ1VstdW09K9CA//fpkmqWv6F9W ARC-Seal: i=1; a=rsa-sha256; t=1518382950; cv=none; d=google.com; s=arc-20160816; b=L1g2EmjUHlaSnImHueGR3aRwMa7lVKOW/Sg4ASFj/gKHMJjGdACXeACb6wKHlC34Tf KPdSFC/3qRKZzlE0oOd9NmF/AVdtcRx8HcrE7qRSL9F4pxtPftnNVQFOg7mmVMD7+uoe TWtPhwaF8QQ9vBGTIXxywAyb3LaLOXXT42KFyKZGtoffegs+juya50WK7tEraXUMO3ON egUNs4gpsRMs7UA+WcohfWX7AKVTH1jInBPeS0gQlfO7AnsjGs+PEgBWH89wwnIaOT9X TUFUi59jtW0/t7ZKOp5qWyRElIik+oJCigwALKPYIceiD3OQvIdmHk42Hu9MMOGB8w8K TNDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature:dkim-signature :delivered-to:list-id:list-subscribe:list-unsubscribe:list-help :list-post:precedence:mailing-list:arc-authentication-results; bh=y1sUaAxxFgwlDEJCd8G6gSBg6RiCAZRanN6wpJ2mqDE=; b=UD38gc6RTz0SPIft764VVO9e3zL4bHGiKINuUqOzQoYlngmKvpbp4ZF0qO9A57zea7 UotTZzyRP0ozxGs5MqAIeCvfundrvyijqpdZRItBGpAEqf2rNHuYIgt2jANELQrLXYYE oAslghD3BzN4oRufljaCvUuMIWOM8jXp/9HIv3IVZpLCU/QRDqrSWxUe4/9LSk46TlzF mqAKJaanSAMyMeNigDaMsdqTw2Qd8+6pwfJxq1iuggyznq5NZ5GY7SW+n7aP//wDWw4b hQxqkyaDVOHav4Vk+nf6TEqImHooGlq1EsKBqNfDj7F7ibM5emFfgPKq9rXiCedDlbjY JACA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=uwtCRRGg; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=c/s0JH/7; spf=pass (google.com: domain of kernel-hardening-return-11708-gregkh=linuxfoundation.org@lists.openwall.com designates 195.42.179.200 as permitted sender) smtp.mailfrom=kernel-hardening-return-11708-gregkh=linuxfoundation.org@lists.openwall.com Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=uwtCRRGg; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=c/s0JH/7; spf=pass (google.com: domain of kernel-hardening-return-11708-gregkh=linuxfoundation.org@lists.openwall.com designates 195.42.179.200 as permitted sender) smtp.mailfrom=kernel-hardening-return-11708-gregkh=linuxfoundation.org@lists.openwall.com Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm List-Post: List-Help: List-Unsubscribe: List-Subscribe: Date: Sun, 11 Feb 2018 13:01:57 -0800 From: Matthew Wilcox To: Randy Dunlap Cc: Philippe Ombredanne , Igor Stoppa , Jonathan Corbet , Kees Cook , mhocko@kernel.org, labbott@redhat.com, jglisse@redhat.com, Christoph Hellwig , cl@linux.com, linux-security-module@vger.kernel.org, linux-mm@kvack.org, LKML , kernel-hardening@lists.openwall.com Subject: Re: [PATCH 2/6] genalloc: selftest Message-ID: <20180211210157.GB4680@bombadil.infradead.org> References: <20180211031920.3424-1-igor.stoppa@huawei.com> <20180211031920.3424-3-igor.stoppa@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1591489783349137888?= X-GMAIL-MSGID: =?utf-8?q?1592139920381215802?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Sun, Feb 11, 2018 at 12:27:14PM -0800, Randy Dunlap wrote: > On 02/11/18 12:22, Philippe Ombredanne wrote: > > nit... For a comment in .h this line should be instead its own comment > > as the first line: > >> +/* SPDX-License-Identifier: GPL-2.0 */ > > Why are we treating header files (.h) differently than .c files? > Either one can use the C++ "//" comment syntax. This is now documented! Documentation/process/license-rules.rst: If a specific tool cannot handle the standard comment style, then the appropriate comment mechanism which the tool accepts shall be used. This is the reason for having the "/\* \*/" style comment in C header files. There was build breakage observed with generated .lds files where 'ld' failed to parse the C++ comment. This has been fixed by now, but there are still older assembler tools which cannot handle C++ style comments. Personally, I find this disappointing. I find this: // SPDX-License-Identifier: GPL-2.0+ /* * XArray implementation * Copyright (c) 2017 Microsoft Corporation * Author: Matthew Wilcox */ much less visually appealling than /* * XArray implementation * Copyright (c) 2017 Microsoft Corporation * Author: Matthew Wilcox * SPDX-License-Identifier: GPL-2.0+ */ I can't see this variation making a tag extraction tool harder to write. From mboxrd@z Thu Jan 1 00:00:00 1970 From: willy@infradead.org (Matthew Wilcox) Date: Sun, 11 Feb 2018 13:01:57 -0800 Subject: [PATCH 2/6] genalloc: selftest In-Reply-To: References: <20180211031920.3424-1-igor.stoppa@huawei.com> <20180211031920.3424-3-igor.stoppa@huawei.com> Message-ID: <20180211210157.GB4680@bombadil.infradead.org> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Sun, Feb 11, 2018 at 12:27:14PM -0800, Randy Dunlap wrote: > On 02/11/18 12:22, Philippe Ombredanne wrote: > > nit... For a comment in .h this line should be instead its own comment > > as the first line: > >> +/* SPDX-License-Identifier: GPL-2.0 */ > > Why are we treating header files (.h) differently than .c files? > Either one can use the C++ "//" comment syntax. This is now documented! Documentation/process/license-rules.rst: If a specific tool cannot handle the standard comment style, then the appropriate comment mechanism which the tool accepts shall be used. This is the reason for having the "/\* \*/" style comment in C header files. There was build breakage observed with generated .lds files where 'ld' failed to parse the C++ comment. This has been fixed by now, but there are still older assembler tools which cannot handle C++ style comments. Personally, I find this disappointing. I find this: // SPDX-License-Identifier: GPL-2.0+ /* * XArray implementation * Copyright (c) 2017 Microsoft Corporation * Author: Matthew Wilcox */ much less visually appealling than /* * XArray implementation * Copyright (c) 2017 Microsoft Corporation * Author: Matthew Wilcox * SPDX-License-Identifier: GPL-2.0+ */ I can't see this variation making a tag extraction tool harder to write. -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f198.google.com (mail-wr0-f198.google.com [209.85.128.198]) by kanga.kvack.org (Postfix) with ESMTP id 6CAF66B0007 for ; Sun, 11 Feb 2018 16:02:13 -0500 (EST) Received: by mail-wr0-f198.google.com with SMTP id y75so2346775wrc.18 for ; Sun, 11 Feb 2018 13:02:13 -0800 (PST) Received: from casper.infradead.org (casper.infradead.org. [2001:8b0:10b:1236::1]) by mx.google.com with ESMTPS id q5si5215619wrf.390.2018.02.11.13.02.11 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Feb 2018 13:02:11 -0800 (PST) Date: Sun, 11 Feb 2018 13:01:57 -0800 From: Matthew Wilcox Subject: Re: [PATCH 2/6] genalloc: selftest Message-ID: <20180211210157.GB4680@bombadil.infradead.org> References: <20180211031920.3424-1-igor.stoppa@huawei.com> <20180211031920.3424-3-igor.stoppa@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Randy Dunlap Cc: Philippe Ombredanne , Igor Stoppa , Jonathan Corbet , Kees Cook , mhocko@kernel.org, labbott@redhat.com, jglisse@redhat.com, Christoph Hellwig , cl@linux.com, linux-security-module@vger.kernel.org, linux-mm@kvack.org, LKML , kernel-hardening@lists.openwall.com On Sun, Feb 11, 2018 at 12:27:14PM -0800, Randy Dunlap wrote: > On 02/11/18 12:22, Philippe Ombredanne wrote: > > nit... For a comment in .h this line should be instead its own comment > > as the first line: > >> +/* SPDX-License-Identifier: GPL-2.0 */ > > Why are we treating header files (.h) differently than .c files? > Either one can use the C++ "//" comment syntax. This is now documented! Documentation/process/license-rules.rst: If a specific tool cannot handle the standard comment style, then the appropriate comment mechanism which the tool accepts shall be used. This is the reason for having the "/\* \*/" style comment in C header files. There was build breakage observed with generated .lds files where 'ld' failed to parse the C++ comment. This has been fixed by now, but there are still older assembler tools which cannot handle C++ style comments. Personally, I find this disappointing. I find this: // SPDX-License-Identifier: GPL-2.0+ /* * XArray implementation * Copyright (c) 2017 Microsoft Corporation * Author: Matthew Wilcox */ much less visually appealling than /* * XArray implementation * Copyright (c) 2017 Microsoft Corporation * Author: Matthew Wilcox * SPDX-License-Identifier: GPL-2.0+ */ I can't see this variation making a tag extraction tool harder to write. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org