From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: [PATCH v2] ethdev: make ethdev data cache aligned Date: Mon, 12 Feb 2018 11:24:39 +0530 Message-ID: <20180212055439.6462-1-jerin.jacob@caviumnetworks.com> References: <20180210094220.16201-1-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain Cc: ferruh.yigit@intel.com, Jerin Jacob , Matan Azrad , Thomas Monjalon , Konstantin Ananyev , Pavan Nikhilesh To: dev@dpdk.org Return-path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0061.outbound.protection.outlook.com [104.47.42.61]) by dpdk.org (Postfix) with ESMTP id 102BF1B304 for ; Mon, 12 Feb 2018 06:55:19 +0100 (CET) In-Reply-To: <20180210094220.16201-1-jerin.jacob@caviumnetworks.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since struct rte_eth_dev_data used in the fast path, making it as cache aligned. Fixes: af75078fece3 ("first public release") Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: Matan Azrad Cc: Thomas Monjalon Cc: Konstantin Ananyev Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh --- v2: - Change the git comments based on Matan's feedback https://dpdk.org/dev/patchwork/patch/35104/ - Some platform like thunderx + l3fwd showed 1% regression in the performance with 5b7ba31148a8 ("ethdev: add port ownership") in one port setup. - If there are no objection for this change then request to take it for v18.02 release. --- lib/librte_ether/rte_ethdev_core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev_core.h b/lib/librte_ether/rte_ethdev_core.h index 315b31723..e5681e466 100644 --- a/lib/librte_ether/rte_ethdev_core.h +++ b/lib/librte_ether/rte_ethdev_core.h @@ -601,7 +601,7 @@ struct rte_eth_dev_data { struct rte_vlan_filter_conf vlan_filter_conf; /**< VLAN filter configuration. */ struct rte_eth_dev_owner owner; /**< The port owner. */ -}; +} __rte_cache_aligned; /** * @internal -- 2.16.1