From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH 2/2] vhost: don't take access_lock on
 VHOST_USER_RESET_OWNER
Date: Mon, 12 Feb 2018 17:40:07 +0800
Message-ID: <20180212094007.afnnc6lzeglpwb4a@debian>
References: <20180209142654.29409-1-maxime.coquelin@redhat.com>
 <20180209142654.29409-3-maxime.coquelin@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: yliu@fridaylinux.org, ferruh.yigit@intel.com, victork@redhat.com,
 dev@dpdk.org, stable@dpdk.org, zhihong.wang@intel.com,
 qian.q.xu@intel.com, lei.a.yao@intel.com
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <20180209142654.29409-3-maxime.coquelin@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Feb 09, 2018 at 03:26:54PM +0100, Maxime Coquelin wrote:
> A deadlock happens when handling VHOST_USER_RESET_OWNER request
> for the same reason the lock is not taken for
> VHOST_USER_GET_VRING_BASE.
> 
> It is safe not to take the lock, as the queues are no more used
> by the application when the virtqueues and the device are reset.
> 
> Fixes: a3688046995f ("vhost: protect active rings from async ring changes")
> Cc: stable@dpdk.org
> 
> Cc: Victor Kaplansky <victork@redhat.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks for the work!

Best regards,
Tiwei Bie