From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933373AbeBLJpE (ORCPT ); Mon, 12 Feb 2018 04:45:04 -0500 Received: from mailout3.hostsharing.net ([176.9.242.54]:48681 "EHLO mailout3.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933089AbeBLJpD (ORCPT ); Mon, 12 Feb 2018 04:45:03 -0500 Date: Mon, 12 Feb 2018 10:45:00 +0100 From: Lukas Wunner To: Mike Lothian Cc: Tejun Heo , Lai Jiangshan , Alex Deucher , Dave Airlie , Ben Skeggs , Ismo Toijala , nouveau@lists.freedesktop.org, Intel Graphics Development , Liviu Dudau , Linux Kernel Mailing List , Maling list - DRI developers , Hans de Goede , Peter Wu Subject: Re: [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers Message-ID: <20180212094500.22nvzzzpy6vrbqgc@wunner.de> References: <20180211192314.GA22869@wunner.de> <20180211194154.GB22869@wunner.de> <20180212033947.GA19049@wunner.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 12, 2018 at 09:03:26AM +0000, Mike Lothian wrote: > On 12 February 2018 at 03:39, Lukas Wunner wrote: > > On Mon, Feb 12, 2018 at 12:35:51AM +0000, Mike Lothian wrote: > > > I've not been able to reproduce the original problem you're trying to > > > solve on amdgpu thats with or without your patch set and the above > > > "trigger" too > > > > > > Is anything else required to trigger it, I started multiple DRI_PRIME > > > glxgears, in parallel, serial waiting the 12 seconds and serial within > > > the 12 seconds and I couldn't reproduce it > > > > The discrete GPU needs to runtime suspend, that's the trigger, > > so no DRI_PRIME executables should be running. Just let it > > autosuspend after boot. Do you see "waiting 12 sec" messages > > in dmesg? If not it's not autosuspending. > > Yes I'm seeing those messages, I'm just not seeing the hangs > > I've attached the dmesg in case you're interested Okay the reason you're not seeing deadlocks is because the output poll worker is not enabled. And the output poll worker is not enabled because your discrete GPU doesn't have any outputs: [ 0.265568] [drm:dc_create] *ERROR* DC: Number of connectors is zero! The outputs are only polled if there are connectors which have the DRM_CONNECTOR_POLL_CONNECT or DRM_CONNECTOR_POLL_DISCONNECT flag set. And that only ever seems to be the case for VGA and DVI. We know based on bugzilla reports that hybrid graphics laptops do exist which poll outputs with radeon and nouveau. If there are no laptops supported by amdgpu whose discrete GPU has polled connectors, then patch [5/5] would be unnecessary. That is for Alex to decide. However that is very good to know, so thanks a lot for your testing efforts, much appreciated! Kind regards, Lukas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers Date: Mon, 12 Feb 2018 10:45:00 +0100 Message-ID: <20180212094500.22nvzzzpy6vrbqgc@wunner.de> References: <20180211192314.GA22869@wunner.de> <20180211194154.GB22869@wunner.de> <20180212033947.GA19049@wunner.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mike Lothian Cc: Ismo Toijala , Hans de Goede , nouveau@lists.freedesktop.org, Intel Graphics Development , Lai Jiangshan , Linux Kernel Mailing List , Maling list - DRI developers , Alex Deucher , Ben Skeggs , Tejun Heo , Dave Airlie , Liviu Dudau , Peter Wu List-Id: nouveau.vger.kernel.org T24gTW9uLCBGZWIgMTIsIDIwMTggYXQgMDk6MDM6MjZBTSArMDAwMCwgTWlrZSBMb3RoaWFuIHdy b3RlOgo+IE9uIDEyIEZlYnJ1YXJ5IDIwMTggYXQgMDM6MzksIEx1a2FzIFd1bm5lciA8bHVrYXNA d3VubmVyLmRlPiB3cm90ZToKPiA+IE9uIE1vbiwgRmViIDEyLCAyMDE4IGF0IDEyOjM1OjUxQU0g KzAwMDAsIE1pa2UgTG90aGlhbiB3cm90ZToKPiA+ID4gSSd2ZSBub3QgYmVlbiBhYmxlIHRvIHJl cHJvZHVjZSB0aGUgb3JpZ2luYWwgcHJvYmxlbSB5b3UncmUgdHJ5aW5nIHRvCj4gPiA+IHNvbHZl IG9uIGFtZGdwdSB0aGF0cyB3aXRoIG9yIHdpdGhvdXQgeW91ciBwYXRjaCBzZXQgYW5kIHRoZSBh Ym92ZQo+ID4gPiAidHJpZ2dlciIgdG9vCj4gPiA+Cj4gPiA+IElzIGFueXRoaW5nIGVsc2UgcmVx dWlyZWQgdG8gdHJpZ2dlciBpdCwgSSBzdGFydGVkIG11bHRpcGxlIERSSV9QUklNRQo+ID4gPiBn bHhnZWFycywgaW4gcGFyYWxsZWwsIHNlcmlhbCB3YWl0aW5nIHRoZSAxMiBzZWNvbmRzIGFuZCBz ZXJpYWwgd2l0aGluCj4gPiA+IHRoZSAxMiBzZWNvbmRzIGFuZCBJIGNvdWxkbid0IHJlcHJvZHVj ZSBpdAo+ID4KPiA+IFRoZSBkaXNjcmV0ZSBHUFUgbmVlZHMgdG8gcnVudGltZSBzdXNwZW5kLCB0 aGF0J3MgdGhlIHRyaWdnZXIsCj4gPiBzbyBubyBEUklfUFJJTUUgZXhlY3V0YWJsZXMgc2hvdWxk IGJlIHJ1bm5pbmcuICBKdXN0IGxldCBpdAo+ID4gYXV0b3N1c3BlbmQgYWZ0ZXIgYm9vdC4gIERv IHlvdSBzZWUgIndhaXRpbmcgMTIgc2VjIiBtZXNzYWdlcwo+ID4gaW4gZG1lc2c/ICBJZiBub3Qg aXQncyBub3QgYXV0b3N1c3BlbmRpbmcuCj4gCj4gWWVzIEknbSBzZWVpbmcgdGhvc2UgbWVzc2Fn ZXMsIEknbSBqdXN0IG5vdCBzZWVpbmcgdGhlIGhhbmdzCj4gCj4gSSd2ZSBhdHRhY2hlZCB0aGUg ZG1lc2cgaW4gY2FzZSB5b3UncmUgaW50ZXJlc3RlZAoKT2theSB0aGUgcmVhc29uIHlvdSdyZSBu b3Qgc2VlaW5nIGRlYWRsb2NrcyBpcyBiZWNhdXNlIHRoZSBvdXRwdXQgcG9sbAp3b3JrZXIgaXMg bm90IGVuYWJsZWQuICBBbmQgdGhlIG91dHB1dCBwb2xsIHdvcmtlciBpcyBub3QgZW5hYmxlZApi ZWNhdXNlIHlvdXIgZGlzY3JldGUgR1BVIGRvZXNuJ3QgaGF2ZSBhbnkgb3V0cHV0czoKClsgICAg MC4yNjU1NjhdIFtkcm06ZGNfY3JlYXRlXSAqRVJST1IqIERDOiBOdW1iZXIgb2YgY29ubmVjdG9y cyBpcyB6ZXJvIQoKVGhlIG91dHB1dHMgYXJlIG9ubHkgcG9sbGVkIGlmIHRoZXJlIGFyZSBjb25u ZWN0b3JzIHdoaWNoIGhhdmUgdGhlCkRSTV9DT05ORUNUT1JfUE9MTF9DT05ORUNUIG9yIERSTV9D T05ORUNUT1JfUE9MTF9ESVNDT05ORUNUIGZsYWcgc2V0LgpBbmQgdGhhdCBvbmx5IGV2ZXIgc2Vl bXMgdG8gYmUgdGhlIGNhc2UgZm9yIFZHQSBhbmQgRFZJLgoKV2Uga25vdyBiYXNlZCBvbiBidWd6 aWxsYSByZXBvcnRzIHRoYXQgaHlicmlkIGdyYXBoaWNzIGxhcHRvcHMgZG8gZXhpc3QKd2hpY2gg cG9sbCBvdXRwdXRzIHdpdGggcmFkZW9uIGFuZCBub3V2ZWF1LiAgSWYgdGhlcmUgYXJlIG5vIGxh cHRvcHMKc3VwcG9ydGVkIGJ5IGFtZGdwdSB3aG9zZSBkaXNjcmV0ZSBHUFUgaGFzIHBvbGxlZCBj b25uZWN0b3JzLCB0aGVuCnBhdGNoIFs1LzVdIHdvdWxkIGJlIHVubmVjZXNzYXJ5LiAgVGhhdCBp cyBmb3IgQWxleCB0byBkZWNpZGUuCgpIb3dldmVyIHRoYXQgaXMgdmVyeSBnb29kIHRvIGtub3cs IHNvIHRoYW5rcyBhIGxvdCBmb3IgeW91ciB0ZXN0aW5nCmVmZm9ydHMsIG11Y2ggYXBwcmVjaWF0 ZWQhCgpLaW5kIHJlZ2FyZHMsCgpMdWthcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK