From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH net] sctp: add SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN conversion in sctp_cname Date: Mon, 12 Feb 2018 10:29:57 -0200 Message-ID: <20180212122957.GJ7402@localhost.localdomain> References: <2ca12376b0b3b73833878279f20183bf03128626.1518431391.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: network dev , linux-sctp@vger.kernel.org, davem@davemloft.net, Neil Horman To: Xin Long Return-path: Received: from mail-qk0-f196.google.com ([209.85.220.196]:35104 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751483AbeBLMaC (ORCPT ); Mon, 12 Feb 2018 07:30:02 -0500 Content-Disposition: inline In-Reply-To: <2ca12376b0b3b73833878279f20183bf03128626.1518431391.git.lucien.xin@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Feb 12, 2018 at 06:29:51PM +0800, Xin Long wrote: > After the support for SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN chunks, > the corresp conversion in sctp_cname should also be added. Otherwise, > in some places, pr_debug will print them as "unknown chunk". > > Signed-off-by: Xin Long Acked-by: Marcelo Ricardo Leitner > --- > net/sctp/debug.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/net/sctp/debug.c b/net/sctp/debug.c > index 291c97b..8f6c2e8 100644 > --- a/net/sctp/debug.c > +++ b/net/sctp/debug.c > @@ -81,6 +81,12 @@ const char *sctp_cname(const union sctp_subtype cid) > case SCTP_CID_RECONF: > return "RECONF"; > > + case SCTP_CID_I_DATA: > + return "I_DATA"; > + > + case SCTP_CID_I_FWD_TSN: > + return "I_FWD_TSN"; > + > default: > break; > } > -- > 2.1.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Date: Mon, 12 Feb 2018 12:29:57 +0000 Subject: Re: [PATCH net] sctp: add SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN conversion in sctp_cname Message-Id: <20180212122957.GJ7402@localhost.localdomain> List-Id: References: <2ca12376b0b3b73833878279f20183bf03128626.1518431391.git.lucien.xin@gmail.com> In-Reply-To: <2ca12376b0b3b73833878279f20183bf03128626.1518431391.git.lucien.xin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Xin Long Cc: network dev , linux-sctp@vger.kernel.org, davem@davemloft.net, Neil Horman On Mon, Feb 12, 2018 at 06:29:51PM +0800, Xin Long wrote: > After the support for SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN chunks, > the corresp conversion in sctp_cname should also be added. Otherwise, > in some places, pr_debug will print them as "unknown chunk". > > Signed-off-by: Xin Long Acked-by: Marcelo Ricardo Leitner > --- > net/sctp/debug.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/net/sctp/debug.c b/net/sctp/debug.c > index 291c97b..8f6c2e8 100644 > --- a/net/sctp/debug.c > +++ b/net/sctp/debug.c > @@ -81,6 +81,12 @@ const char *sctp_cname(const union sctp_subtype cid) > case SCTP_CID_RECONF: > return "RECONF"; > > + case SCTP_CID_I_DATA: > + return "I_DATA"; > + > + case SCTP_CID_I_FWD_TSN: > + return "I_FWD_TSN"; > + > default: > break; > } > -- > 2.1.0 >